Feat/activity optimistic activities (#4009)

* Fix naming

* Fixed cache.evict bug for relation target deletion

* Fixed cascade delete activity targets

* Working version

* Fix

* fix

* WIP

* Fixed optimistic effect target inline cell

* Removed openCreateActivityDrawer v1

* Ok for timeline

* Removed console.log

* Fix update record optimistic effect

* Refactored activity queries into useActivities for everything

* Fixed bugs

* Cleaned

* Fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/object-record/hooks/useDeleteManyRecords.ts

@@ -12,6 +12,10 @@ type useDeleteOneRecordProps = {
   refetchFindManyQuery?: boolean;
 };
 
+type DeleteManyRecordsOptions = {
+  skipOptimisticEffect?: boolean;
+};
+
 export const useDeleteManyRecords = ({
   objectNameSingular,
 }: useDeleteOneRecordProps) => {
@@ -26,34 +30,41 @@ export const useDeleteManyRecords = ({
     objectMetadataItem.namePlural,
   );
 
-  const deleteManyRecords = async (idsToDelete: string[]) => {
+  const deleteManyRecords = async (
+    idsToDelete: string[],
+    options?: DeleteManyRecordsOptions,
+  ) => {
     const deletedRecords = await apolloClient.mutate({
       mutation: deleteManyRecordsMutation,
       variables: {
         filter: { id: { in: idsToDelete } },
       },
-      optimisticResponse: {
-        [mutationResponseField]: idsToDelete.map((idToDelete) => ({
-          __typename: capitalize(objectNameSingular),
-          id: idToDelete,
-        })),
-      },
-      update: (cache, { data }) => {
-        const records = data?.[mutationResponseField];
+      optimisticResponse: options?.skipOptimisticEffect
+        ? undefined
+        : {
+            [mutationResponseField]: idsToDelete.map((idToDelete) => ({
+              __typename: capitalize(objectNameSingular),
+              id: idToDelete,
+            })),
+          },
+      update: options?.skipOptimisticEffect
+        ? undefined
+        : (cache, { data }) => {
+            const records = data?.[mutationResponseField];
 
-        if (!records?.length) return;
+            if (!records?.length) return;
 
-        const cachedRecords = records
-          .map((record) => getRecordFromCache(record.id, cache))
-          .filter(isDefined);
+            const cachedRecords = records
+              .map((record) => getRecordFromCache(record.id, cache))
+              .filter(isDefined);
 
-        triggerDeleteRecordsOptimisticEffect({
-          cache,
-          objectMetadataItem,
-          recordsToDelete: cachedRecords,
-          objectMetadataItems,
-        });
-      },
+            triggerDeleteRecordsOptimisticEffect({
+              cache,
+              objectMetadataItem,
+              recordsToDelete: cachedRecords,
+              objectMetadataItems,
+            });
+          },
     });
 
     return deletedRecords.data?.[mutationResponseField] ?? null;

packages/twenty-front/src/modules/object-record/hooks/useFindOneRecord.ts

@@ -4,6 +4,7 @@ import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadata
 import { ObjectMetadataItemIdentifier } from '@/object-metadata/types/ObjectMetadataItemIdentifier';
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 
+// TODO: fix connection in relation => automatically change to an array
 export const useFindOneRecord = <T extends ObjectRecord = ObjectRecord>({
   objectNameSingular,
   objectRecordId = '',