Remove isServerlessFunctionSettingsEnabled feature flag (#9797)

Removes `isFunctionSettingsEnabled` feature flag
We consider this featureFlag as false for everyone. We decided to keep
the code in the code base for now
This commit is contained in:
martmull
2025-01-22 22:39:52 +01:00
committed by GitHub
parent e881616822
commit 3ab193f298
8 changed files with 14 additions and 23 deletions

View File

@ -11,9 +11,9 @@ export const AppRouter = () => {
const isFreeAccessEnabled = useIsFeatureEnabled(
FeatureFlagKey.IsFreeAccessEnabled,
);
const isServerlessFunctionSettingsEnabled = useIsFeatureEnabled(
FeatureFlagKey.IsFunctionSettingsEnabled,
);
// We want to disable serverless function settings but keep the code for now
const isFunctionSettingsEnabled = false;
const isBillingPageEnabled =
billing?.isBillingEnabled && !isFreeAccessEnabled;
@ -26,7 +26,7 @@ export const AppRouter = () => {
<RouterProvider
router={useCreateAppRouter(
isBillingPageEnabled,
isServerlessFunctionSettingsEnabled,
isFunctionSettingsEnabled,
isAdminPageEnabled,
)}
/>

View File

@ -261,13 +261,13 @@ const SettingsLab = lazy(() =>
type SettingsRoutesProps = {
isBillingEnabled?: boolean;
isServerlessFunctionSettingsEnabled?: boolean;
isFunctionSettingsEnabled?: boolean;
isAdminPageEnabled?: boolean;
};
export const SettingsRoutes = ({
isBillingEnabled,
isServerlessFunctionSettingsEnabled,
isFunctionSettingsEnabled,
isAdminPageEnabled,
}: SettingsRoutesProps) => (
<Suspense fallback={<SettingsSkeletonLoader />}>
@ -305,7 +305,6 @@ export const SettingsRoutes = ({
/>
<Route path={SettingsPath.NewObject} element={<SettingsNewObject />} />
<Route path={SettingsPath.Developers} element={<SettingsDevelopers />} />
<Route
path={SettingsPath.DevelopersNewApiKey}
element={<SettingsDevelopersApiKeysNew />}
@ -322,7 +321,7 @@ export const SettingsRoutes = ({
path={SettingsPath.DevelopersNewWebhookDetail}
element={<SettingsDevelopersWebhooksDetail />}
/>
{isServerlessFunctionSettingsEnabled && (
{isFunctionSettingsEnabled && (
<>
<Route
path={SettingsPath.ServerlessFunctions}

View File

@ -28,7 +28,7 @@ import { SyncEmails } from '~/pages/onboarding/SyncEmails';
export const useCreateAppRouter = (
isBillingEnabled?: boolean,
isServerlessFunctionSettingsEnabled?: boolean,
isFunctionSettingsEnabled?: boolean,
isAdminPageEnabled?: boolean,
) =>
createBrowserRouter(
@ -62,9 +62,7 @@ export const useCreateAppRouter = (
element={
<SettingsRoutes
isBillingEnabled={isBillingEnabled}
isServerlessFunctionSettingsEnabled={
isServerlessFunctionSettingsEnabled
}
isFunctionSettingsEnabled={isFunctionSettingsEnabled}
isAdminPageEnabled={isAdminPageEnabled}
/>
}

View File

@ -55,9 +55,11 @@ export const SettingsNavigationDrawerItems = () => {
const { t } = useLingui();
const billing = useRecoilValue(billingState);
const isFunctionSettingsEnabled = useIsFeatureEnabled(
FeatureFlagKey.IsFunctionSettingsEnabled,
);
// We want to disable this serverless function setting menu but keep the code
// for now
const isFunctionSettingsEnabled = false;
const isFreeAccessEnabled = useIsFeatureEnabled(
FeatureFlagKey.IsFreeAccessEnabled,
);