Remove isServerlessFunctionSettingsEnabled feature flag (#9797)

Removes `isFunctionSettingsEnabled` feature flag
We consider this featureFlag as false for everyone. We decided to keep
the code in the code base for now

packages/twenty-front/src/generated-metadata/graphql.ts

@@ -460,7 +460,6 @@ export enum FeatureFlagKey {
   IsCopilotEnabled = 'IsCopilotEnabled',
   IsEventObjectEnabled = 'IsEventObjectEnabled',
   IsFreeAccessEnabled = 'IsFreeAccessEnabled',
-  IsFunctionSettingsEnabled = 'IsFunctionSettingsEnabled',
   IsJsonFilterEnabled = 'IsJsonFilterEnabled',
   IsLocalizationEnabled = 'IsLocalizationEnabled',
   IsMicrosoftSyncEnabled = 'IsMicrosoftSyncEnabled',

packages/twenty-front/src/generated/graphql.tsx

@@ -392,7 +392,6 @@ export enum FeatureFlagKey {
   IsCopilotEnabled = 'IsCopilotEnabled',
   IsEventObjectEnabled = 'IsEventObjectEnabled',
   IsFreeAccessEnabled = 'IsFreeAccessEnabled',
-  IsFunctionSettingsEnabled = 'IsFunctionSettingsEnabled',
   IsJsonFilterEnabled = 'IsJsonFilterEnabled',
   IsLocalizationEnabled = 'IsLocalizationEnabled',
   IsMicrosoftSyncEnabled = 'IsMicrosoftSyncEnabled',

packages/twenty-front/src/modules/app/components/AppRouter.tsx

@@ -11,9 +11,9 @@ export const AppRouter = () => {
   const isFreeAccessEnabled = useIsFeatureEnabled(
     FeatureFlagKey.IsFreeAccessEnabled,
   );
-  const isServerlessFunctionSettingsEnabled = useIsFeatureEnabled(
+
-    FeatureFlagKey.IsFunctionSettingsEnabled,
+  // We want to disable serverless function settings but keep the code for now
-  );
+  const isFunctionSettingsEnabled = false;
 
   const isBillingPageEnabled =
     billing?.isBillingEnabled && !isFreeAccessEnabled;
@@ -26,7 +26,7 @@ export const AppRouter = () => {
     <RouterProvider
       router={useCreateAppRouter(
         isBillingPageEnabled,
-        isServerlessFunctionSettingsEnabled,
+        isFunctionSettingsEnabled,
         isAdminPageEnabled,
       )}
     />

packages/twenty-front/src/modules/app/components/SettingsRoutes.tsx

@@ -261,13 +261,13 @@ const SettingsLab = lazy(() =>
 
 type SettingsRoutesProps = {
   isBillingEnabled?: boolean;
-  isServerlessFunctionSettingsEnabled?: boolean;
+  isFunctionSettingsEnabled?: boolean;
   isAdminPageEnabled?: boolean;
 };
 
 export const SettingsRoutes = ({
   isBillingEnabled,
-  isServerlessFunctionSettingsEnabled,
+  isFunctionSettingsEnabled,
   isAdminPageEnabled,
 }: SettingsRoutesProps) => (
   <Suspense fallback={<SettingsSkeletonLoader />}>
@@ -305,7 +305,6 @@ export const SettingsRoutes = ({
       />
       <Route path={SettingsPath.NewObject} element={<SettingsNewObject />} />
       <Route path={SettingsPath.Developers} element={<SettingsDevelopers />} />
-
       <Route
         path={SettingsPath.DevelopersNewApiKey}
         element={<SettingsDevelopersApiKeysNew />}
@@ -322,7 +321,7 @@ export const SettingsRoutes = ({
         path={SettingsPath.DevelopersNewWebhookDetail}
         element={<SettingsDevelopersWebhooksDetail />}
       />
-      {isServerlessFunctionSettingsEnabled && (
+      {isFunctionSettingsEnabled && (
         <>
           <Route
             path={SettingsPath.ServerlessFunctions}

packages/twenty-front/src/modules/app/hooks/useCreateAppRouter.tsx

@@ -28,7 +28,7 @@ import { SyncEmails } from '~/pages/onboarding/SyncEmails';
 
 export const useCreateAppRouter = (
   isBillingEnabled?: boolean,
-  isServerlessFunctionSettingsEnabled?: boolean,
+  isFunctionSettingsEnabled?: boolean,
   isAdminPageEnabled?: boolean,
 ) =>
   createBrowserRouter(
@@ -62,9 +62,7 @@ export const useCreateAppRouter = (
             element={
               <SettingsRoutes
                 isBillingEnabled={isBillingEnabled}
-                isServerlessFunctionSettingsEnabled={
+                isFunctionSettingsEnabled={isFunctionSettingsEnabled}
-                  isServerlessFunctionSettingsEnabled
-                }
                 isAdminPageEnabled={isAdminPageEnabled}
               />
             }

packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx

@@ -55,9 +55,11 @@ export const SettingsNavigationDrawerItems = () => {
   const { t } = useLingui();
 
   const billing = useRecoilValue(billingState);
-  const isFunctionSettingsEnabled = useIsFeatureEnabled(
+
-    FeatureFlagKey.IsFunctionSettingsEnabled,
+  // We want to disable this serverless function setting menu but keep the code
-  );
+  // for now
+  const isFunctionSettingsEnabled = false;
+
   const isFreeAccessEnabled = useIsFeatureEnabled(
     FeatureFlagKey.IsFreeAccessEnabled,
   );

packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts

@@ -35,11 +35,6 @@ export const seedFeatureFlags = async (
         workspaceId: workspaceId,
         value: true,
       },
-      {
-        key: FeatureFlagKey.IsFunctionSettingsEnabled,
-        workspaceId: workspaceId,
-        value: false,
-      },
       {
         key: FeatureFlagKey.IsWorkflowEnabled,
         workspaceId: workspaceId,

packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts

@@ -5,7 +5,6 @@ export enum FeatureFlagKey {
   IsStripeIntegrationEnabled = 'IS_STRIPE_INTEGRATION_ENABLED',
   IsCopilotEnabled = 'IS_COPILOT_ENABLED',
   IsFreeAccessEnabled = 'IS_FREE_ACCESS_ENABLED',
-  IsFunctionSettingsEnabled = 'IS_FUNCTION_SETTINGS_ENABLED',
   IsWorkflowEnabled = 'IS_WORKFLOW_ENABLED',
   IsAnalyticsV2Enabled = 'IS_ANALYTICS_V2_ENABLED',
   IsUniqueIndexesEnabled = 'IS_UNIQUE_INDEXES_ENABLED',