Remove the source handle for leaf nodes (#10057)
- Do not render a source handle for the leaf nodes - Upgrade the `@xyflow/react` library | Before | After | |--------|--------| |  |  | ## Other options considered React Flow exposes a hook to get the connections of the current node. I tried to use this hook – which makes things way simpler – but I couldn't find a way to make it work in Storybook. I had two options: 1. Set up React Flow to render the nodes properly, 2. Mock the hook in Storybook. The first option was hard to achieve as the `<Reactflow />` component renders a whole flow, and it doesn't play well with the idea of rendering a single node in a story. The second option seemed overkill as mocking modules with Storybook is not straightforward. See https://storybook.js.org/docs/writing-stories/mocking-data-and-modules/mocking-modules. I chose to keep the initial version of my code, written before I spot a function simplifying the code. We can give it a look another time.
This commit is contained in:
committed by
GitHub
parent
30e4fdbd06
commit
3cc66fe712
9
packages/twenty-front/src/testing/utils/getUuidV4Mock.ts
Normal file
9
packages/twenty-front/src/testing/utils/getUuidV4Mock.ts
Normal file
@ -0,0 +1,9 @@
|
||||
const baseUuid = '8f3b2121-f194-4ba4-9fbf-';
|
||||
|
||||
export const getUuidV4Mock = () => {
|
||||
let id = 0;
|
||||
|
||||
return () => {
|
||||
return baseUuid + id++;
|
||||
};
|
||||
};
|
||||
Reference in New Issue
Block a user