From 3e7ec4f756c8e5dfe18dfdea4fa3fe849752fba3 Mon Sep 17 00:00:00 2001 From: Thomas Trompette Date: Tue, 25 Mar 2025 18:17:38 +0100 Subject: [PATCH] Allow empty string for primary link (#11171) Fixes https://github.com/twentyhq/twenty/issues/11166 https://github.com/user-attachments/assets/72208ac9-c19d-4c19-b305-40d6318310ed --- .../meta-types/input/components/LinksFieldInput.tsx | 2 +- .../record-field/types/guards/isFieldLinksValue.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx index ff826f59e..7cda497bb 100644 --- a/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx +++ b/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx @@ -3,9 +3,9 @@ import { LinksFieldMenuItem } from '@/object-record/record-field/meta-types/inpu import { recordFieldInputIsFieldInErrorComponentState } from '@/object-record/record-field/states/recordFieldInputIsFieldInErrorComponentState'; import { useSetRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentStateV2'; import { useMemo } from 'react'; +import { absoluteUrlSchema, isDefined } from 'twenty-shared/utils'; import { FieldMetadataType } from '~/generated-metadata/graphql'; import { MultiItemFieldInput } from './MultiItemFieldInput'; -import { absoluteUrlSchema, isDefined } from 'twenty-shared/utils'; type LinksFieldInputProps = { onCancel?: () => void; diff --git a/packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldLinksValue.ts b/packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldLinksValue.ts index 87be4c89a..071d495e2 100644 --- a/packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldLinksValue.ts +++ b/packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldLinksValue.ts @@ -1,10 +1,10 @@ +import { absoluteUrlSchema } from 'twenty-shared/utils'; import { z } from 'zod'; import { FieldLinksValue } from '../FieldMetadata'; -import { absoluteUrlSchema } from 'twenty-shared/utils'; export const linksSchema = z.object({ primaryLinkLabel: z.string(), - primaryLinkUrl: absoluteUrlSchema, + primaryLinkUrl: absoluteUrlSchema.or(z.string().length(0)), secondaryLinks: z .array(z.object({ label: z.string(), url: absoluteUrlSchema })) .nullable(),