From 40c5f7208005218e6d1fbcbb2cf6305000950a47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tha=C3=AFs?= <guigon.thais@gmail.com>
Date: Fri, 27 Oct 2023 17:59:57 +0200
Subject: [PATCH] feat: save activated/disabled fields in New Field - Step 1
 page (#2226)

* feat: save activated/disabled fields in New Field - Step 1 page

Closes #2170

* fix: fix objectSlug

* Console.log

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
---
 .../TableOptionsDropdownContent.tsx           |  1 -
 .../SettingsObjectNewFieldStep1.tsx           | 86 +++++++++++++++----
 2 files changed, 67 insertions(+), 20 deletions(-)

diff --git a/front/src/modules/ui/data/data-table/options/components/TableOptionsDropdownContent.tsx b/front/src/modules/ui/data/data-table/options/components/TableOptionsDropdownContent.tsx
index 1ce5c17fa..c5c54d13d 100644
--- a/front/src/modules/ui/data/data-table/options/components/TableOptionsDropdownContent.tsx
+++ b/front/src/modules/ui/data/data-table/options/components/TableOptionsDropdownContent.tsx
@@ -81,7 +81,6 @@ export const TableOptionsDropdownContent = () => {
   useScopedHotkeys(
     Key.Enter,
     () => {
-      console.log('enter');
       const name = viewEditInputRef.current?.value;
       handleViewNameSubmit(name);
       resetMenu();
diff --git a/front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep1.tsx b/front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep1.tsx
index f60923ff2..c62c50edd 100644
--- a/front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep1.tsx
+++ b/front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep1.tsx
@@ -1,7 +1,8 @@
-import { useEffect } from 'react';
+import { useEffect, useState } from 'react';
 import { useNavigate, useParams } from 'react-router-dom';
 import styled from '@emotion/styled';
 
+import { useMetadataField } from '@/metadata/hooks/useMetadataField';
 import { useMetadataObjectForSettings } from '@/metadata/hooks/useMetadataObjectForSettings';
 import { SaveAndCancelButtons } from '@/settings/components/SaveAndCancelButtons/SaveAndCancelButtons';
 import { SettingsHeaderContainer } from '@/settings/components/SettingsHeaderContainer';
@@ -41,19 +42,58 @@ export const SettingsObjectNewFieldStep1 = () => {
 
   const activeMetadataObject = findActiveMetadataObjectBySlug(objectSlug);
 
+  const { activateMetadataField, disableMetadataField } = useMetadataField();
+  const [metadataFields, setMetadataFields] = useState(
+    activeMetadataObject?.fields ?? [],
+  );
+
+  const activeMetadataFields = metadataFields.filter((field) => field.isActive);
+  const disabledMetadataFields = metadataFields.filter(
+    (field) => !field.isActive,
+  );
+
+  const canSave = metadataFields.some(
+    (field, index) =>
+      field.isActive !== activeMetadataObject?.fields[index].isActive,
+  );
+
   useEffect(() => {
     if (loading) return;
-    if (!activeMetadataObject) navigate(AppPath.NotFound);
-  }, [activeMetadataObject, loading, navigate]);
+
+    if (!activeMetadataObject) {
+      navigate(AppPath.NotFound);
+      return;
+    }
+
+    if (!metadataFields.length) setMetadataFields(activeMetadataObject.fields);
+  }, [activeMetadataObject, metadataFields.length, loading, navigate]);
 
   if (!activeMetadataObject) return null;
 
-  const activeMetadataFields = activeMetadataObject.fields.filter(
-    (metadataField) => metadataField.isActive,
-  );
-  const disabledMetadataFields = activeMetadataObject.fields.filter(
-    (metadataField) => !metadataField.isActive,
-  );
+  const handleToggleField = (fieldId: string) =>
+    setMetadataFields((previousFields) =>
+      previousFields.map((field) =>
+        field.id === fieldId ? { ...field, isActive: !field.isActive } : field,
+      ),
+    );
+
+  const handleSave = async () => {
+    await Promise.all(
+      metadataFields.map((metadataField, index) => {
+        if (
+          metadataField.isActive === activeMetadataObject.fields[index].isActive
+        ) {
+          return;
+        }
+
+        return metadataField.isActive
+          ? activateMetadataField(metadataField)
+          : disableMetadataField(metadataField);
+      }),
+    );
+
+    navigate(`/settings/objects/${objectSlug}`);
+  };
 
   return (
     <SubMenuTopBarContainer Icon={IconSettings} title="Settings">
@@ -70,9 +110,9 @@ export const SettingsObjectNewFieldStep1 = () => {
             ]}
           />
           <SaveAndCancelButtons
-            isSaveDisabled
+            isSaveDisabled={!canSave}
             onCancel={() => navigate(`/settings/objects/${objectSlug}`)}
-            onSave={() => undefined}
+            onSave={handleSave}
           />
         </SettingsHeaderContainer>
         <StyledSection>
@@ -89,12 +129,16 @@ export const SettingsObjectNewFieldStep1 = () => {
             </StyledObjectFieldTableRow>
             {!!activeMetadataFields.length && (
               <TableSection isInitiallyExpanded={false} title="Active">
-                {activeMetadataFields.map((activeMetadataField) => (
+                {activeMetadataFields.map((field) => (
                   <SettingsObjectFieldItemTableRow
-                    key={activeMetadataField.id}
-                    fieldItem={activeMetadataField}
+                    key={field.id}
+                    fieldItem={field}
                     ActionIcon={
-                      <LightIconButton Icon={IconMinus} accent="tertiary" />
+                      <LightIconButton
+                        Icon={IconMinus}
+                        accent="tertiary"
+                        onClick={() => handleToggleField(field.id)}
+                      />
                     }
                   />
                 ))}
@@ -102,12 +146,16 @@ export const SettingsObjectNewFieldStep1 = () => {
             )}
             {!!disabledMetadataFields.length && (
               <TableSection title="Disabled">
-                {disabledMetadataFields.map((disabledMetadataField) => (
+                {disabledMetadataFields.map((field) => (
                   <SettingsObjectFieldItemTableRow
-                    key={disabledMetadataField.name}
-                    fieldItem={disabledMetadataField}
+                    key={field.name}
+                    fieldItem={field}
                     ActionIcon={
-                      <LightIconButton Icon={IconPlus} accent="tertiary" />
+                      <LightIconButton
+                        Icon={IconPlus}
+                        accent="tertiary"
+                        onClick={() => handleToggleField(field.id)}
+                      />
                     }
                   />
                 ))}