Use return await to catch exceptions (#6109)

So the exceptions are handled properly and filtered in sentry
This commit is contained in:
Thomas Trompette
2024-07-03 11:14:28 +02:00
committed by GitHub
parent 5b26452649
commit 4183e5460d
5 changed files with 38 additions and 20 deletions

View File

@ -31,12 +31,12 @@ export class FieldMetadataResolver {
constructor(private readonly fieldMetadataService: FieldMetadataService) {} constructor(private readonly fieldMetadataService: FieldMetadataService) {}
@Mutation(() => FieldMetadataDTO) @Mutation(() => FieldMetadataDTO)
createOneField( async createOneField(
@Args('input') input: CreateOneFieldMetadataInput, @Args('input') input: CreateOneFieldMetadataInput,
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.fieldMetadataService.createOne({ return await this.fieldMetadataService.createOne({
...input.field, ...input.field,
workspaceId, workspaceId,
}); });
@ -46,12 +46,12 @@ export class FieldMetadataResolver {
} }
@Mutation(() => FieldMetadataDTO) @Mutation(() => FieldMetadataDTO)
updateOneField( async updateOneField(
@Args('input') input: UpdateOneFieldMetadataInput, @Args('input') input: UpdateOneFieldMetadataInput,
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.fieldMetadataService.updateOne(input.id, { return await this.fieldMetadataService.updateOne(input.id, {
...input.update, ...input.update,
workspaceId, workspaceId,
}); });
@ -95,7 +95,7 @@ export class FieldMetadataResolver {
} }
try { try {
return this.fieldMetadataService.deleteOneField(input, workspaceId); return await this.fieldMetadataService.deleteOneField(input, workspaceId);
} catch (error) { } catch (error) {
fieldMetadataGraphqlApiExceptionHandler(error); fieldMetadataGraphqlApiExceptionHandler(error);
} }
@ -114,7 +114,7 @@ export class FieldMetadataResolver {
const relationMetadataItem = const relationMetadataItem =
await context.loaders.relationMetadataLoader.load(fieldMetadata.id); await context.loaders.relationMetadataLoader.load(fieldMetadata.id);
return this.fieldMetadataService.getRelationDefinitionFromRelationMetadata( return await this.fieldMetadataService.getRelationDefinitionFromRelationMetadata(
fieldMetadata, fieldMetadata,
relationMetadataItem, relationMetadataItem,
); );

View File

@ -23,12 +23,15 @@ export class ObjectMetadataResolver {
) {} ) {}
@Mutation(() => ObjectMetadataDTO) @Mutation(() => ObjectMetadataDTO)
deleteOneObject( async deleteOneObject(
@Args('input') input: DeleteOneObjectInput, @Args('input') input: DeleteOneObjectInput,
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.objectMetadataService.deleteOneObject(input, workspaceId); return await this.objectMetadataService.deleteOneObject(
input,
workspaceId,
);
} catch (error) { } catch (error) {
objectMetadataGraphqlApiExceptionHandler(error); objectMetadataGraphqlApiExceptionHandler(error);
} }
@ -42,7 +45,10 @@ export class ObjectMetadataResolver {
try { try {
await this.beforeUpdateOneObject.run(input, workspaceId); await this.beforeUpdateOneObject.run(input, workspaceId);
return this.objectMetadataService.updateOneObject(input, workspaceId); return await this.objectMetadataService.updateOneObject(
input,
workspaceId,
);
} catch (error) { } catch (error) {
objectMetadataGraphqlApiExceptionHandler(error); objectMetadataGraphqlApiExceptionHandler(error);
} }

View File

@ -17,12 +17,12 @@ export class RelationMetadataResolver {
) {} ) {}
@Mutation(() => RelationMetadataDTO) @Mutation(() => RelationMetadataDTO)
deleteOneRelation( async deleteOneRelation(
@Args('input') input: DeleteOneRelationInput, @Args('input') input: DeleteOneRelationInput,
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.relationMetadataService.deleteOneRelation( return await this.relationMetadataService.deleteOneRelation(
input.id, input.id,
workspaceId, workspaceId,
); );

View File

@ -26,7 +26,10 @@ export class RemoteServerResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteServerService.createOneRemoteServer(input, workspaceId); return await this.remoteServerService.createOneRemoteServer(
input,
workspaceId,
);
} catch (error) { } catch (error) {
remoteServerGraphqlApiExceptionHandler(error); remoteServerGraphqlApiExceptionHandler(error);
} }
@ -38,7 +41,10 @@ export class RemoteServerResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteServerService.updateOneRemoteServer(input, workspaceId); return await this.remoteServerService.updateOneRemoteServer(
input,
workspaceId,
);
} catch (error) { } catch (error) {
remoteServerGraphqlApiExceptionHandler(error); remoteServerGraphqlApiExceptionHandler(error);
} }
@ -50,7 +56,10 @@ export class RemoteServerResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteServerService.deleteOneRemoteServer(id, workspaceId); return await this.remoteServerService.deleteOneRemoteServer(
id,
workspaceId,
);
} catch (error) { } catch (error) {
remoteServerGraphqlApiExceptionHandler(error); remoteServerGraphqlApiExceptionHandler(error);
} }
@ -62,7 +71,7 @@ export class RemoteServerResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteServerService.findOneByIdWithinWorkspace( return await this.remoteServerService.findOneByIdWithinWorkspace(
id, id,
workspaceId, workspaceId,
); );
@ -78,7 +87,7 @@ export class RemoteServerResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteServerService.findManyByTypeWithinWorkspace( return await this.remoteServerService.findManyByTypeWithinWorkspace(
foreignDataWrapperType, foreignDataWrapperType,
workspaceId, workspaceId,
); );

View File

@ -21,7 +21,7 @@ export class RemoteTableResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteTableService.findDistantTablesWithStatus( return await this.remoteTableService.findDistantTablesWithStatus(
input.id, input.id,
workspaceId, workspaceId,
input.shouldFetchPendingSchemaUpdates, input.shouldFetchPendingSchemaUpdates,
@ -37,7 +37,7 @@ export class RemoteTableResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteTableService.syncRemoteTable(input, workspaceId); return await this.remoteTableService.syncRemoteTable(input, workspaceId);
} catch (error) { } catch (error) {
remoteTableGraphqlApiExceptionHandler(error); remoteTableGraphqlApiExceptionHandler(error);
} }
@ -49,7 +49,10 @@ export class RemoteTableResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteTableService.unsyncRemoteTable(input, workspaceId); return await this.remoteTableService.unsyncRemoteTable(
input,
workspaceId,
);
} catch (error) { } catch (error) {
remoteTableGraphqlApiExceptionHandler(error); remoteTableGraphqlApiExceptionHandler(error);
} }
@ -61,7 +64,7 @@ export class RemoteTableResolver {
@AuthWorkspace() { id: workspaceId }: Workspace, @AuthWorkspace() { id: workspaceId }: Workspace,
) { ) {
try { try {
return this.remoteTableService.syncRemoteTableSchemaChanges( return await this.remoteTableService.syncRemoteTableSchemaChanges(
input, input,
workspaceId, workspaceId,
); );