[QRQC_2] No implicitAny in twenty-server (#12075)
# Introduction Following https://github.com/twentyhq/twenty/pull/12068 Related with https://github.com/twentyhq/core-team-issues/issues/975 We're enabling `noImplicitAny` handled few use case manually, added a `ts-expect-error` to the others, we should plan to handle them in the future
This commit is contained in:
@ -9,6 +9,7 @@ const companyMockObjectMetadataItem = mockObjectMetadataItemsWithFieldMaps.find(
|
||||
)!;
|
||||
|
||||
describe('generateFakeFormResponse', () => {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
let objectMetadataRepository;
|
||||
|
||||
beforeEach(() => {
|
||||
@ -52,6 +53,7 @@ describe('generateFakeFormResponse', () => {
|
||||
const result = await generateFakeFormResponse({
|
||||
formMetadata: schema,
|
||||
workspaceId: '1',
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
objectMetadataRepository,
|
||||
});
|
||||
|
||||
|
||||
@ -33,6 +33,7 @@ export const generateFakeField = ({
|
||||
icon: icon,
|
||||
label: label,
|
||||
value: compositeType.properties.reduce((acc, property) => {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
acc[property.name] = {
|
||||
isLeaf: true,
|
||||
type: property.type,
|
||||
|
||||
@ -572,7 +572,9 @@ export class WorkflowVersionStepWorkspaceService {
|
||||
|
||||
const enrichedResponses = await Promise.all(
|
||||
responseKeys.map(async (key) => {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
if (!isDefined(response[key])) {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
return { key, value: response[key] };
|
||||
}
|
||||
|
||||
@ -581,7 +583,9 @@ export class WorkflowVersionStepWorkspaceService {
|
||||
if (
|
||||
field?.type === 'RECORD' &&
|
||||
field?.settings?.objectName &&
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
isDefined(response[key].id) &&
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
isValidUuid(response[key].id)
|
||||
) {
|
||||
const repository = await this.twentyORMManager.getRepository(
|
||||
@ -589,17 +593,20 @@ export class WorkflowVersionStepWorkspaceService {
|
||||
);
|
||||
|
||||
const record = await repository.findOne({
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
where: { id: response[key].id },
|
||||
});
|
||||
|
||||
return { key, value: record };
|
||||
} else {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
return { key, value: response[key] };
|
||||
}
|
||||
}),
|
||||
);
|
||||
|
||||
return enrichedResponses.reduce((acc, { key, value }) => {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
acc[key] = value;
|
||||
|
||||
return acc;
|
||||
|
||||
@ -49,6 +49,7 @@ const resolveObject = (
|
||||
const entries = Object.entries(resolvedObject);
|
||||
|
||||
for (const [key, value] of entries) {
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
resolvedObject[key] = resolveInput(value, context);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user