admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed date picker UI that was too overloaded (#5039)

Browse Source 
Date picker UI was off because of the recent refactor with new field
types Date and DateTime. We had to allow the date picker to edit both.

In this PR we come back to the previous design and we only use the input
to modify time.

Also we use our Select component instead of the ones from the library
`react-datepicker`

---------

Co-authored-by: Weiko <corentin@twenty.com>
This commit is contained in:
Lucas Bordeau
2024-04-23 18:45:32 +02:00
committed by GitHub
parent 2dc89b8f1d
commit 444e97fa3e
7 changed files with 66 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/__stories__/DateTimeFieldInput.stories.tsx
View File

@ -126,9 +126,9 @@ type Story = StoryObj<typeof DateFieldInputWithContext>;
export const Default: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const div = await canvas.findByText('February - 2022');
const div = await canvas.findByText('February');
await expect(div.innerText).toContain('February - 2022');
await expect(div.innerText).toContain('February');
},
};
@ -138,7 +138,7 @@ export const ClickOutside: Story = {
await expect(clickOutsideJestFn).toHaveBeenCalledTimes(0);
await canvas.findByText('February - 2022');
await canvas.findByText('February');
const emptyDiv = canvas.getByTestId('data-field-input-click-outside-div');
await userEvent.click(emptyDiv);
@ -151,7 +151,7 @@ export const Escape: Story = {
await expect(escapeJestFn).toHaveBeenCalledTimes(0);
const canvas = within(canvasElement);
await canvas.findByText('February - 2022');
await canvas.findByText('February');
await userEvent.keyboard('{escape}');
await expect(escapeJestFn).toHaveBeenCalledTimes(1);
@ -163,7 +163,7 @@ export const Enter: Story = {
await expect(enterJestFn).toHaveBeenCalledTimes(0);
const canvas = within(canvasElement);
await canvas.findByText('February - 2022');
await canvas.findByText('February');
await userEvent.keyboard('{enter}');
await expect(enterJestFn).toHaveBeenCalledTimes(1);