[REFACTOR] Twenty UI multi barrel (#11301)
# Introduction closes https://github.com/twentyhq/core-team-issues/issues/591 Same than for `twenty-shared` made in https://github.com/twentyhq/twenty/pull/11083. ## TODO - [x] Manual migrate twenty-website twenty-ui imports ## What's next: - Generate barrel and migration script factorization within own package + tests - Refactoring using preconstruct ? TimeBox - Lint circular dependencies - Lint import from barrel and forbid them ### Preconstruct We need custom rollup plugins addition, but preconstruct does not expose its rollup configuration. It might be possible to handle this using the babel overrides. But was a big tunnel. We could give it a try afterwards ! ( allowing cjs interop and stuff like that ) Stuck to vite lib app Closed related PRs: - https://github.com/twentyhq/twenty/pull/11294 - https://github.com/twentyhq/twenty/pull/11203
This commit is contained in:
@ -1,5 +1,5 @@
|
||||
import { LinkType } from 'twenty-ui';
|
||||
import { getDisplayValueByUrlType } from '~/utils/getDisplayValueByUrlType';
|
||||
import { LinkType } from 'twenty-ui/navigation';
|
||||
|
||||
describe('getDisplayValueByUrlType', () => {
|
||||
it('should return the linkedin username from the url', () => {
|
||||
|
||||
@ -1,5 +1,4 @@
|
||||
import { LinkType } from 'twenty-ui';
|
||||
|
||||
import { LinkType } from 'twenty-ui/navigation';
|
||||
export const checkUrlType = (url: string) => {
|
||||
if (/^(https?:\/\/)?(www\.)?linkedin\.com\/.+$/.test(url)) {
|
||||
return LinkType.LinkedIn;
|
||||
|
||||
@ -1,5 +1,5 @@
|
||||
import { Nullable } from 'twenty-ui';
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { Nullable } from 'twenty-ui/utilities';
|
||||
|
||||
// TODO: we should create a custom eslint rule that enforces the use of this function
|
||||
// instead of using the `===` operator where a and b are | undefined | null
|
||||
|
||||
@ -1,5 +1,5 @@
|
||||
import { LinkType } from 'twenty-ui';
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { LinkType } from 'twenty-ui/navigation';
|
||||
|
||||
type getUrlDisplayValueByUrlTypeProps = {
|
||||
type: LinkType;
|
||||
|
||||
Reference in New Issue
Block a user