From 4c2c9e427320d30fe6cefac233d8ce26d74f4452 Mon Sep 17 00:00:00 2001 From: madanlal mohanrao nikalje Date: Wed, 16 Apr 2025 11:33:47 +0530 Subject: [PATCH] Refactor webhook event name generation in OpenApiService (#11592) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes - #11589 POT - ![Screenshot 2025-04-16 at 12 39 11 AM](https://github.com/user-attachments/assets/43802e1a-1ece-4b44-831f-35d70285c5fb) --- .../core-modules/open-api/open-api.service.ts | 37 +++++++++++++------ 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.ts b/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.ts index 5e92412fc..dd7a3f57f 100644 --- a/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.ts +++ b/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.ts @@ -82,18 +82,24 @@ export class OpenApiService { schema.webhooks = objectMetadataItems.reduce( (paths, item) => { - paths[`Create ${item.nameSingular}`] = computeWebhooks( - DatabaseEventAction.CREATED, - item, - ); - paths[`Update ${item.nameSingular}`] = computeWebhooks( - DatabaseEventAction.UPDATED, - item, - ); - paths[`Delete ${item.nameSingular}`] = computeWebhooks( - DatabaseEventAction.DELETED, - item, - ); + paths[ + this.createWebhookEventName( + DatabaseEventAction.CREATED, + item.nameSingular, + ) + ] = computeWebhooks(DatabaseEventAction.CREATED, item); + paths[ + this.createWebhookEventName( + DatabaseEventAction.UPDATED, + item.nameSingular, + ) + ] = computeWebhooks(DatabaseEventAction.UPDATED, item); + paths[ + this.createWebhookEventName( + DatabaseEventAction.DELETED, + item.nameSingular, + ) + ] = computeWebhooks(DatabaseEventAction.DELETED, item); return paths; }, @@ -226,4 +232,11 @@ export class OpenApiService { return schema; } + + createWebhookEventName( + action: DatabaseEventAction, + objectName: string, + ): string { + return `${capitalize(objectName)} ${capitalize(action)}`; + } }