From 4c413d480265f3ca3226bd3753223323a5476be1 Mon Sep 17 00:00:00 2001
From: Marie <51697796+ijreilly@users.noreply.github.com>
Date: Tue, 26 Nov 2024 11:01:12 +0100
Subject: [PATCH] Fix custom object renaming (#8746)

Currently when renaming an object, we execute
```
await this.fieldMetadataRepository
                    .findOneByOrFail({
                      name: existingObjectMetadata.nameSingular,
                      label: existingObjectMetadata.labelSingular,
                      objectMetadataId: relatedObject.id,
                      workspaceId: workspaceId,
                    })
```
to find the standard relation fields.
This would throw an error if the label solely was update beforehand
without updating the name too: in that case we will not have migrated
the label of the standard relation fields (which is maybe a mistake?
@Weiko wdyt?).
Let's remove it.
---
 .../services/object-metadata-migration.service.ts              | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service.ts
index a6a9ee24f..9f8931109 100644
--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service.ts
@@ -165,12 +165,11 @@ export class ObjectMetadataMigrationService {
                 });
 
               if (relatedObject) {
-                // 1. Update to and from relation fieldMetadata)
+                // 1. Update to and from relation fieldMetadata
                 const toFieldRelationFieldMetadataId =
                   await this.fieldMetadataRepository
                     .findOneByOrFail({
                       name: existingObjectMetadata.nameSingular,
-                      label: existingObjectMetadata.labelSingular,
                       objectMetadataId: relatedObject.id,
                       workspaceId: workspaceId,
                     })