admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Update recoil v4 states to getters (#3451)

Browse Source 
Update v4 states to getters

Co-authored-by: Thomas Trompette <thomast@twenty.com>
This commit is contained in:
Thomas Trompette
2024-01-15 18:18:55 +01:00
committed by GitHub
parent 4695e99458
commit 4e36c6d584
26 changed files with 169 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageRightContainer.tsx
View File

@ -57,8 +57,8 @@ export const ShowPageRightContainer = ({
}: ShowPageRightContainerProps) => {
const isMessagingEnabled = useIsFeatureEnabled('IS_MESSAGING_ENABLED');
const { activeTabIdState } = useTabList(TAB_LIST_COMPONENT_ID);
const activeTabId = useRecoilValue(activeTabIdState());
const { getActiveTabIdState } = useTabList(TAB_LIST_COMPONENT_ID);
const activeTabId = useRecoilValue(getActiveTabIdState());
const { objectMetadataItem: targetableObjectMetadataItem } =
useObjectMetadataItem({

4
packages/twenty-front/src/modules/ui/layout/tab/components/TabList.tsx
View File

@ -34,9 +34,9 @@ const StyledContainer = styled.div`
export const TabList = ({ tabs, tabListId }: TabListProps) => {
const initialActiveTabId = tabs[0].id;
const { activeTabIdState, setActiveTabId } = useTabList(tabListId);
const { getActiveTabIdState, setActiveTabId } = useTabList(tabListId);
const activeTabId = useRecoilValue(activeTabIdState());
const activeTabId = useRecoilValue(getActiveTabIdState());
React.useEffect(() => {
setActiveTabId(initialActiveTabId);

2
packages/twenty-front/src/modules/ui/layout/tab/hooks/internal/useTabListStates.ts
View File

@ -15,6 +15,6 @@ export const useTabListStates = ({ tabListScopeId }: useTabListStatesProps) => {
return {
scopeId,
activeTabIdState: getState(activeTabIdStateScopeMap, scopeId),
getActiveTabIdState: getState(activeTabIdStateScopeMap, scopeId),
};
};

6
packages/twenty-front/src/modules/ui/layout/tab/hooks/useTabList.ts
View File

@ -3,14 +3,14 @@ import { useSetRecoilState } from 'recoil';
import { useTabListStates } from '@/ui/layout/tab/hooks/internal/useTabListStates';
export const useTabList = (tabListId?: string) => {
const { activeTabIdState } = useTabListStates({
const { getActiveTabIdState } = useTabListStates({
tabListScopeId: `${tabListId}-scope`,
});
const setActiveTabId = useSetRecoilState(activeTabIdState());
const setActiveTabId = useSetRecoilState(getActiveTabIdState());
return {
activeTabIdState,
getActiveTabIdState,
setActiveTabId,
};
};