admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix lint and used constant (#6082)

Browse Source 
- Fixed lint after merge of #6077 
- Used constant for dropdown id
This commit is contained in:
Lucas Bordeau
2024-07-01 15:04:59 +02:00
committed by GitHub
parent b371c77284
commit 504e7b7d94
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownRecordSelect.tsx
View File

@ -15,7 +15,7 @@ export const MAX_RECORDS_TO_DISPLAY = 3;
type ObjectFilterDropdownRecordSelectProps = { type ObjectFilterDropdownRecordSelectProps = {
viewComponentId?: string; viewComponentId?: string;
} };
export const ObjectFilterDropdownRecordSelect = ({ export const ObjectFilterDropdownRecordSelect = ({
viewComponentId, viewComponentId,
}: ObjectFilterDropdownRecordSelectProps) => { }: ObjectFilterDropdownRecordSelectProps) => {
@ -31,7 +31,8 @@ export const ObjectFilterDropdownRecordSelect = ({
} = useFilterDropdown(); } = useFilterDropdown();
const { removeCombinedViewFilter } = useCombinedViewFilters(viewComponentId); const { removeCombinedViewFilter } = useCombinedViewFilters(viewComponentId);
const { currentViewWithCombinedFiltersAndSorts } = useGetCurrentView(viewComponentId); const { currentViewWithCombinedFiltersAndSorts } =
useGetCurrentView(viewComponentId);
const filterDefinitionUsedInDropdown = useRecoilValue( const filterDefinitionUsedInDropdown = useRecoilValue(
filterDefinitionUsedInDropdownState, filterDefinitionUsedInDropdownState,

8
packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/SingleEntityObjectFilterDropdownButton.tsx
View File

@ -17,6 +17,8 @@ import { GenericEntityFilterChip } from './GenericEntityFilterChip';
import { ObjectFilterDropdownRecordSelect } from './ObjectFilterDropdownRecordSelect'; import { ObjectFilterDropdownRecordSelect } from './ObjectFilterDropdownRecordSelect';
import { ObjectFilterDropdownSearchInput } from './ObjectFilterDropdownSearchInput'; import { ObjectFilterDropdownSearchInput } from './ObjectFilterDropdownSearchInput';
const SINGLE_ENTITY_FILTER_DROPDOWN_ID = 'single-entity-filter-dropdown';
export const SingleEntityObjectFilterDropdownButton = ({ export const SingleEntityObjectFilterDropdownButton = ({
hotkeyScope, hotkeyScope,
}: { }: {
@ -50,7 +52,7 @@ export const SingleEntityObjectFilterDropdownButton = ({
return ( return (
<Dropdown <Dropdown
dropdownId="single-entity-filter-dropdown" dropdownId={SINGLE_ENTITY_FILTER_DROPDOWN_ID}
dropdownHotkeyScope={hotkeyScope} dropdownHotkeyScope={hotkeyScope}
dropdownOffset={{ x: 0, y: -28 }} dropdownOffset={{ x: 0, y: -28 }}
clickableComponent={ clickableComponent={
@ -75,7 +77,9 @@ export const SingleEntityObjectFilterDropdownButton = ({
<ObjectFilterDropdownSearchInput /> <ObjectFilterDropdownSearchInput />
<DropdownMenuSeparator /> <DropdownMenuSeparator />
<ObjectFilterDropdownRecordRemoveFilterMenuItem /> <ObjectFilterDropdownRecordRemoveFilterMenuItem />
<ObjectFilterDropdownRecordSelect viewComponentId={"single-entity-filter-dropdown"}/> <ObjectFilterDropdownRecordSelect
viewComponentId={SINGLE_ENTITY_FILTER_DROPDOWN_ID}
/>
</> </>
} }
/> />