fix: Dropdown Overlapping Sidebar on Column Header Click in Horizontal Table When Scrolling (#8287)

fixes : #8272

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
This commit is contained in:
Vardhaman Bhandari
2024-11-18 19:49:04 +05:30
committed by GitHub
parent 8b8b9fe55b
commit 5115022355
5 changed files with 64 additions and 12 deletions

View File

@ -126,7 +126,6 @@ export const Dropdown = ({
listenerId: dropdownId,
callback: () => {
onClickOutside?.();
if (isDropdownOpen) {
closeDropdown();
}
@ -141,10 +140,12 @@ export const Dropdown = ({
useScopedHotkeys(
[Key.Escape],
() => {
closeDropdown();
if (isDropdownOpen) {
closeDropdown();
}
},
dropdownHotkeyScope.scope,
[closeDropdown],
[closeDropdown, isDropdownOpen],
);
return (

View File

@ -45,7 +45,6 @@ export const ScrollWrapper = ({
useScrollStates(contextProviderName);
const setScrollTop = useSetRecoilState(scrollTopComponentState);
const setScrollLeft = useSetRecoilState(scrollLeftComponentState);
const handleScroll = (overlayScroll: OverlayScrollbars) => {
const target = overlayScroll.elements().scrollOffsetElement;
setScrollTop(target.scrollTop);
@ -78,7 +77,12 @@ export const ScrollWrapper = ({
}, [instance, setOverlayScrollbars]);
return (
<Context.Provider value={{ ref: scrollableRef, id: contextProviderName }}>
<Context.Provider
value={{
ref: scrollableRef,
id: contextProviderName,
}}
>
<StyledScrollWrapper ref={scrollableRef} className={className}>
{children}
</StyledScrollWrapper>