Optimize metadata queries (#7013)

In this PR:

1. Refactor guards to avoid duplicated queries: WorkspaceAuthGuard and
UserAuthGuard only check for existence of workspace and user in the
request without querying the database

packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemAsFieldDefinition.ts

@@ -1,5 +1,4 @@
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
-import { parseFieldRelationType } from '@/object-metadata/utils/parseFieldRelationType';
 import { FieldDefinition } from '@/object-record/record-field/types/FieldDefinition';
 import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
 import { getFieldButtonIcon } from '@/object-record/record-field/utils/getFieldButtonIcon';
@@ -20,17 +19,15 @@ export const formatFieldMetadataItemAsFieldDefinition = ({
   labelWidth,
 }: FieldMetadataItemAsFieldDefinitionProps): FieldDefinition<FieldMetadata> => {
   const relationObjectMetadataItem =
-    field.toRelationMetadata?.fromObjectMetadata ||
-    field.fromRelationMetadata?.toObjectMetadata;
+    field.relationDefinition?.targetObjectMetadata;
 
   const relationFieldMetadataId =
-    field.toRelationMetadata?.fromFieldMetadataId ||
-    field.fromRelationMetadata?.toFieldMetadataId;
+    field.relationDefinition?.targetFieldMetadata.id;
 
   const fieldDefintionMetadata = {
     fieldName: field.name,
     placeHolder: field.label,
-    relationType: parseFieldRelationType(field),
+    relationType: field.relationDefinition?.direction,
     relationFieldMetadataId,
     relationObjectMetadataNameSingular:
       relationObjectMetadataItem?.nameSingular ?? '',

packages/twenty-front/src/modules/object-metadata/utils/formatRelationMetadataInput.ts

@@ -2,6 +2,7 @@ import { RelationType } from '@/settings/data-model/types/RelationType';
 import {
   CreateRelationInput,
   Field,
+  RelationDefinitionType,
   RelationMetadataType,
 } from '~/generated-metadata/graphql';
 
@@ -24,8 +25,8 @@ export const formatRelationMetadataInput = (
   // => Transform into ONE_TO_MANY and invert "from" and "to" data.
   const isManyToOne = input.relationType === 'MANY_TO_ONE';
   const relationType = isManyToOne
-    ? RelationMetadataType.OneToMany
-    : (input.relationType as RelationMetadataType);
+    ? RelationDefinitionType.OneToMany
+    : (input.relationType as RelationDefinitionType);
   const { field: fromField, objectMetadataId: fromObjectMetadataId } =
     isManyToOne ? input.connect : input;
   const { field: toField, objectMetadataId: toObjectMetadataId } = isManyToOne
@@ -51,7 +52,7 @@ export const formatRelationMetadataInput = (
     fromLabel,
     fromName,
     fromObjectMetadataId,
-    relationType,
+    relationType: relationType as unknown as RelationMetadataType,
     toDescription,
     toIcon,
     toLabel,

packages/twenty-front/src/modules/object-metadata/utils/mapFieldMetadataToGraphQLQuery.ts

@@ -4,7 +4,7 @@ import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { mapObjectMetadataToGraphQLQuery } from '@/object-metadata/utils/mapObjectMetadataToGraphQLQuery';
 import {
   FieldMetadataType,
-  RelationMetadataType,
+  RelationDefinitionType,
 } from '~/generated-metadata/graphql';
 
 import { FieldMetadataItem } from '../types/FieldMetadataItem';
@@ -17,10 +17,7 @@ export const mapFieldMetadataToGraphQLQuery = ({
   computeReferences = false,
 }: {
   objectMetadataItems: ObjectMetadataItem[];
-  field: Pick<
-    FieldMetadataItem,
-    'name' | 'type' | 'toRelationMetadata' | 'fromRelationMetadata'
-  >;
+  field: Pick<FieldMetadataItem, 'name' | 'type' | 'relationDefinition'>;
   relationrecordFields?: Record<string, any>;
   computeReferences?: boolean;
 }): any => {
@@ -49,12 +46,12 @@ export const mapFieldMetadataToGraphQLQuery = ({
 
   if (
     fieldType === FieldMetadataType.Relation &&
-    field.toRelationMetadata?.relationType === RelationMetadataType.OneToMany
+    field.relationDefinition?.direction === RelationDefinitionType.ManyToOne
   ) {
     const relationMetadataItem = objectMetadataItems.find(
       (objectMetadataItem) =>
         objectMetadataItem.id ===
-        (field.toRelationMetadata as any)?.fromObjectMetadata?.id,
+        field.relationDefinition?.targetObjectMetadata.id,
     );
 
     if (isUndefined(relationMetadataItem)) {
@@ -73,12 +70,12 @@ ${mapObjectMetadataToGraphQLQuery({
 
   if (
     fieldType === FieldMetadataType.Relation &&
-    field.fromRelationMetadata?.relationType === RelationMetadataType.OneToMany
+    field.relationDefinition?.direction === RelationDefinitionType.OneToMany
   ) {
     const relationMetadataItem = objectMetadataItems.find(
       (objectMetadataItem) =>
         objectMetadataItem.id ===
-        (field.fromRelationMetadata as any)?.toObjectMetadata?.id,
+        field.relationDefinition?.targetObjectMetadata.id,
     );
 
     if (isUndefined(relationMetadataItem)) {

packages/twenty-front/src/modules/object-metadata/utils/parseFieldRelationType.ts

@@ -1,55 +0,0 @@
-import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
-import { FieldDefinitionRelationType } from '@/object-record/record-field/types/FieldDefinition';
-import {
-  FieldMetadataType,
-  RelationMetadataType,
-} from '~/generated-metadata/graphql';
-import { isDefined } from '~/utils/isDefined';
-
-export const parseFieldRelationType = (
-  field: FieldMetadataItem | undefined,
-): FieldDefinitionRelationType | undefined => {
-  if (!field || field.type !== FieldMetadataType.Relation) return;
-
-  const config: Record<
-    RelationMetadataType,
-    { from: FieldDefinitionRelationType; to: FieldDefinitionRelationType }
-  > = {
-    [RelationMetadataType.ManyToMany]: {
-      from: 'FROM_MANY_OBJECTS',
-      to: 'TO_MANY_OBJECTS',
-    },
-    [RelationMetadataType.OneToMany]: {
-      from: 'FROM_MANY_OBJECTS',
-      to: 'TO_ONE_OBJECT',
-    },
-    [RelationMetadataType.ManyToOne]: {
-      from: 'TO_ONE_OBJECT',
-      to: 'FROM_MANY_OBJECTS',
-    },
-    [RelationMetadataType.OneToOne]: {
-      from: 'FROM_ONE_OBJECT',
-      to: 'TO_ONE_OBJECT',
-    },
-  };
-
-  if (
-    isDefined(field.fromRelationMetadata) &&
-    field.fromRelationMetadata.relationType in config
-  ) {
-    return config[field.fromRelationMetadata.relationType].from;
-  }
-
-  if (
-    isDefined(field.toRelationMetadata) &&
-    field.toRelationMetadata.relationType in config
-  ) {
-    return config[field.toRelationMetadata.relationType].to;
-  }
-
-  throw new Error(
-    `Cannot determine field relation type for field : ${JSON.stringify(
-      field,
-    )}.`,
-  );
-};