Optimize metadata queries (#7013)

In this PR:

1. Refactor guards to avoid duplicated queries: WorkspaceAuthGuard and
UserAuthGuard only check for existence of workspace and user in the
request without querying the database

packages/twenty-front/src/modules/object-record/utils/filterAvailableTableColumns.ts

@@ -2,14 +2,14 @@ import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata'
 import { isFieldRelation } from '@/object-record/record-field/types/guards/isFieldRelation';
 import { ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
 import { TABLE_COLUMNS_DENY_LIST } from '@/object-record/relation-picker/constants/TableColumnsDenyList';
+import { RelationDefinitionType } from '~/generated-metadata/graphql';
 
 export const filterAvailableTableColumns = (
   columnDefinition: ColumnDefinition<FieldMetadata>,
 ): boolean => {
   if (
     isFieldRelation(columnDefinition) &&
-    columnDefinition.metadata?.relationType !== 'TO_ONE_OBJECT' &&
-    columnDefinition.metadata?.relationType !== 'FROM_MANY_OBJECTS'
+    columnDefinition.metadata?.relationType !== RelationDefinitionType.ManyToOne
   ) {
     return false;
   }

packages/twenty-front/src/modules/object-record/utils/generateDefaultFieldValue.ts

@@ -4,10 +4,7 @@ import { generateEmptyFieldValue } from '@/object-record/utils/generateEmptyFiel
 import { v4 } from 'uuid';
 
 export const generateDefaultFieldValue = (
-  fieldMetadataItem: Pick<
-    FieldMetadataItem,
-    'defaultValue' | 'type' | 'fromRelationMetadata'
-  >,
+  fieldMetadataItem: Pick<FieldMetadataItem, 'defaultValue' | 'type'>,
 ) => {
   const defaultValue = isFieldValueEmpty({
     fieldValue: fieldMetadataItem.defaultValue,

packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts

@@ -1,10 +1,11 @@
-import { isNonEmptyString } from '@sniptt/guards';
-
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
-import { FieldMetadataType } from '~/generated-metadata/graphql';
+import {
+  FieldMetadataType,
+  RelationDefinitionType,
+} from '~/generated-metadata/graphql';
 
 export const generateEmptyFieldValue = (
-  fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'fromRelationMetadata'>,
+  fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'relationDefinition'>,
 ) => {
   switch (fieldMetadataItem.type) {
     case FieldMetadataType.Email:
@@ -62,10 +63,8 @@ export const generateEmptyFieldValue = (
     }
     case FieldMetadataType.Relation: {
       if (
-        !isNonEmptyString(
-          fieldMetadataItem.fromRelationMetadata?.toObjectMetadata
-            ?.nameSingular,
-        )
+        fieldMetadataItem.relationDefinition?.direction ===
+        RelationDefinitionType.ManyToOne
       ) {
         return null;
       }

packages/twenty-front/src/modules/object-record/utils/isFieldCellSupported.ts

@@ -1,12 +1,16 @@
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
+import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { isObjectMetadataAvailableForRelation } from '@/object-metadata/utils/isObjectMetadataAvailableForRelation';
 import {
   FieldMetadataType,
-  RelationMetadataType,
+  RelationDefinitionType,
 } from '~/generated-metadata/graphql';
 
-export const isFieldCellSupported = (fieldMetadataItem: FieldMetadataItem) => {
+export const isFieldCellSupported = (
+  fieldMetadataItem: FieldMetadataItem,
+  objectMetadataItems: ObjectMetadataItem[],
+) => {
   if (
     [
       FieldMetadataType.Uuid,
@@ -18,17 +22,17 @@ export const isFieldCellSupported = (fieldMetadataItem: FieldMetadataItem) => {
   }
 
   if (fieldMetadataItem.type === FieldMetadataType.Relation) {
-    const relationMetadata =
-      fieldMetadataItem.fromRelationMetadata ??
-      fieldMetadataItem.toRelationMetadata;
-    const relationObjectMetadataItem =
-      fieldMetadataItem.fromRelationMetadata?.toObjectMetadata ??
-      fieldMetadataItem.toRelationMetadata?.fromObjectMetadata;
+    const relationObjectMetadataItemId =
+      fieldMetadataItem.relationDefinition?.targetObjectMetadata.id;
+
+    const relationObjectMetadataItem = objectMetadataItems.find(
+      (item) => item.id === relationObjectMetadataItemId,
+    );
 
     // Hack to display targets on Notes and Tasks
     if (
-      fieldMetadataItem.fromRelationMetadata?.toObjectMetadata?.nameSingular ===
-        CoreObjectNameSingular.NoteTarget &&
+      fieldMetadataItem.relationDefinition?.targetObjectMetadata
+        ?.nameSingular === CoreObjectNameSingular.NoteTarget &&
       fieldMetadataItem.relationDefinition?.sourceObjectMetadata
         .nameSingular === CoreObjectNameSingular.Note
     ) {
@@ -36,8 +40,8 @@ export const isFieldCellSupported = (fieldMetadataItem: FieldMetadataItem) => {
     }
 
     if (
-      fieldMetadataItem.fromRelationMetadata?.toObjectMetadata?.nameSingular ===
-        CoreObjectNameSingular.TaskTarget &&
+      fieldMetadataItem.relationDefinition?.targetObjectMetadata
+        ?.nameSingular === CoreObjectNameSingular.TaskTarget &&
       fieldMetadataItem.relationDefinition?.sourceObjectMetadata
         .nameSingular === CoreObjectNameSingular.Task
     ) {
@@ -45,9 +49,10 @@ export const isFieldCellSupported = (fieldMetadataItem: FieldMetadataItem) => {
     }
 
     if (
-      !relationMetadata ||
+      !fieldMetadataItem.relationDefinition ||
       // TODO: Many to many relations are not supported yet.
-      relationMetadata.relationType === RelationMetadataType.ManyToMany ||
+      fieldMetadataItem.relationDefinition.direction ===
+        RelationDefinitionType.ManyToMany ||
       !relationObjectMetadataItem ||
       !isObjectMetadataAvailableForRelation(relationObjectMetadataItem)
     ) {

packages/twenty-front/src/modules/object-record/utils/sanitizeRecordInput.ts

@@ -1,8 +1,8 @@
 import { isString } from '@sniptt/guards';
 
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
-import { isFieldRelationToOneValue } from '@/object-record/record-field/types/guards/isFieldRelationToOneValue';
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
+import { RelationDefinitionType } from '~/generated-metadata/graphql';
 import { FieldMetadataType } from '~/generated/graphql';
 import { isDefined } from '~/utils/isDefined';
 import { getUrlHostName } from '~/utils/url/getUrlHostName';
@@ -29,7 +29,8 @@ export const sanitizeRecordInput = ({
 
         if (
           fieldMetadataItem.type === FieldMetadataType.Relation &&
-          isFieldRelationToOneValue(fieldValue)
+          fieldMetadataItem.relationDefinition?.direction ===
+            RelationDefinitionType.ManyToOne
         ) {
           const relationIdFieldName = `${fieldMetadataItem.name}Id`;
           const relationIdFieldMetadataItem = objectMetadataItem.fields.find(
@@ -41,6 +42,14 @@ export const sanitizeRecordInput = ({
             : undefined;
         }
 
+        if (
+          fieldMetadataItem.type === FieldMetadataType.Relation &&
+          fieldMetadataItem.relationDefinition?.direction ===
+            RelationDefinitionType.OneToMany
+        ) {
+          return undefined;
+        }
+
         return [fieldName, fieldValue];
       })
       .filter(isDefined),