[REFACTOR] remove isRemote assertion from hasFieldPosition util (#10519)

Following this discussion
https://github.com/twentyhq/twenty/pull/10510#discussion_r1971845556
with @ijreilly
This commit is contained in:
Paul Rastoin
2025-02-26 18:28:55 +01:00
committed by GitHub
parent 24aca790f7
commit 5327febcbe
2 changed files with 4 additions and 2 deletions

View File

@ -4,7 +4,6 @@ import { FieldMetadataType } from 'twenty-shared';
export const hasObjectMetadataItemPositionField = ( export const hasObjectMetadataItemPositionField = (
objectMetadataItem: ObjectMetadataItem, objectMetadataItem: ObjectMetadataItem,
) => ) =>
!objectMetadataItem.isRemote &&
objectMetadataItem.fields.some( objectMetadataItem.fields.some(
(field) => field.type === FieldMetadataType.POSITION, (field) => field.type === FieldMetadataType.POSITION,
); );

View File

@ -35,7 +35,10 @@ export const turnSortsIntoOrderBy = (
}) })
.filter(isDefined); .filter(isDefined);
if (hasObjectMetadataItemPositionField(objectMetadataItem)) { if (
!objectMetadataItem.isRemote &&
hasObjectMetadataItemPositionField(objectMetadataItem)
) {
const positionOrderBy = [ const positionOrderBy = [
{ {
position: 'AscNullsFirst', position: 'AscNullsFirst',