922 remove todos from 11809 after release (#12183)

- remove todos
- remove workflow-event-listener.workspace-entity.ts

packages/twenty-server/src/modules/workflow/common/standard-objects/workflow-event-listener.workspace-entity.ts

@@ -1,56 +0,0 @@
-import { msg } from '@lingui/core/macro';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
-import { Relation } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/relation.interface';
-import { RelationOnDeleteAction } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-on-delete-action.interface';
-
-import { BaseWorkspaceEntity } from 'src/engine/twenty-orm/base.workspace-entity';
-import { WorkspaceEntity } from 'src/engine/twenty-orm/decorators/workspace-entity.decorator';
-import { WorkspaceField } from 'src/engine/twenty-orm/decorators/workspace-field.decorator';
-import { WorkspaceIsNullable } from 'src/engine/twenty-orm/decorators/workspace-is-nullable.decorator';
-import { WorkspaceIsSystem } from 'src/engine/twenty-orm/decorators/workspace-is-system.decorator';
-import { WorkspaceJoinColumn } from 'src/engine/twenty-orm/decorators/workspace-join-column.decorator';
-import { WorkspaceRelation } from 'src/engine/twenty-orm/decorators/workspace-relation.decorator';
-import { WORKFLOW_EVENT_LISTENER_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
-import { STANDARD_OBJECT_ICONS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-icons';
-import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
-import { WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceEntity({
-  standardId: STANDARD_OBJECT_IDS.workflowEventListener,
-  namePlural: 'workflowEventListeners',
-  labelSingular: msg`WorkflowEventListener`,
-  labelPlural: msg`WorkflowEventListeners`,
-  description: msg`A workflow event listener`,
-  icon: STANDARD_OBJECT_ICONS.workflowEventListener,
-  labelIdentifierStandardId:
-    WORKFLOW_EVENT_LISTENER_STANDARD_FIELD_IDS.eventName,
-})
-@WorkspaceIsSystem()
-export class WorkflowEventListenerWorkspaceEntity extends BaseWorkspaceEntity {
-  @WorkspaceField({
-    standardId: WORKFLOW_EVENT_LISTENER_STANDARD_FIELD_IDS.eventName,
-    type: FieldMetadataType.TEXT,
-    label: msg`Name`,
-    description: msg`The workflow event listener name`,
-  })
-  eventName: string;
-
-  // Relations
-  @WorkspaceRelation({
-    standardId: WORKFLOW_EVENT_LISTENER_STANDARD_FIELD_IDS.workflow,
-    type: RelationType.MANY_TO_ONE,
-    label: msg`Workflow`,
-    description: msg`WorkflowEventListener workflow`,
-    icon: 'IconSettingsAutomation',
-    inverseSideTarget: () => WorkflowWorkspaceEntity,
-    inverseSideFieldKey: 'eventListeners',
-    onDelete: RelationOnDeleteAction.CASCADE,
-  })
-  @WorkspaceIsNullable()
-  workflow: Relation<WorkflowWorkspaceEntity>;
-
-  @WorkspaceJoinColumn('workflow')
-  workflowId: string;
-}

packages/twenty-server/src/modules/workflow/common/standard-objects/workflow.workspace-entity.ts

@@ -18,7 +18,6 @@ import { STANDARD_OBJECT_ICONS } from 'src/engine/workspace-manager/workspace-sy
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 import { FavoriteWorkspaceEntity } from 'src/modules/favorite/standard-objects/favorite.workspace-entity';
 import { TimelineActivityWorkspaceEntity } from 'src/modules/timeline/standard-objects/timeline-activity.workspace-entity';
-import { WorkflowEventListenerWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-event-listener.workspace-entity';
 import { WorkflowRunWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-run.workspace-entity';
 import { WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
 import { WorkflowAutomatedTriggerWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-automated-trigger.workspace-entity';
@@ -125,17 +124,6 @@ export class WorkflowWorkspaceEntity extends BaseWorkspaceEntity {
   })
   runs: Relation<WorkflowRunWorkspaceEntity[]>;
 
-  @WorkspaceRelation({
-    standardId: WORKFLOW_STANDARD_FIELD_IDS.eventListeners,
-    type: RelationType.ONE_TO_MANY,
-    label: msg`Event Listeners`,
-    description: msg`Workflow event listeners linked to the workflow.`,
-    inverseSideTarget: () => WorkflowEventListenerWorkspaceEntity,
-    onDelete: RelationOnDeleteAction.CASCADE,
-  })
-  @WorkspaceIsSystem()
-  eventListeners: Relation<WorkflowEventListenerWorkspaceEntity[]>;
-
   @WorkspaceRelation({
     standardId: WORKFLOW_STANDARD_FIELD_IDS.automatedTriggers,
     type: RelationType.ONE_TO_MANY,

packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-common.workspace-service.ts

@@ -11,7 +11,6 @@ import {
   WorkflowCommonException,
   WorkflowCommonExceptionCode,
 } from 'src/modules/workflow/common/exceptions/workflow-common.exception';
-import { WorkflowEventListenerWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-event-listener.workspace-entity';
 import { WorkflowRunWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-run.workspace-entity';
 import { WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
 import { WorkflowActionType } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
@@ -137,21 +136,12 @@ export class WorkflowCommonWorkspaceService {
         'workflowRun',
       );
 
-    const workflowEventListenerRepository =
-      await this.twentyORMManager.getRepository<WorkflowEventListenerWorkspaceEntity>(
-        'workflowEventListener',
-      );
-
     const workflowAutomatedTriggerRepository =
       await this.twentyORMManager.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
         'workflowAutomatedTrigger',
       );
 
     workflowIds.forEach((workflowId) => {
-      workflowEventListenerRepository.softDelete({
-        workflowId,
-      });
-
       workflowAutomatedTriggerRepository.softDelete({
         workflowId,
       });

packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service.ts

@@ -7,7 +7,6 @@ import {
   AutomatedTriggerType,
   WorkflowAutomatedTriggerWorkspaceEntity,
 } from 'src/modules/workflow/common/standard-objects/workflow-automated-trigger.workspace-entity';
-import { WorkflowEventListenerWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-event-listener.workspace-entity';
 
 @Injectable()
 export class AutomatedTriggerWorkspaceService {
@@ -24,26 +23,6 @@ export class AutomatedTriggerWorkspaceService {
     type: AutomatedTriggerType;
     settings: AutomatedTriggerSettings;
   }) {
-    if (type === AutomatedTriggerType.DATABASE_EVENT) {
-      // Todo: remove workflowEventListenerRepository updates when data are migrated to workflowAutomatedTrigger
-      const workflowEventListenerRepository =
-        await this.twentyORMManager.getRepository<WorkflowEventListenerWorkspaceEntity>(
-          'workflowEventListener',
-        );
-
-      const workflowEventListener = workflowEventListenerRepository.create({
-        workflowId,
-        eventName: settings.eventName,
-      });
-
-      await workflowEventListenerRepository.save(
-        workflowEventListener,
-        {},
-        manager,
-      );
-      // end-Todo
-    }
-
     const workflowAutomatedTriggerRepository =
       await this.twentyORMManager.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
         'workflowAutomatedTrigger',
@@ -69,20 +48,6 @@ export class AutomatedTriggerWorkspaceService {
     workflowId: string;
     manager: WorkspaceEntityManager;
   }) {
-    // Todo: remove workflowEventListenerRepository updates when data are migrated to workflowAutomatedTrigger
-    const workflowEventListenerRepository =
-      await this.twentyORMManager.getRepository<WorkflowEventListenerWorkspaceEntity>(
-        'workflowEventListener',
-      );
-
-    await workflowEventListenerRepository.delete(
-      {
-        workflowId,
-      },
-      manager,
-    );
-    // end-Todo
-
     const workflowAutomatedTriggerRepository =
       await this.twentyORMManager.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
         'workflowAutomatedTrigger',

packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/database-event-trigger.listener.ts

@@ -17,7 +17,10 @@ import {
   WorkflowTriggerJob,
   WorkflowTriggerJobData,
 } from 'src/modules/workflow/workflow-trigger/jobs/workflow-trigger.job';
-import { WorkflowEventListenerWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-event-listener.workspace-entity';
+import {
+  AutomatedTriggerType,
+  WorkflowAutomatedTriggerWorkspaceEntity,
+} from 'src/modules/workflow/common/standard-objects/workflow-automated-trigger.workspace-entity';
 
 @Injectable()
 export class DatabaseEventTriggerListener {
@@ -89,8 +92,6 @@ export class DatabaseEventTriggerListener {
       return;
     }
 
-    // Todo: uncomment that when data are migrated to workflowAutomatedTrigger
-    /*
     const workflowAutomatedTriggerRepository =
       await this.twentyORMGlobalManager.getRepositoryForWorkspace<WorkflowAutomatedTriggerWorkspaceEntity>(
         workspaceId,
@@ -103,29 +104,8 @@ export class DatabaseEventTriggerListener {
         settings: { eventName: databaseEventName },
       },
     });
-    */
-    // end Todo
 
-    // Todo: remove that when data are migrated to workflowAutomatedTrigger
-    const workflowEventListenerRepository =
-      await this.twentyORMGlobalManager.getRepositoryForWorkspace<WorkflowEventListenerWorkspaceEntity>(
-        workspaceId,
-        'workflowEventListener',
-      );
-
-    const oldEventListeners = await workflowEventListenerRepository.find({
-      where: { eventName: databaseEventName },
-    });
-
-    // end Todo
-
-    // Todo: uncomment that when data are migrated to workflowAutomatedTrigger
-    //for (const eventListener of eventListeners) {
-    // end Todo
-
-    // Todo: remove that when data are migrated to workflowAutomatedTrigger
-    for (const eventListener of oldEventListeners) {
-      // end Todo
+    for (const eventListener of eventListeners) {
       for (const eventPayload of payload.events) {
         this.messageQueueService.add<WorkflowTriggerJobData>(
           WorkflowTriggerJob.name,