admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Renamed nullable utils into isDefined and isUndefinedOrNull (#4402)

Browse Source 
* Renamed nullable utils into isDefined and isUndefinedOrNull
This commit is contained in:
Lucas Bordeau
2024-03-11 14:28:57 +01:00
committed by GitHub
parent 3f15cc5b7a
commit 581dfafe11
169 changed files with 469 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-front/src/modules/settings/data-model/utils/getFieldDefaultPreviewValue.ts
View File

@ -5,7 +5,7 @@ import { isLabelIdentifierField } from '@/object-metadata/utils/isLabelIdentifie
import { SettingsObjectFieldSelectFormValues } from '@/settings/data-model/components/SettingsObjectFieldSelectForm';
import { SETTINGS_FIELD_METADATA_TYPES } from '@/settings/data-model/constants/SettingsFieldMetadataTypes';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
export const getFieldDefaultPreviewValue = ({
fieldMetadataItem,
@ -24,7 +24,7 @@ export const getFieldDefaultPreviewValue = ({
// Select field
if (
fieldMetadataItem.type === FieldMetadataType.Select &&
isNonNullable(selectOptions)
isDefined(selectOptions)
) {
return selectOptions.find(({ isDefault }) => isDefault) || selectOptions[0];
}
@ -32,7 +32,7 @@ export const getFieldDefaultPreviewValue = ({
// Relation field
if (
fieldMetadataItem.type === FieldMetadataType.Relation &&
isNonNullable(relationObjectMetadataItem)
isDefined(relationObjectMetadataItem)
) {
const relationLabelIdentifierFieldMetadataItem =
getLabelIdentifierFieldMetadataItem(relationObjectMetadataItem);

8
packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx
View File

@ -7,8 +7,8 @@ import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { ImageInput } from '@/ui/input/components/ImageInput';
import { getImageAbsoluteURIOrBase64 } from '@/users/utils/getProfilePictureAbsoluteURI';
import { useUploadProfilePictureMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { isDefined } from '~/utils/isDefined';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
export const ProfilePictureUploader = () => {
const [uploadPicture, { loading: isUploading }] =
@ -27,7 +27,7 @@ export const ProfilePictureUploader = () => {
});
const handleUpload = async (file: File) => {
if (isNullable(file)) {
if (isUndefinedOrNull(file)) {
return;
}
@ -74,7 +74,7 @@ export const ProfilePictureUploader = () => {
};
const handleAbort = async () => {
if (isNonNullable(uploadController)) {
if (isDefined(uploadController)) {
uploadController.abort();
setUploadController(null);
}

8
packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx
View File

@ -6,8 +6,8 @@ import { useRecoilValue } from 'recoil';
import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
import { TextInput } from '@/ui/input/components/TextInput';
import { useUpdateWorkspaceMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { isDefined } from '~/utils/isDefined';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
import { logError } from '~/utils/logError';
const StyledComboInputContainer = styled.div`
@ -39,7 +39,7 @@ export const NameField = ({
// eslint-disable-next-line react-hooks/exhaustive-deps
const debouncedUpdate = useCallback(
debounce(async (name: string) => {
if (isNonNullable(onNameUpdate)) {
if (isDefined(onNameUpdate)) {
onNameUpdate(displayName);
}
if (!autoSave || !name) {
@ -54,7 +54,7 @@ export const NameField = ({
},
});
if (isNonNullable(errors) || isNullable(data?.updateWorkspace)) {
if (isDefined(errors) || isUndefinedOrNull(data?.updateWorkspace)) {
throw errors;
}
} catch (error) {

4
packages/twenty-front/src/modules/settings/workspace/components/WorkspaceLogoUploader.tsx
View File

@ -7,7 +7,7 @@ import {
useUpdateWorkspaceMutation,
useUploadWorkspaceLogoMutation,
} from '~/generated/graphql';
import { isNullable } from '~/utils/isNullable';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
export const WorkspaceLogoUploader = () => {
const [uploadLogo] = useUploadWorkspaceLogoMutation();
@ -17,7 +17,7 @@ export const WorkspaceLogoUploader = () => {
);
const onUpload = async (file: File) => {
if (isNullable(file)) {
if (isUndefinedOrNull(file)) {
return;
}
if (!currentWorkspace?.id) {