admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Renamed nullable utils into isDefined and isUndefinedOrNull (#4402)

Browse Source 
* Renamed nullable utils into isDefined and isUndefinedOrNull
This commit is contained in:
Lucas Bordeau
2024-03-11 14:28:57 +01:00
committed by GitHub
parent 3f15cc5b7a
commit 581dfafe11
169 changed files with 469 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx
View File

@ -8,7 +8,7 @@ import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
import { EditableFilterChip } from '@/views/components/EditableFilterChip';
import { useViewBar } from '@/views/hooks/useViewBar';
import { ViewFilter } from '@/views/types/ViewFilter';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
type EditableFilterDropdownButtonProps = {
viewFilterDropdownId: string;
@ -40,7 +40,7 @@ export const EditableFilterDropdownButton = ({
filterDefinition.fieldMetadataId === viewFilter.fieldMetadataId,
);
if (isNonNullable(filterDefinition)) {
if (isDefined(filterDefinition)) {
setFilterDefinitionUsedInDropdown(filterDefinition);
setSelectedOperandInDropdown(viewFilter.operand);
setSelectedFilter(viewFilter);

8
packages/twenty-front/src/modules/views/components/ViewBarEffect.tsx
View File

@ -7,8 +7,8 @@ import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
import { useViewBar } from '@/views/hooks/useViewBar';
import { GraphQLView } from '@/views/types/GraphQLView';
import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { isDefined } from '~/utils/isDefined';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
@ -52,11 +52,11 @@ export const ViewBarEffect = () => {
newViews[0] ??
null;
if (isNullable(currentView)) return;
if (isUndefinedOrNull(currentView)) return;
setCurrentViewId(currentView.id);
if (isNonNullable(currentView?.viewFields)) {
if (isDefined(currentView?.viewFields)) {
loadViewFields(currentView.viewFields, currentView.id);
loadViewFilters(currentView.viewFilters, currentView.id);
loadViewSorts(currentView.viewSorts, currentView.id);

6
packages/twenty-front/src/modules/views/components/ViewBarFilterEffect.tsx
View File

@ -5,7 +5,7 @@ import { useRecoilValue } from 'recoil';
import { useFilterDropdown } from '@/object-record/object-filter-dropdown/hooks/useFilterDropdown';
import { Filter } from '@/object-record/object-filter-dropdown/types/Filter';
import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
type ViewBarFilterEffectProps = {
filterDropdownId: string;
@ -32,11 +32,11 @@ export const ViewBarFilterEffect = ({
} = useFilterDropdown({ filterDropdownId });
useEffect(() => {
if (isNonNullable(availableFilterDefinitions)) {
if (isDefined(availableFilterDefinitions)) {
setAvailableFilterDefinitions(availableFilterDefinitions);
}
if (isNonNullable(onFilterSelect)) {
if (isDefined(onFilterSelect)) {
setOnFilterSelect(() => onFilterSelect);
}
}, [

6
packages/twenty-front/src/modules/views/components/ViewBarSortEffect.tsx
View File

@ -4,7 +4,7 @@ import { useRecoilValue } from 'recoil';
import { useSortDropdown } from '@/object-record/object-sort-dropdown/hooks/useSortDropdown';
import { Sort } from '@/object-record/object-sort-dropdown/types/Sort';
import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
type ViewBarSortEffectProps = {
sortDropdownId: string;
@ -26,10 +26,10 @@ export const ViewBarSortEffect = ({
});
useEffect(() => {
if (isNonNullable(availableSortDefinitions)) {
if (isDefined(availableSortDefinitions)) {
setAvailableSortDefinitions(availableSortDefinitions);
}
if (isNonNullable(onSortSelect)) {
if (isDefined(onSortSelect)) {
setOnSortSelect(() => onSortSelect);
}
}, [

6
packages/twenty-front/src/modules/views/components/ViewFieldsVisibilityDropdownSection.tsx
View File

@ -20,7 +20,7 @@ import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem';
import { MenuItemDraggable } from '@/ui/navigation/menu-item/components/MenuItemDraggable';
import { useListenClickOutside } from '@/ui/utilities/pointer-event/hooks/useListenClickOutside';
import { groupArrayItemsBy } from '~/utils/array/groupArrayItemsBy';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
type ViewFieldsVisibilityDropdownSectionProps = {
fields: Omit<ColumnDefinition<FieldMetadata>, 'size'>[];
@ -69,7 +69,7 @@ export const ViewFieldsVisibilityDropdownSection = ({
Icon: field.isVisible ? IconMinus : IconPlus,
onClick: () => onVisibilityChange(field),
},
].filter(isNonNullable);
].filter(isDefined);
return iconButtons.length ? iconButtons : undefined;
};
@ -134,7 +134,7 @@ export const ViewFieldsVisibilityDropdownSection = ({
/>
)}
</DropdownMenuItemsContainer>
{isNonNullable(openToolTipIndex) &&
{isDefined(openToolTipIndex) &&
createPortal(
<AppTooltip
anchorSelect={`.${title}-${

4
packages/twenty-front/src/modules/views/components/ViewsDropdownButton.tsx
View File

@ -20,7 +20,7 @@ import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
import { VIEWS_DROPDOWN_ID } from '@/views/constants/ViewsDropdownId';
import { useViewBar } from '@/views/hooks/useViewBar';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
@ -161,7 +161,7 @@ export const ViewsDropdownButton = ({
handleDeleteViewButtonClick(event, view.id),
}
: null,
].filter(isNonNullable)}
].filter(isDefined)}
onClick={() => handleViewSelect(view.id)}
LeftIcon={IconList}
text={view.name}