admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Renamed nullable utils into isDefined and isUndefinedOrNull (#4402)

Browse Source 
* Renamed nullable utils into isDefined and isUndefinedOrNull
This commit is contained in:
Lucas Bordeau
2024-03-11 14:28:57 +01:00
committed by GitHub
parent 3f15cc5b7a
commit 581dfafe11
169 changed files with 469 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/twenty-front/src/modules/views/hooks/internal/useFiltersFromQueryParams.ts
View File

@ -15,8 +15,8 @@ import { useGenerateFindManyRecordsQuery } from '@/object-record/hooks/useGenera
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { ViewFilter } from '@/views/types/ViewFilter';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { isDefined } from '~/utils/isDefined';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
const filterQueryParamsSchema = z.object({
filter: z.record(
@ -71,7 +71,7 @@ export const useFiltersFromQueryParams = () => {
field: fieldMetadataItem,
});
if (isNullable(filterDefinition)) return null;
if (isUndefinedOrNull(filterDefinition)) return null;
const relationObjectMetadataNameSingular =
fieldMetadataItem.toRelationMetadata?.fromObjectMetadata
@ -97,7 +97,7 @@ export const useFiltersFromQueryParams = () => {
if (
isNonEmptyString(relationObjectMetadataNamePlural) &&
isNonNullable(relationObjectMetadataItem) &&
isDefined(relationObjectMetadataItem) &&
Array.isArray(filterValueFromURL)
) {
const queryResult = await apolloClient.query<
@ -144,7 +144,7 @@ export const useFiltersFromQueryParams = () => {
},
),
)
).filter(isNonNullable);
).filter(isDefined);
},
[
apolloClient,

4
packages/twenty-front/src/modules/views/hooks/internal/useViewSorts.ts
View File

@ -8,7 +8,7 @@ import { Sort } from '@/object-record/object-sort-dropdown/types/Sort';
import { savedViewSortsScopedFamilyState } from '@/views/states/savedViewSortsScopedFamilyState';
import { ViewSort } from '@/views/types/ViewSort';
import { getViewScopedStateValuesFromSnapshot } from '@/views/utils/getViewScopedStateValuesFromSnapshot';
import { isNullable } from '~/utils/isNullable';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
import { useViewScopedStates } from './useViewScopedStates';
@ -43,7 +43,7 @@ export const useViewSorts = (viewScopeId: string) => {
return;
}
if (isNullable(currentViewSorts)) {
if (isUndefinedOrNull(currentViewSorts)) {
return;
}
if (!savedViewSortsByKey) {

18
packages/twenty-front/src/modules/views/hooks/useViewBar.ts
View File

@ -9,8 +9,8 @@ import { ViewField } from '@/views/types/ViewField';
import { ViewFilter } from '@/views/types/ViewFilter';
import { ViewSort } from '@/views/types/ViewSort';
import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { isDefined } from '~/utils/isDefined';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
import { ViewScopeInternalContext } from '../scopes/scope-internal-context/ViewScopeInternalContext';
import { currentViewFieldsScopedFamilyState } from '../states/currentViewFieldsScopedFamilyState';
@ -114,11 +114,11 @@ export const useViewBar = (props?: UseViewProps) => {
viewId: currentViewId,
});
if (isNullable(availableFieldDefinitions)) {
if (isUndefinedOrNull(availableFieldDefinitions)) {
return;
}
const queriedViewFields = viewFields.filter(isNonNullable);
const queriedViewFields = viewFields.filter(isDefined);
if (isPersistingView) {
return;
@ -154,7 +154,7 @@ export const useViewBar = (props?: UseViewProps) => {
viewId: currentViewId,
});
if (isNullable(availableFilterDefinitions)) {
if (isUndefinedOrNull(availableFilterDefinitions)) {
return;
}
@ -173,7 +173,7 @@ export const useViewBar = (props?: UseViewProps) => {
definition: availableFilterDefinition,
};
})
.filter(isNonNullable);
.filter(isDefined);
if (!isDeeplyEqual(savedViewFilters, queriedViewFilters)) {
set(savedViewFiltersState, queriedViewFilters);
@ -220,7 +220,7 @@ export const useViewBar = (props?: UseViewProps) => {
definition: availableSortDefinition,
};
})
.filter(isNonNullable);
.filter(isDefined);
if (!isDeeplyEqual(savedViewSorts, queriedViewSorts)) {
set(savedViewSortsState, queriedViewSorts);
@ -269,11 +269,11 @@ export const useViewBar = (props?: UseViewProps) => {
viewScopeId: scopeId,
});
if (isNonNullable(savedViewFilters)) {
if (isDefined(savedViewFilters)) {
set(currentViewFiltersState, savedViewFilters);
onViewFiltersChange?.(savedViewFilters);
}
if (isNonNullable(savedViewSorts)) {
if (isDefined(savedViewSorts)) {
set(currentViewSortsState, savedViewSorts);
onViewSortsChange?.(savedViewSorts);
}