admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Renamed nullable utils into isDefined and isUndefinedOrNull (#4402)

Browse Source 
* Renamed nullable utils into isDefined and isUndefinedOrNull
This commit is contained in:
Lucas Bordeau
2024-03-11 14:28:57 +01:00
committed by GitHub
parent 3f15cc5b7a
commit 581dfafe11
169 changed files with 469 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/pages/auth/ChooseYourPlan.tsx
View File

@ -18,7 +18,7 @@ import {
useCheckoutSessionMutation,
useGetProductPricesQuery,
} from '~/generated/graphql.tsx';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
const StyledChoosePlanContainer = styled.div`
display: flex;
@ -76,7 +76,7 @@ export const ChooseYourPlan = () => {
(price) => price.recurringInterval === 'month',
)?.[0];
if (
isNonNullable(monthPrice) &&
isDefined(monthPrice) &&
isNumber(monthPrice.unitAmount) &&
monthPrice.unitAmount > 0 &&
isNumber(price.unitAmount) &&

4
packages/twenty-front/src/pages/auth/CreateWorkspace.tsx
View File

@ -21,7 +21,7 @@ import { MainButton } from '@/ui/input/button/components/MainButton';
import { TextInput } from '@/ui/input/components/TextInput';
import { GET_CURRENT_USER } from '@/users/graphql/queries/getCurrentUser';
import { useActivateWorkspaceMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
const StyledContentContainer = styled.div`
width: 100%;
@ -82,7 +82,7 @@ export const CreateWorkspace = () => {
include: [FIND_MANY_OBJECT_METADATA_ITEMS],
});
if (isNonNullable(result.errors)) {
if (isDefined(result.errors)) {
throw result.errors ?? new Error('Unknown error');
}

4
packages/twenty-front/src/pages/impersonate/ImpersonateEffect.tsx
View File

@ -8,7 +8,7 @@ import { currentUserState } from '@/auth/states/currentUserState';
import { tokenPairState } from '@/auth/states/tokenPairState';
import { AppPath } from '@/types/AppPath';
import { useImpersonateMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
export const ImpersonateEffect = () => {
const navigate = useNavigate();
@ -30,7 +30,7 @@ export const ImpersonateEffect = () => {
variables: { userId },
});
if (isNonNullable(impersonateResult.errors)) {
if (isDefined(impersonateResult.errors)) {
throw impersonateResult.errors;
}

6
packages/twenty-front/src/pages/object-record/RecordShowPage.tsx
View File

@ -16,7 +16,7 @@ import { ShowPageAddButton } from '@/ui/layout/show-page/components/ShowPageAddB
import { ShowPageMoreButton } from '@/ui/layout/show-page/components/ShowPageMoreButton';
import { PageTitle } from '@/ui/utilities/page-title/PageTitle';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
export const RecordShowPage = () => {
const { objectNameSingular, objectRecordId } = useParams<{
@ -55,12 +55,12 @@ export const RecordShowPage = () => {
(favorite) => favorite.recordId === objectRecordId,
);
const isFavorite = isNonNullable(correspondingFavorite);
const isFavorite = isDefined(correspondingFavorite);
const handleFavoriteButtonClick = async () => {
if (!objectNameSingular || !record) return;
if (isFavorite && isNonNullable(record)) {
if (isFavorite && isDefined(record)) {
deleteFavorite(correspondingFavorite.id);
} else {
createFavorite(record, objectNameSingular);

4
packages/twenty-front/src/pages/settings/SettingsBilling.tsx
View File

@ -18,7 +18,7 @@ import { Button } from '@/ui/input/button/components/Button.tsx';
import { SubMenuTopBarContainer } from '@/ui/layout/page/SubMenuTopBarContainer';
import { Section } from '@/ui/layout/section/components/Section.tsx';
import { useBillingPortalSessionQuery } from '~/generated/graphql.tsx';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
const StyledH1Title = styled(H1Title)`
margin-bottom: 0;
@ -46,7 +46,7 @@ export const SettingsBilling = () => {
onboardingStatus === OnboardingStatus.Canceled;
const openBillingPortal = () => {
if (isNonNullable(data)) {
if (isDefined(data)) {
window.location.replace(data.billingPortalSession.url);
}
};

6
packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
View File

@ -28,7 +28,7 @@ import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
import { View } from '@/views/types/View';
import { ViewType } from '@/views/types/ViewType';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isNullable } from '~/utils/isNullable';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
const StyledSettingsObjectFieldTypeSelect = styled(
SettingsDataModelFieldTypeSelect,
@ -96,7 +96,7 @@ export const SettingsObjectNewFieldStep2 = () => {
onCompleted: async (data: ObjectRecordConnection<View>) => {
const views = data.edges;
if (isNullable(views)) return;
if (isUndefinedOrNull(views)) return;
setObjectViews(data.edges.map(({ node }) => node));
},
@ -112,7 +112,7 @@ export const SettingsObjectNewFieldStep2 = () => {
onCompleted: async (data: ObjectRecordConnection<View>) => {
const views = data.edges;
if (isNullable(views)) return;
if (isUndefinedOrNull(views)) return;
setRelationObjectViews(data.edges.map(({ node }) => node));
},

4
packages/twenty-front/src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx
View File

@ -26,7 +26,7 @@ import { SubMenuTopBarContainer } from '@/ui/layout/page/SubMenuTopBarContainer'
import { Section } from '@/ui/layout/section/components/Section';
import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
import { useGenerateApiKeyTokenMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
const StyledInfo = styled.span`
color: ${({ theme }) => theme.font.color.light};
@ -119,7 +119,7 @@ export const SettingsDevelopersApiKeyDetail = () => {
};
useEffect(() => {
if (isNonNullable(apiKeyData)) {
if (isDefined(apiKeyData)) {
return () => {
setGeneratedApi(apiKeyId, null);
};

4
packages/twenty-front/src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx
View File

@ -18,7 +18,7 @@ import { SubMenuTopBarContainer } from '@/ui/layout/page/SubMenuTopBarContainer'
import { Section } from '@/ui/layout/section/components/Section';
import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
import { useGenerateApiKeyTokenMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
export const SettingsDevelopersApiKeysNew = () => {
const [generateOneApiKeyToken] = useGenerateApiKeyTokenMutation();
@ -55,7 +55,7 @@ export const SettingsDevelopersApiKeysNew = () => {
expiresAt: expiresAt,
},
});
if (isNonNullable(tokenData.data?.generateApiKeyToken)) {
if (isDefined(tokenData.data?.generateApiKeyToken)) {
setGeneratedApi(newApiKey.id, tokenData.data.generateApiKeyToken.token);
navigate(`/settings/developers/api-keys/${newApiKey.id}`);
}

4
packages/twenty-front/src/pages/tasks/TasksEffect.tsx
View File

@ -4,7 +4,7 @@ import { useRecoilValue } from 'recoil';
import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
import { useFilterDropdown } from '@/object-record/object-filter-dropdown/hooks/useFilterDropdown';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { isNonNullable } from '~/utils/isNonNullable';
import { isDefined } from '~/utils/isDefined';
import { tasksFilterDefinitions } from './tasks-filter-definitions';
@ -27,7 +27,7 @@ export const TasksEffect = ({ filterDropdownId }: TasksEffectProps) => {
}, [setAvailableFilterDefinitions]);
useEffect(() => {
if (isNonNullable(currentWorkspaceMember)) {
if (isDefined(currentWorkspaceMember)) {
setSelectedFilter({
fieldMetadataId: 'assigneeId',
value: JSON.stringify(currentWorkspaceMember.id),