admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Catching temporary errors in microsft batch calls (#12409)

Browse Source 
# 🐛 Improve Microsoft Graph API Temporary Error Handling on PARSE method

fixes Sentry error
<img width="886" alt="Screenshot 2025-06-02 at 14 39 19"
src="https://github.com/user-attachments/assets/117a2601-4bad-48a2-8112-2bb682559b15"
/>


### What:
Enhances error handling for Microsoft Graph API batch calls 
### How: by treating HTTP 503 (Service Unavailable) as temporary errors
alongside existing 429 (Rate Limit) handling.

### Additional: 
improving logging


Fixes https://github.com/twentyhq/twenty/issues/12257
This commit is contained in:
Guillim
2025-06-02 14:46:36 +02:00
committed by GitHub
parent 2bf11d425a
commit 5914a89df2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.ts
View File

@ -143,8 +143,8 @@ export class MicrosoftGetMessagesService {
return response.body; return response.body;
} }
if (!response.body) { if (response.status !== 503 && response.status !== 429) {
this.logger.error(`No body found for response`, response); this.logger.error(`Microsoft parseBatchResponse error`, response);
} }
const errorParsed = response?.body?.error const errorParsed = response?.body?.error

2
packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.ts
View File

@ -40,7 +40,7 @@ export const parseMicrosoftMessagesImportError = (error: {
} }
} }
if (error.statusCode === 429) { if (error.statusCode === 429 || error.statusCode === 503) {
return new MessageImportDriverException( return new MessageImportDriverException(
`Microsoft Graph API ${error.code} ${error.statusCode} error: ${error.message}`, `Microsoft Graph API ${error.code} ${error.statusCode} error: ${error.message}`,
MessageImportDriverExceptionCode.TEMPORARY_ERROR, MessageImportDriverExceptionCode.TEMPORARY_ERROR,