[REFACTOR][BUG] Dynamically compute field to write in cache CREATE (#10130)
# Introduction While importing records encountering missing expected fields when writting a fragment from apollo cache ## Updates ### 1/ `createdBy` Default value When inserting in cache in create single or many we will now make optimistic behavior on the createdBy value ### 2/ `createRecordInCache` dynamically create `recordGrqlFields` When creating an entry in cache, we will now dynamically generate fields to be written in the fragment instead of expecting all of them. As by nature record could be partial ### 3/ Strictly typed `RecordGqlFields` # Conclusion closes #9927
This commit is contained in:
@ -53,6 +53,8 @@ export const useFieldPreviewValue = ({
|
||||
case FieldMetadataType.PHONES:
|
||||
return getPhonesFieldPreviewValue({ fieldMetadataItem });
|
||||
default:
|
||||
return getFieldPreviewValue({ fieldMetadataItem });
|
||||
return getFieldPreviewValue({
|
||||
fieldMetadataItem,
|
||||
});
|
||||
}
|
||||
};
|
||||
|
||||
@ -24,7 +24,9 @@ describe('getFieldPreviewValue', () => {
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValue({ fieldMetadataItem });
|
||||
const result = getFieldPreviewValue({
|
||||
fieldMetadataItem,
|
||||
});
|
||||
|
||||
// Then
|
||||
expect(result).toBe(false);
|
||||
@ -42,7 +44,9 @@ describe('getFieldPreviewValue', () => {
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValue({ fieldMetadataItem });
|
||||
const result = getFieldPreviewValue({
|
||||
fieldMetadataItem,
|
||||
});
|
||||
|
||||
// Then
|
||||
expect(result).toBe(2000);
|
||||
@ -63,7 +67,9 @@ describe('getFieldPreviewValue', () => {
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValue({ fieldMetadataItem });
|
||||
const result = getFieldPreviewValue({
|
||||
fieldMetadataItem,
|
||||
});
|
||||
|
||||
// Then
|
||||
expect(result).toBeNull();
|
||||
|
||||
@ -5,11 +5,12 @@ import { getSettingsFieldTypeConfig } from '@/settings/data-model/utils/getSetti
|
||||
import { isFieldTypeSupportedInSettings } from '@/settings/data-model/utils/isFieldTypeSupportedInSettings';
|
||||
import { isDefined } from 'twenty-shared';
|
||||
|
||||
type getFieldPreviewValueArgs = {
|
||||
fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'defaultValue'>;
|
||||
};
|
||||
export const getFieldPreviewValue = ({
|
||||
fieldMetadataItem,
|
||||
}: {
|
||||
fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'defaultValue'>;
|
||||
}) => {
|
||||
}: getFieldPreviewValueArgs) => {
|
||||
if (!isFieldTypeSupportedInSettings(fieldMetadataItem.type)) return null;
|
||||
|
||||
if (
|
||||
@ -18,7 +19,9 @@ export const getFieldPreviewValue = ({
|
||||
fieldValue: fieldMetadataItem.defaultValue,
|
||||
})
|
||||
) {
|
||||
return generateDefaultFieldValue(fieldMetadataItem);
|
||||
return generateDefaultFieldValue({
|
||||
fieldMetadataItem,
|
||||
});
|
||||
}
|
||||
|
||||
const fieldTypeConfig = getSettingsFieldTypeConfig(fieldMetadataItem.type);
|
||||
|
||||
Reference in New Issue
Block a user