[REFACTOR][BUG] Dynamically compute field to write in cache CREATE (#10130)
# Introduction While importing records encountering missing expected fields when writting a fragment from apollo cache ## Updates ### 1/ `createdBy` Default value When inserting in cache in create single or many we will now make optimistic behavior on the createdBy value ### 2/ `createRecordInCache` dynamically create `recordGrqlFields` When creating an entry in cache, we will now dynamically generate fields to be written in the fragment instead of expecting all of them. As by nature record could be partial ### 3/ Strictly typed `RecordGqlFields` # Conclusion closes #9927
This commit is contained in:
@ -3,15 +3,16 @@ import { generateDepthOneRecordGqlFields } from '@/object-record/graphql/utils/g
|
||||
import { prefillRecord } from '@/object-record/utils/prefillRecord';
|
||||
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
|
||||
|
||||
type GenerateEmptyJestRecordNodeArgs = {
|
||||
objectNameSingular: string;
|
||||
input: Record<string, unknown>;
|
||||
withDepthOneRelation?: boolean;
|
||||
};
|
||||
export const generateEmptyJestRecordNode = ({
|
||||
objectNameSingular,
|
||||
input,
|
||||
withDepthOneRelation = false,
|
||||
}: {
|
||||
objectNameSingular: string;
|
||||
input: Record<string, unknown>;
|
||||
withDepthOneRelation?: boolean;
|
||||
}) => {
|
||||
}: GenerateEmptyJestRecordNodeArgs) => {
|
||||
const objectMetadataItem = generatedMockObjectMetadataItems.find(
|
||||
(item) => item.nameSingular === objectNameSingular,
|
||||
);
|
||||
@ -22,7 +23,10 @@ export const generateEmptyJestRecordNode = ({
|
||||
);
|
||||
}
|
||||
|
||||
const prefilledRecord = prefillRecord({ objectMetadataItem, input });
|
||||
const prefilledRecord = prefillRecord({
|
||||
objectMetadataItem,
|
||||
input,
|
||||
});
|
||||
|
||||
return getRecordNodeFromRecord({
|
||||
record: prefilledRecord,
|
||||
|
||||
@ -1,5 +1,6 @@
|
||||
import { RecordGqlConnection } from '@/object-record/graphql/types/RecordGqlConnection';
|
||||
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
||||
import { FieldMetadataType } from 'twenty-shared';
|
||||
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
|
||||
|
||||
export const getPeopleMock = (): ObjectRecord[] => {
|
||||
@ -20,6 +21,22 @@ export const getPersonObjectMetadataItem = () => {
|
||||
return personObjectMetadataItem;
|
||||
};
|
||||
|
||||
export const getPersonFieldMetadataItem = (
|
||||
fieldMetadataType: FieldMetadataType,
|
||||
objectMetadataItem = getPersonObjectMetadataItem(),
|
||||
) => {
|
||||
const result = objectMetadataItem.fields.find(
|
||||
(field) => field.type === fieldMetadataType,
|
||||
);
|
||||
if (!result) {
|
||||
throw new Error(
|
||||
`Person fieldmetadata item type ${fieldMetadataType} not found`,
|
||||
);
|
||||
}
|
||||
|
||||
return result;
|
||||
};
|
||||
|
||||
export const getPersonRecord = (
|
||||
overrides?: Partial<ObjectRecord>,
|
||||
index = 0,
|
||||
|
||||
@ -1,10 +1,15 @@
|
||||
export const mockWorkspaceMembers = [
|
||||
import { CurrentWorkspaceMember } from '@/auth/states/currentWorkspaceMemberState';
|
||||
import { WorkspaceMember } from '@/workspace-member/types/WorkspaceMember';
|
||||
|
||||
export const mockWorkspaceMembers: WorkspaceMember[] = [
|
||||
{
|
||||
id: '20202020-1553-45c6-a028-5a9064cce07f',
|
||||
name: {
|
||||
firstName: 'Jane',
|
||||
lastName: 'Doe',
|
||||
},
|
||||
__typename: 'WorkspaceMember',
|
||||
userEmail: 'jane.doe@twenty.com',
|
||||
locale: 'en',
|
||||
avatarUrl: '',
|
||||
createdAt: '2023-12-18T09:51:19.645Z',
|
||||
@ -18,6 +23,8 @@ export const mockWorkspaceMembers = [
|
||||
firstName: 'John',
|
||||
lastName: 'Wick',
|
||||
},
|
||||
userEmail: 'john.wick@twenty.com',
|
||||
__typename: 'WorkspaceMember',
|
||||
locale: 'en',
|
||||
avatarUrl: '',
|
||||
createdAt: '2023-12-18T09:51:19.645Z',
|
||||
@ -26,3 +33,26 @@ export const mockWorkspaceMembers = [
|
||||
colorScheme: 'Dark' as const,
|
||||
},
|
||||
];
|
||||
|
||||
export const mockCurrentWorkspaceMembers: CurrentWorkspaceMember[] =
|
||||
mockWorkspaceMembers.map(
|
||||
({
|
||||
id,
|
||||
locale,
|
||||
name,
|
||||
avatarUrl,
|
||||
colorScheme,
|
||||
dateFormat,
|
||||
timeFormat,
|
||||
timeZone,
|
||||
}) => ({
|
||||
id,
|
||||
locale,
|
||||
name,
|
||||
avatarUrl,
|
||||
colorScheme,
|
||||
dateFormat,
|
||||
timeFormat,
|
||||
timeZone,
|
||||
}),
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user