Fix deactivate objects impacts (#11185)

In this PR: - Remove deactivated objects from ActivityTargetInlineCell record picker - Prevent users to deactivate createdAt, updatedAt, deletedAt fields on any objects Still left: - write unit tests on the assert utils - write integration tests on field metadata service - prevent users to deactivate createdAt, updatedAt, deletedAt on FE
2025-03-26 20:45:46 +01:00
parent 90e884d33f
commit 5bd10d40cb
49 changed files with 861 additions and 531 deletions
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/constants/test-object-names.constant.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/constants/test-object-names.constant.ts
@ -1,2 +1,2 @@
-export const LISTING_NAME_SINGULAR = 'listing';
-export const LISTING_NAME_PLURAL = 'listings';
+export const LISTING_NAME_SINGULAR = 'listinga';
+export const LISTING_NAME_PLURAL = 'listingas';
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/failing-create-one-object-metadata.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/failing-create-one-object-metadata.integration-spec.ts
@ -1,5 +1,5 @@
-import { getMockCreateObjectInput } from 'test/integration/utils/object-metadata/generate-mock-create-object-metadata-input';
-import { performFailingObjectMetadataCreation } from 'test/integration/utils/object-metadata/perform-failing-object-metadata-creation';
+import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
+import { getMockCreateObjectInput } from 'test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input';
 import { EachTestingContext } from 'twenty-shared/testing';

 import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
@ -124,9 +124,10 @@ const allTestsUseCases = [

 describe('Object metadata creation should fail', () => {
  it.each(allTestsUseCases)('$title', async ({ context }) => {
-    const errors = await performFailingObjectMetadataCreation(
-      getMockCreateObjectInput(context),
-    );
+    const { errors } = await createOneObjectMetadata({
+      input: getMockCreateObjectInput(context),
+      expectToFail: true,
+    });

    expect(errors.length).toBe(1);
    const firstError = errors[0];
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/rename-custom-object.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/rename-custom-object.integration-spec.ts
@ -1,11 +1,10 @@
-import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
-import { createOneObjectMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util';
-import { deleteOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util';
-import { objectsMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/objects-metadata-factory.util';
-import { updateOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-factory.util';
+import { findManyFieldsMetadataQueryFactory } from 'test/integration/metadata/suites/field-metadata/utils/find-many-fields-metadata-query-factory.util';
+import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
+import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
+import { findManyObjectMetadataQueryFactory } from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata-query-factory.util';
+import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
 import { createOneRelationMetadataFactory } from 'test/integration/metadata/suites/utils/create-one-relation-metadata-factory.util';
 import { deleteOneRelationMetadataItemFactory } from 'test/integration/metadata/suites/utils/delete-one-relation-metadata-factory.util';
-import { fieldsMetadataFactory } from 'test/integration/metadata/suites/utils/fields-metadata-factory.util';
 import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
 import { FieldMetadataType } from 'twenty-shared/types';

@ -37,7 +36,7 @@ describe('Custom object renaming', () => {
    {},
  );

-  const standardObjectsGraphqlOperation = objectsMetadataFactory({
+  const standardObjectsGraphqlOperation = findManyObjectMetadataQueryFactory({
    gqlFields: `
    id
    nameSingular
@ -50,7 +49,7 @@ describe('Custom object renaming', () => {
    },
  });

-  const fieldsGraphqlOperation = fieldsMetadataFactory({
+  const fieldsGraphqlOperation = findManyFieldsMetadataQueryFactory({
    gqlFields: `
        id
        name
@ -94,22 +93,18 @@ describe('Custom object renaming', () => {
    };

    // Act
-    const graphqlOperation = createOneObjectMetadataFactory({
-      input: { object: LISTING_OBJECT },
+    const { data } = await createOneObjectMetadata({
+      input: LISTING_OBJECT,
      gqlFields: `
          id
          nameSingular
      `,
    });

-    const response = await makeMetadataAPIRequest(graphqlOperation);
-
    // Assert
-    expect(response.body.data.createOneObject.nameSingular).toBe(
-      LISTING_NAME_SINGULAR,
-    );
+    expect(data.createOneObject.nameSingular).toBe(LISTING_NAME_SINGULAR);

-    listingObjectId = response.body.data.createOneObject.id;
+    listingObjectId = data.createOneObject.id;

    const fields = await makeMetadataAPIRequest(fieldsGraphqlOperation);

@ -206,43 +201,31 @@ describe('Custom object renaming', () => {
    const HOUSE_NAME_PLURAL = 'houses';
    const HOUSE_LABEL_SINGULAR = 'House';
    const HOUSE_LABEL_PLURAL = 'Houses';
-    const updateListingNameGraphqlOperation =
-      updateOneObjectMetadataItemFactory({
-        gqlFields: `
+
+    // Act
+    const { data } = await updateOneObjectMetadata({
+      gqlFields: `
        nameSingular
        labelSingular
        namePlural
        labelPlural
        `,
-        input: {
-          idToUpdate: listingObjectId,
-          updatePayload: {
-            nameSingular: HOUSE_NAME_SINGULAR,
-            namePlural: HOUSE_NAME_PLURAL,
-            labelSingular: HOUSE_LABEL_SINGULAR,
-            labelPlural: HOUSE_LABEL_PLURAL,
-          },
+      input: {
+        idToUpdate: listingObjectId,
+        updatePayload: {
+          nameSingular: HOUSE_NAME_SINGULAR,
+          namePlural: HOUSE_NAME_PLURAL,
+          labelSingular: HOUSE_LABEL_SINGULAR,
+          labelPlural: HOUSE_LABEL_PLURAL,
        },
-      });
-
-    // Act
-    const updateListingNameResponse = await makeMetadataAPIRequest(
-      updateListingNameGraphqlOperation,
-    );
+      },
+    });

    // Assert
-    expect(
-      updateListingNameResponse.body.data.updateOneObject.nameSingular,
-    ).toBe(HOUSE_NAME_SINGULAR);
-    expect(updateListingNameResponse.body.data.updateOneObject.namePlural).toBe(
-      HOUSE_NAME_PLURAL,
-    );
-    expect(
-      updateListingNameResponse.body.data.updateOneObject.labelSingular,
-    ).toBe(HOUSE_LABEL_SINGULAR);
-    expect(
-      updateListingNameResponse.body.data.updateOneObject.labelPlural,
-    ).toBe(HOUSE_LABEL_PLURAL);
+    expect(data.updateOneObject.nameSingular).toBe(HOUSE_NAME_SINGULAR);
+    expect(data.updateOneObject.namePlural).toBe(HOUSE_NAME_PLURAL);
+    expect(data.updateOneObject.labelSingular).toBe(HOUSE_LABEL_SINGULAR);
+    expect(data.updateOneObject.labelPlural).toBe(HOUSE_LABEL_PLURAL);

    const fieldsResponse = await makeMetadataAPIRequest(fieldsGraphqlOperation);

@ -306,14 +289,12 @@ describe('Custom object renaming', () => {
  });

  it('5. should delete custom object', async () => {
-    const graphqlOperation = deleteOneObjectMetadataItemFactory({
-      idToDelete: listingObjectId,
+    const { data } = await deleteOneObjectMetadata({
+      input: {
+        idToDelete: listingObjectId,
+      },
    });

-    const response = await makeGraphqlAPIRequest(graphqlOperation);
-
-    const deleteListingResponse = response.body.data.deleteOneObject;
-
-    expect(deleteListingResponse.id).toBe(listingObjectId);
+    expect(data.deleteOneObject.id).toBe(listingObjectId);
  });
 });
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/successful-create-one-object-metadata.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/successful-create-one-object-metadata.integration-spec.ts
@ -1,6 +1,6 @@
-import { deleteOneObjectMetadataItem } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
-import { getMockCreateObjectInput } from 'test/integration/utils/object-metadata/generate-mock-create-object-metadata-input';
-import { performObjectMetadataCreation } from 'test/integration/utils/object-metadata/perform-object-metadata-creation';
+import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
+import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
+import { getMockCreateObjectInput } from 'test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input';
 import { EachTestingContext } from 'twenty-shared/testing';

 import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
@ -26,13 +26,13 @@ const allTestsUseCases = [...successfulObjectMetadataItemCreateOneUseCase];

 describe('Object metadata creation should succeed', () => {
  it.each(allTestsUseCases)('$title', async ({ context }) => {
-    const response = await performObjectMetadataCreation(
-      getMockCreateObjectInput(context),
-    );
+    const { data } = await createOneObjectMetadata({
+      input: getMockCreateObjectInput(context),
+    });

-    expect(response.body.data.createOneObject.id).toBeDefined();
-    await deleteOneObjectMetadataItem(
-      response.body.data.createOneObject.id,
-    ).catch();
+    expect(data.createOneObject.id).toBeDefined();
+    await deleteOneObjectMetadata({
+      input: { idToDelete: data.createOneObject.id },
+    }).catch();
  });
 });
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util.ts
@ -1,24 +0,0 @@
-import gql from 'graphql-tag';
-
-import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
-
-type CreateOneObjectFactoryParams = {
-  gqlFields: string;
-  input?: { object: Omit<CreateObjectInput, 'workspaceId' | 'dataSourceId'> };
-};
-
-export const createOneObjectMetadataFactory = ({
-  gqlFields,
-  input,
-}: CreateOneObjectFactoryParams) => ({
-  query: gql`
-      mutation CreateOneObjectMetadataItem($input: CreateOneObjectInput!) {
-        createOneObject(input: $input) {
-          ${gqlFields}
-      }
-    }
-    `,
-  variables: {
-    input,
-  },
-});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-query-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-query-factory.util.ts
@ -0,0 +1,25 @@
+import gql from 'graphql-tag';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+
+import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
+
+export type CreateOneObjectFactoryInput = Omit<
+  CreateObjectInput,
+  'workspaceId' | 'dataSourceId'
+>;
+
+export const createOneObjectMetadataQueryFactory = ({
+  input,
+  gqlFields = 'id',
+}: PerformMetadataQueryParams<CreateOneObjectFactoryInput>) => ({
+  query: gql`
+        mutation CreateOneObjectMetadataItem($input: CreateOneObjectInput!) {
+          createOneObject(input: $input) {
+            ${gqlFields}
+        }
+      }
+      `,
+  variables: {
+    input: { object: input },
+  },
+});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util.ts
@ -0,0 +1,29 @@
+import {
+  CreateOneObjectFactoryInput,
+  createOneObjectMetadataQueryFactory,
+} from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-query-factory.util';
+import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';
+
+export const createOneObjectMetadata = async ({
+  input,
+  gqlFields,
+  expectToFail = false,
+}: PerformMetadataQueryParams<CreateOneObjectFactoryInput>) => {
+  const graphqlOperation = createOneObjectMetadataQueryFactory({
+    input,
+    gqlFields,
+  });
+
+  const response = await makeMetadataAPIRequest(graphqlOperation);
+
+  if (expectToFail) {
+    warnIfNoErrorButExpectedToFail({
+      response,
+      errorMessage: 'Object Metadata creation should have failed but did not',
+    });
+  }
+
+  return { data: response.body.data, errors: response.body.errors };
+};
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-test-object-metadata.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/create-test-object-metadata.util.ts
@ -1,32 +0,0 @@
-import {
-  LISTING_NAME_PLURAL,
-  LISTING_NAME_SINGULAR,
-} from 'test/integration/metadata/suites/object-metadata/constants/test-object-names.constant';
-import { createOneObjectMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util';
-import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
-
-const LISTING_OBJECT = {
-  namePlural: LISTING_NAME_PLURAL,
-  nameSingular: LISTING_NAME_SINGULAR,
-  labelPlural: 'Listings',
-  labelSingular: 'Listing',
-  description: 'Listing object',
-  icon: 'IconListNumbers',
-  isLabelSyncedWithName: false,
-};
-
-export const createListingCustomObject = async () => {
-  const createObjectOperation = createOneObjectMetadataFactory({
-    input: { object: LISTING_OBJECT },
-    gqlFields: `
-      id
-      nameSingular
-    `,
-  });
-
-  const response = await makeMetadataAPIRequest(createObjectOperation);
-
-  return {
-    objectMetadataId: response.body.data.createOneObject.id,
-  };
-};
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util.ts
@ -1,20 +0,0 @@
-import gql from 'graphql-tag';
-
-type DeleteOneObjectFactoryParams = {
-  idToDelete: string;
-};
-
-export const deleteOneObjectMetadataItemFactory = ({
-  idToDelete,
-}: DeleteOneObjectFactoryParams) => ({
-  query: gql`
-    mutation DeleteOneObjectMetadataItem($idToDelete: UUID!) {
-      deleteOneObject(input: { id: $idToDelete }) {
-        id
-      }
-    }
-  `,
-  variables: {
-    idToDelete,
-  },
-});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-query-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-query-factory.util.ts
@ -0,0 +1,22 @@
+import gql from 'graphql-tag';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+
+export type DeleteOneObjectFactoryInput = {
+  idToDelete: string;
+};
+
+export const deleteOneObjectMetadataQueryFactory = ({
+  input,
+  gqlFields = 'id',
+}: PerformMetadataQueryParams<DeleteOneObjectFactoryInput>) => ({
+  query: gql`
+        mutation DeleteOneObjectMetadataItem($idToDelete: UUID!) {
+          deleteOneObject(input: { id: $idToDelete }) {
+            ${gqlFields}
+        }
+      }
+      `,
+  variables: {
+    idToDelete: input.idToDelete,
+  },
+});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util.ts
@ -1,12 +1,29 @@
 import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
-import { deleteOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util';
+import {
+  DeleteOneObjectFactoryInput,
+  deleteOneObjectMetadataQueryFactory,
+} from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-query-factory.util';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';

-export const deleteOneObjectMetadataItem = async (
-  objectMetadataItemId: string,
-) => {
-  const graphqlOperation = deleteOneObjectMetadataItemFactory({
-    idToDelete: objectMetadataItemId,
+export const deleteOneObjectMetadata = async ({
+  input,
+  gqlFields,
+  expectToFail = false,
+}: PerformMetadataQueryParams<DeleteOneObjectFactoryInput>) => {
+  const graphqlOperation = deleteOneObjectMetadataQueryFactory({
+    input,
+    gqlFields,
  });

-  await makeGraphqlAPIRequest(graphqlOperation);
+  const response = await makeGraphqlAPIRequest(graphqlOperation);
+
+  if (expectToFail) {
+    warnIfNoErrorButExpectedToFail({
+      response,
+      errorMessage: 'Object Metadata deletion should have failed but did not',
+    });
+  }
+
+  return { data: response.body.data, errors: response.body.errors };
 };
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata-query-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata-query-factory.util.ts
@ -1,17 +1,15 @@
 import gql from 'graphql-tag';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';

-type ObjectsFactoryParams = {
-  gqlFields: string;
-  input: {
-    filter: object;
-    paging: object;
-  };
+export type FindManyObjectMetadataFactoryInput = {
+  filter: object;
+  paging: object;
 };

-export const objectsMetadataFactory = ({
-  gqlFields,
+export const findManyObjectMetadataQueryFactory = ({
+  gqlFields = 'id',
  input,
-}: ObjectsFactoryParams) => ({
+}: PerformMetadataQueryParams<FindManyObjectMetadataFactoryInput>) => ({
  query: gql`
      query ObjectsMetadata($filter: ObjectFilter!, $paging: CursorPaging!) {
        objects(filter: $filter, paging: $paging) {
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata.util.ts
@ -0,0 +1,29 @@
+import {
+  FindManyObjectMetadataFactoryInput,
+  findManyObjectMetadataQueryFactory,
+} from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata-query-factory.util';
+import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';
+
+export const findManyObjectMetadata = async ({
+  input,
+  gqlFields,
+  expectToFail = false,
+}: PerformMetadataQueryParams<FindManyObjectMetadataFactoryInput>) => {
+  const graphqlOperation = findManyObjectMetadataQueryFactory({
+    input,
+    gqlFields,
+  });
+
+  const response = await makeMetadataAPIRequest(graphqlOperation);
+
+  if (expectToFail) {
+    warnIfNoErrorButExpectedToFail({
+      response,
+      errorMessage: 'Object Metadata retrieval should have failed but did not',
+    });
+  }
+
+  return response.body.data.objects.edges.map((edge) => edge.node);
+};
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-objects-metadata-items.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/find-many-objects-metadata-items.util.ts
@ -1,28 +0,0 @@
-import gql from 'graphql-tag';
-import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
-
-export const findManyObjectsMetadataItems = async () => {
-  const query = {
-    query: gql`
-      query ObjectMetadataItems {
-        objects(paging: { first: 1000 }) {
-          edges {
-            node {
-              id
-              nameSingular
-              namePlural
-            }
-          }
-        }
-      }
-    `,
-  };
-
-  const response = await makeMetadataAPIRequest(query);
-
-  return response.body.data.objects.edges.map((edge) => edge.node) as {
-    id: string;
-    nameSingular: string;
-    namePlural: string;
-  }[];
-};
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input.ts
@ -0,0 +1,15 @@
+import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
+
+// TODO would tend to use faker
+export const getMockCreateObjectInput = (
+  overrides?: Partial<Omit<CreateObjectInput, 'workspaceId' | 'dataSourceId'>>,
+) => ({
+  namePlural: 'listingas',
+  nameSingular: 'listinga',
+  labelPlural: 'Listings',
+  labelSingular: 'Listing',
+  description: 'Listing object',
+  icon: 'IconListNumbers',
+  isLabelSyncedWithName: false,
+  ...overrides,
+});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-factory.util.ts
@ -1,28 +0,0 @@
-import gql from 'graphql-tag';
-
-import { UpdateObjectPayload } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
-
-type UpdateOneObjectFactoryParams = {
-  gqlFields: string;
-  input: {
-    idToUpdate: string;
-    updatePayload: UpdateObjectPayload;
-  };
-};
-
-export const updateOneObjectMetadataItemFactory = ({
-  gqlFields,
-  input,
-}: UpdateOneObjectFactoryParams) => ({
-  query: gql`
-      mutation UpdateOneObjectMetadataItem($idToUpdate: UUID!, $updatePayload: UpdateObjectPayload!) {
-        updateOneObject(input: {id: $idToUpdate, update: $updatePayload}) {
-          ${gqlFields}
-        }
-      }
-    `,
-  variables: {
-    idToUpdate: input.idToUpdate,
-    updatePayload: input.updatePayload,
-  },
-});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-query-factory.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-query-factory.util.ts
@ -0,0 +1,26 @@
+import gql from 'graphql-tag';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+
+import { UpdateObjectPayload } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
+
+export type UpdateOneObjectFactoryInput = {
+  idToUpdate: string;
+  updatePayload: UpdateObjectPayload;
+};
+
+export const updateOneObjectMetadataQueryFactory = ({
+  gqlFields = 'id',
+  input,
+}: PerformMetadataQueryParams<UpdateOneObjectFactoryInput>) => ({
+  query: gql`
+        mutation UpdateOneObjectMetadataItem($idToUpdate: UUID!, $updatePayload: UpdateObjectPayload!) {
+            updateOneObject(input: {id: $idToUpdate, update: $updatePayload}) {
+            ${gqlFields}
+        }
+      }
+      `,
+  variables: {
+    idToUpdate: input.idToUpdate,
+    updatePayload: input.updatePayload,
+  },
+});
--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util.ts
@ -0,0 +1,29 @@
+import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
+import {
+  UpdateOneObjectFactoryInput,
+  updateOneObjectMetadataQueryFactory,
+} from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-query-factory.util';
+import { PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';
+
+export const updateOneObjectMetadata = async ({
+  input,
+  gqlFields,
+  expectToFail = false,
+}: PerformMetadataQueryParams<UpdateOneObjectFactoryInput>) => {
+  const graphqlOperation = updateOneObjectMetadataQueryFactory({
+    input,
+    gqlFields,
+  });
+
+  const response = await makeGraphqlAPIRequest(graphqlOperation);
+
+  if (expectToFail) {
+    warnIfNoErrorButExpectedToFail({
+      response,
+      errorMessage: 'Object Metadata update should have failed but did not',
+    });
+  }
+
+  return { data: response.body.data, errors: response.body.errors };
+};