From 5d09bd4b931942efe4ded3b6fae5435bc89ab4b2 Mon Sep 17 00:00:00 2001 From: Paul Rastoin <45004772+prastoin@users.noreply.github.com> Date: Tue, 14 Jan 2025 12:23:37 +0100 Subject: [PATCH] [CI][NITPICK] Remove input `types` invalid syntax (#9596) ## Introduction Unless I'm mistaken neither the `inputs.type` or `inputs.type` syntax exists for `composite actions`. By default it seems like any `Composite action` inputs are considered as `string`. ```yml name: Nx Affected CI inputs: parallel: required: false types: [number] default: 3 tag: required: false types: [string] tasks: required: true types: [string] ``` ## Suggestion To avoid misunderstanding of our composite actions inputs signature I would recommend removing any `type` props but also default any inputs as `strings` ## Misc - Please find related GitHub community discussion https://github.com/orgs/community/discussions/65588 --- .github/workflows/actions/nx-affected/action.yaml | 5 +---- .github/workflows/actions/restore-cache/action.yml | 2 -- .github/workflows/actions/save-cache/action.yml | 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/actions/nx-affected/action.yaml b/.github/workflows/actions/nx-affected/action.yaml index af5ba29aa..7c2cdcfe7 100644 --- a/.github/workflows/actions/nx-affected/action.yaml +++ b/.github/workflows/actions/nx-affected/action.yaml @@ -2,14 +2,11 @@ name: Nx Affected CI inputs: parallel: required: false - types: [number] - default: 3 + default: '3' tag: required: false - types: [string] tasks: required: true - types: [string] runs: using: "composite" diff --git a/.github/workflows/actions/restore-cache/action.yml b/.github/workflows/actions/restore-cache/action.yml index ae4a2cc0a..06be845c9 100644 --- a/.github/workflows/actions/restore-cache/action.yml +++ b/.github/workflows/actions/restore-cache/action.yml @@ -3,10 +3,8 @@ inputs: key: required: true description: Prefix to the cache key - type: string additional-paths: required: false - type: string outputs: cache-primary-key: description: actions/cache/restore cache-primary-key outputs proxy diff --git a/.github/workflows/actions/save-cache/action.yml b/.github/workflows/actions/save-cache/action.yml index a159b6a48..b51a5d478 100644 --- a/.github/workflows/actions/save-cache/action.yml +++ b/.github/workflows/actions/save-cache/action.yml @@ -3,10 +3,8 @@ inputs: key: required: true description: Primary key to the cache, should be retrieved from `cache-restore` composite action outputs. - type: string additional-paths: required: false - type: string runs: using: "composite"