From 5e261783dacdbeae2680145acdd06b9c11c11e56 Mon Sep 17 00:00:00 2001
From: Charles Bochet <charles@twenty.com>
Date: Fri, 1 Mar 2024 08:58:19 +0100
Subject: [PATCH] Fix default value being set to null when not provider to
 fieldMetadataUpdate

---
 .../field-metadata/field-metadata.service.ts         | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts b/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts
index 16b5d6d8e..ce17833e8 100644
--- a/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts
+++ b/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts
@@ -235,10 +235,14 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
 
     const updatedFieldMetadata = await super.updateOne(id, {
       ...updatableFieldInput,
-      defaultValue: updatableFieldInput.defaultValue
-        ? // Todo: we need to rework DefaultValue typing and format to be simpler, there is no need to have this complexity
-          { value: updatableFieldInput.defaultValue as unknown as string }
-        : null,
+      defaultValue:
+        // Todo: we need to handle default value for all field types. Right now we are only allowing update for SELECt
+        existingFieldMetadata.type !== FieldMetadataType.SELECT
+          ? existingFieldMetadata.defaultValue
+          : updatableFieldInput.defaultValue
+            ? // Todo: we need to rework DefaultValue typing and format to be simpler, there is no need to have this complexity
+              { value: updatableFieldInput.defaultValue as unknown as string }
+            : null,
       // If the name is updated, the targetColumnMap should be updated as well
       targetColumnMap: updatableFieldInput.name
         ? generateTargetColumnMap(