refacto(twenty-front): improve DropdownMenuHeader api (#10961)

This commit is contained in:
Antoine Moreaux
2025-03-18 08:19:22 +01:00
committed by GitHub
parent 03f4f73da4
commit 606098fef6
29 changed files with 194 additions and 148 deletions

View File

@ -34,6 +34,7 @@ import { viewPickerSelectedIconComponentState } from '@/views/view-picker/states
import { viewPickerTypeComponentState } from '@/views/view-picker/states/viewPickerTypeComponentState';
import { useMemo, useState } from 'react';
import { useLingui } from '@lingui/react/macro';
import { DropdownMenuHeaderLeftComponent } from '@/ui/layout/dropdown/components/DropdownMenuHeader/internal/DropdownMenuHeaderLeftComponent';
const StyledNoKanbanFieldAvailableContainer = styled.div`
color: ${({ theme }) => theme.font.color.light};
@ -130,7 +131,11 @@ export const ViewPickerContentCreateMode = () => {
return (
<>
<DropdownMenuHeader StartIcon={IconX} onStartIconClick={handleClose}>
<DropdownMenuHeader
StartComponent={
<DropdownMenuHeaderLeftComponent onClick={handleClose} Icon={IconX} />
}
>
{t`Create view`}
</DropdownMenuHeader>
<DropdownMenuSeparator />

View File

@ -21,6 +21,7 @@ import { viewPickerInputNameComponentState } from '@/views/view-picker/states/vi
import { viewPickerIsDirtyComponentState } from '@/views/view-picker/states/viewPickerIsDirtyComponentState';
import { viewPickerIsPersistingComponentState } from '@/views/view-picker/states/viewPickerIsPersistingComponentState';
import { viewPickerSelectedIconComponentState } from '@/views/view-picker/states/viewPickerSelectedIconComponentState';
import { DropdownMenuHeaderLeftComponent } from '@/ui/layout/dropdown/components/DropdownMenuHeader/internal/DropdownMenuHeaderLeftComponent';
export const ViewPickerContentEditMode = () => {
const { setViewPickerMode } = useViewPickerMode();
@ -68,8 +69,12 @@ export const ViewPickerContentEditMode = () => {
return (
<>
<DropdownMenuHeader
StartIcon={IconChevronLeft}
onStartIconClick={handleClose}
StartComponent={
<DropdownMenuHeaderLeftComponent
onClick={handleClose}
Icon={IconChevronLeft}
/>
}
>
Edit view
</DropdownMenuHeader>