admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: fix Select field preview (#4507)

Browse Source 
* fix: fix Select field preview

Closes #4084

* fix: fix field preview utils tests
This commit is contained in:
Thaïs
2024-03-25 16:37:41 +01:00
committed by GitHub
parent 2ae59a801f
commit 61e5d5bcb9
8 changed files with 33 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-front/src/modules/settings/data-model/utils/__tests__/getFieldDefaultPreviewValue.test.ts
View File

@ -37,7 +37,7 @@ describe('getFieldDefaultPreviewValue', () => {
});
// Then
expect(result).toEqual(selectOptions[1]);
expect(result).toEqual(selectOptions[1].value);
});
it('returns the first select option if no default option was found', () => {
@ -46,7 +46,7 @@ describe('getFieldDefaultPreviewValue', () => {
const fieldMetadataItem = mockedCompanyObjectMetadataItem.fields.find(
({ name }) => name === 'industry',
)!;
const selectOptions = [
const selectOptions: SettingsObjectFieldSelectFormValues = [
{
color: 'purple' as const,
label: '🏭 Industry',
@ -67,7 +67,7 @@ describe('getFieldDefaultPreviewValue', () => {
});
// Then
expect(result).toEqual(selectOptions[0]);
expect(result).toEqual(selectOptions[0].value);
});
});

2
packages/twenty-front/src/modules/settings/data-model/utils/__tests__/getFieldPreviewValueFromRecord.test.ts
View File

@ -42,7 +42,7 @@ describe('getFieldPreviewValueFromRecord', () => {
});
// Then
expect(result).toEqual(selectOptions[2]);
expect(result).toEqual(selectOptions[2].value);
});
it('returns undefined if the select option was not found', () => {

4
packages/twenty-front/src/modules/settings/data-model/utils/getFieldDefaultPreviewValue.ts
View File

@ -26,7 +26,9 @@ export const getFieldDefaultPreviewValue = ({
fieldMetadataItem.type === FieldMetadataType.Select &&
isDefined(selectOptions)
) {
return selectOptions.find(({ isDefault }) => isDefault) || selectOptions[0];
const defaultSelectOption =
selectOptions.find(({ isDefault }) => isDefault) || selectOptions[0];
return defaultSelectOption.value;
}
// Relation field

2
packages/twenty-front/src/modules/settings/data-model/utils/getFieldPreviewValueFromRecord.ts
View File

@ -18,7 +18,7 @@ export const getFieldPreviewValueFromRecord = ({
if (fieldMetadataItem.type === FieldMetadataType.Select) {
return selectOptions?.find(
(selectOption) => selectOption.value === recordFieldValue,
);
)?.value;
}
// Relation fields (to many)