From 64500d07d33360875d846c387aaa22218106b7b2 Mon Sep 17 00:00:00 2001 From: Nathaniel Brough Date: Tue, 3 Dec 2024 00:03:49 +1000 Subject: [PATCH] Use builtin number validation (#8819) The regex approach doesn't work great for the many different number formats. Even a simple decimal failed e.g. '1.1' was considered invalid. I've switched this over to use javascripts builtin conversion and validation. This now supports other formats e.g. '-1.0e15' would now be considered valid. Closes: #8820 --- .../utils/getSpreadSheetFieldValidationDefinitions.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/spreadsheet-import/utils/getSpreadSheetFieldValidationDefinitions.ts b/packages/twenty-front/src/modules/object-record/spreadsheet-import/utils/getSpreadSheetFieldValidationDefinitions.ts index b32f814a7..3b63baabc 100644 --- a/packages/twenty-front/src/modules/object-record/spreadsheet-import/utils/getSpreadSheetFieldValidationDefinitions.ts +++ b/packages/twenty-front/src/modules/object-record/spreadsheet-import/utils/getSpreadSheetFieldValidationDefinitions.ts @@ -33,9 +33,9 @@ export const getSpreadSheetFieldValidationDefinitions = ( case FieldMetadataType.Number: return [ { - rule: 'regex', - value: '^\\d+$', - errorMessage: fieldName + ' must be a number', + rule: 'function', + isValid: (value: string) => !isNaN(+value), + errorMessage: fieldName + ' is not valid', level: 'error', }, ];