Fix favorites (#3138)

* WIP

* Finished cleaning favorites create, update, delete on record show page

* Fixed context menu favorite

* Fixed relation field bug

* Fix from review

* Review

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/object-record/graphql/optimistic-effect-definition/getRecordOptimisticEffectDefinition.ts

@@ -61,7 +61,7 @@ export const getRecordOptimisticEffectDefinition = ({
         }
       }
 
-      if (deletedRecordIds) {
+      if (isNonEmptyArray(deletedRecordIds)) {
         draft.edges = draft.edges.filter(
           (edge) => !deletedRecordIds.includes(edge.node.id),
         );