Migrate view field to new data model - Part 2 (#2270)

* Migrate view field to new data model

* Migrate view fields to new model

front/src/modules/metadata/components/MetadataObjectNavItems.tsx

@@ -1,52 +1,30 @@
 import { useNavigate } from 'react-router-dom';
 
-import { IconArchive } from '@/ui/display/icon';
 import { IconBuildingSkyscraper } from '@/ui/display/icon';
-import { Button } from '@/ui/input/button/components/Button';
-import { IconButton } from '@/ui/input/button/components/IconButton';
 import NavItem from '@/ui/navigation/navbar/components/NavItem';
 import { capitalize } from '~/utils/string/capitalize';
 
-import { useCreateNewTempsCustomObject } from '../hooks/useCreateNewTempCustomObject';
-import { useDeleteOneMetadataObject } from '../hooks/useDeleteOneMetadataObject';
 import { useFindManyMetadataObjects } from '../hooks/useFindManyMetadataObjects';
 
 export const MetadataObjectNavItems = () => {
   const { metadataObjects } = useFindManyMetadataObjects();
 
-  const createNewTempCustomObject = useCreateNewTempsCustomObject();
-
-  const { deleteOneMetadataObject } = useDeleteOneMetadataObject();
-
   const navigate = useNavigate();
 
   return (
     <>
-      <Button
-        title="+ Create new object"
-        variant="secondary"
-        onClick={createNewTempCustomObject}
-      />
       {metadataObjects
         .filter((metadataObject) => !!metadataObject.isActive)
         .map((metadataObject) => (
-          <div style={{ display: 'flex', flexDirection: 'row', width: '60%' }}>
-            <IconButton
-              Icon={IconArchive}
-              onClick={() => {
-                deleteOneMetadataObject(metadataObject.id);
-              }}
-            />
-            <NavItem
-              key={metadataObject.id}
-              label={capitalize(metadataObject.namePlural)}
-              to={`/objects/${metadataObject.namePlural}`}
-              Icon={IconBuildingSkyscraper}
-              onClick={() => {
-                navigate(`/objects/${metadataObject.namePlural}`);
-              }}
-            />
-          </div>
+          <NavItem
+            key={metadataObject.id}
+            label={capitalize(metadataObject.namePlural)}
+            to={`/objects/${metadataObject.namePlural}`}
+            Icon={IconBuildingSkyscraper}
+            onClick={() => {
+              navigate(`/objects/${metadataObject.namePlural}`);
+            }}
+          />
         ))}
     </>
   );

front/src/modules/metadata/components/ObjectShowPage.tsx

@@ -128,7 +128,7 @@ export const ObjectShowPage = () => {
                           fieldDefinition:
                             formatMetadataFieldAsColumnDefinition({
                               field: metadataField,
-                              index: index,
+                              position: index,
                               metadataObject: foundMetadataObject,
                             }),
                           useUpdateEntityMutation: useUpdateOneObjectMutation,

front/src/modules/metadata/components/ObjectTable.tsx

@@ -1,15 +1,9 @@
 import styled from '@emotion/styled';
-import { useRecoilCallback } from 'recoil';
 
 import { DataTable } from '@/ui/data/data-table/components/DataTable';
 import { TableContext } from '@/ui/data/data-table/contexts/TableContext';
 import { TableOptionsDropdown } from '@/ui/data/data-table/options/components/TableOptionsDropdown';
-import { tableColumnsScopedState } from '@/ui/data/data-table/states/tableColumnsScopedState';
-import { ColumnDefinition } from '@/ui/data/data-table/types/ColumnDefinition';
-import { FieldMetadata } from '@/ui/data/field/types/FieldMetadata';
 import { ViewBar } from '@/views/components/ViewBar';
-import { useViewFields } from '@/views/hooks/internal/useViewFields';
-import { useView } from '@/views/hooks/useView';
 import { ViewScope } from '@/views/scopes/ViewScope';
 
 import { useUpdateOneObject } from '../hooks/useUpdateOneObject';
@@ -37,9 +31,6 @@ export const ObjectTable = ({ objectNamePlural }: ObjectTableProps) => {
 
   const viewScopeId = objectNamePlural ?? '';
 
-  const { persistViewFields } = useViewFields(viewScopeId);
-  const { setCurrentViewFields } = useView({ viewScopeId: viewScopeId });
-
   const updateEntity = ({
     variables,
   }: {
@@ -56,27 +47,12 @@ export const ObjectTable = ({ objectNamePlural }: ObjectTableProps) => {
     });
   };
 
-  const updateTableColumns = useRecoilCallback(
-    ({ set, snapshot }) =>
-      (viewFields: ColumnDefinition<FieldMetadata>[]) => {
-        set(tableColumnsScopedState(viewScopeId), viewFields);
-      },
-  );
-
   return (
-    <ViewScope
-      viewScopeId={viewScopeId}
-      onViewFieldsChange={(viewFields) => {
-        // updateTableColumns(viewFields);
-      }}
-    >
+    <ViewScope viewScopeId={viewScopeId} onViewFieldsChange={() => {}}>
       <StyledContainer>
         <TableContext.Provider
           value={{
-            onColumnsChange: (columns) => {
-              // setCurrentViewFields?.(columns);
-              // persistViewFields(columns);
-            },
+            onColumnsChange: () => {},
           }}
         >
           <ViewBar

front/src/modules/metadata/components/ObjectTableEffect.tsx

@@ -3,13 +3,11 @@ import { useSetRecoilState } from 'recoil';
 
 import { availableTableColumnsScopedState } from '@/ui/data/data-table/states/availableTableColumnsScopedState';
 import { useView } from '@/views/hooks/useView';
-import { ViewType } from '~/generated/graphql';
+import { ViewType } from '@/views/types/ViewType';
 
 import { useMetadataObjectInContext } from '../hooks/useMetadataObjectInContext';
 
 export const ObjectTableEffect = () => {
-  console.log('ObjectTableEffect');
-
   const {
     setAvailableSorts,
     setAvailableFilters,