Migrate view field to new data model - Part 2 (#2270)

* Migrate view field to new data model

* Migrate view fields to new model

front/src/testing/graphqlMocks.ts

@@ -20,8 +20,6 @@ import { SEARCH_USER_QUERY } from '@/search/graphql/queries/searchUserQuery';
 import { GET_API_KEY } from '@/settings/developers/graphql/queries/getApiKey';
 import { GET_API_KEYS } from '@/settings/developers/graphql/queries/getApiKeys';
 import { GET_CURRENT_USER } from '@/users/graphql/queries/getCurrentUser';
-import { GET_VIEW_FIELDS } from '@/views/graphql/queries/getViewFields';
-import { GET_VIEWS } from '@/views/graphql/queries/getViews';
 import {
   GetCompaniesQuery,
   GetPeopleQuery,
@@ -30,23 +28,12 @@ import {
   SearchCompanyQuery,
   SearchPeopleQuery,
   SearchUserQuery,
-  ViewType,
 } from '~/generated/graphql';
 import { mockedApiKeys } from '~/testing/mock-data/api-keys';
 
 import { mockedActivities, mockedTasks } from './mock-data/activities';
-import {
-  mockedCompaniesData,
-  mockedCompanyBoardCardFields,
-  mockedCompanyBoardViews,
-  mockedCompanyTableColumns,
-  mockedCompanyTableViews,
-} from './mock-data/companies';
-import {
-  mockedPeopleData,
-  mockedPersonTableColumns,
-  mockedPersonTableViews,
-} from './mock-data/people';
+import { mockedCompaniesData } from './mock-data/companies';
+import { mockedPeopleData } from './mock-data/people';
 import { mockedPipelineProgressData } from './mock-data/pipeline-progress';
 import { mockedPipelinesData } from './mock-data/pipelines';
 import { mockedUsersData } from './mock-data/users';
@@ -244,43 +231,7 @@ export const graphqlMocks = [
       }),
     );
   }),
-  graphql.query(getOperationName(GET_VIEWS) ?? '', (req, res, ctx) => {
-    const {
-      where: {
-        objectId: { equals: objectId },
-        type: { equals: type },
-      },
-    } = req.variables;
 
-    return res(
-      ctx.data({
-        views:
-          objectId === 'person'
-            ? mockedPersonTableViews
-            : type === ViewType.Table
-            ? mockedCompanyTableViews
-            : mockedCompanyBoardViews,
-      }),
-    );
-  }),
-  graphql.query(getOperationName(GET_VIEW_FIELDS) ?? '', (req, res, ctx) => {
-    const {
-      where: {
-        viewId: { equals: viewId },
-      },
-    } = req.variables;
-
-    return res(
-      ctx.data({
-        viewFields:
-          viewId === mockedCompanyBoardViews[0].id
-            ? mockedCompanyBoardCardFields
-            : viewId === mockedCompanyTableViews[0].id
-            ? mockedCompanyTableColumns
-            : mockedPersonTableColumns,
-      }),
-    );
-  }),
   graphql.query(getOperationName(GET_API_KEY) ?? '', (req, res, ctx) => {
     return res(
       ctx.data({

front/src/testing/mock-data/companies.ts

@@ -1,13 +1,4 @@
-import { companiesAvailableFieldDefinitions } from '@/companies/constants/companiesAvailableFieldDefinitions';
-import { pipelineAvailableFieldDefinitions } from '@/pipeline/constants/pipelineAvailableFieldDefinitions';
-import {
-  Company,
-  Favorite,
-  User,
-  View,
-  ViewField,
-  ViewType,
-} from '~/generated/graphql';
+import { Company, Favorite, User } from '~/generated/graphql';
 
 type MockedCompany = Pick<
   Company,
@@ -158,49 +149,3 @@ export const mockedCompaniesData: Array<MockedCompany> = [
     __typename: 'Company',
   },
 ];
-
-export const mockedCompanyBoardViews: View[] = [
-  {
-    __typename: 'View',
-    id: '1e8f93e6-ae0e-43ba-8121-a7a763286351',
-    name: 'All opportunities',
-    objectId: 'company',
-    type: ViewType.Pipeline,
-  },
-];
-
-export const mockedCompanyBoardCardFields =
-  pipelineAvailableFieldDefinitions.map<Omit<ViewField, 'view'>>(
-    (viewFieldDefinition) => ({
-      __typename: 'ViewField',
-      name: viewFieldDefinition.name,
-      index: viewFieldDefinition.index,
-      isVisible: true,
-      key: viewFieldDefinition.key,
-      objectId: 'company',
-      viewId: mockedCompanyBoardViews[0].id,
-    }),
-  );
-
-export const mockedCompanyTableViews: View[] = [
-  {
-    __typename: 'View',
-    id: 'e6a2232d-ca6c-42df-b78e-ca0343f545a9',
-    name: 'All companies',
-    objectId: 'company',
-    type: ViewType.Table,
-  },
-];
-
-export const mockedCompanyTableColumns = companiesAvailableFieldDefinitions.map<
-  Omit<ViewField, 'view'>
->((viewFieldDefinition) => ({
-  __typename: 'ViewField',
-  name: viewFieldDefinition.name,
-  index: viewFieldDefinition.index,
-  isVisible: true,
-  key: viewFieldDefinition.key,
-  objectId: 'company',
-  size: viewFieldDefinition.size,
-  viewId: mockedCompanyTableViews[0].id,
-}));

front/src/testing/mock-data/people.ts

@@ -1,11 +1,4 @@
-import { peopleAvailableFieldDefinitions } from '@/people/constants/peopleAvailableFieldDefinitions';
-import {
-  Company,
-  Person,
-  View,
-  ViewField,
-  ViewType,
-} from '~/generated/graphql';
+import { Company, Person } from '~/generated/graphql';
 
 type RequiredAndNotNull<T> = {
   [P in keyof T]-?: Exclude<T[P], null | undefined>;
@@ -128,33 +121,3 @@ export const mockedPeopleData: MockedPerson[] = [
     city: 'Paris',
   },
 ];
-
-export const mockedPersonTableViews: View[] = [
-  {
-    __typename: 'View',
-    id: 'afd7737a-bf1d-41a3-8863-c277b56a657b',
-    name: 'All people',
-    objectId: 'person',
-    type: ViewType.Table,
-  },
-  {
-    __typename: 'View',
-    id: '89bb825c-171e-4bcc-9cf7-43448d6fb230a',
-    name: 'View example 1',
-    objectId: 'person',
-    type: ViewType.Table,
-  },
-];
-
-export const mockedPersonTableColumns = peopleAvailableFieldDefinitions.map<
-  Omit<ViewField, 'view'>
->((viewFieldDefinition) => ({
-  __typename: 'ViewField',
-  name: viewFieldDefinition.name,
-  index: viewFieldDefinition.index,
-  isVisible: true,
-  key: viewFieldDefinition.key,
-  objectId: 'person',
-  size: viewFieldDefinition.size,
-  viewId: mockedPersonTableViews[0].id,
-}));

front/src/testing/mock-data/pipelines.ts

@@ -10,7 +10,7 @@ type MockedPipeline = Pick<
   'id' | 'name' | 'pipelineProgressableType' | '__typename'
 > & {
   pipelineStages: Array<
-    Pick<PipelineStage, 'id' | 'name' | 'color' | 'index' | '__typename'> & {
+    Pick<PipelineStage, 'id' | 'name' | 'color' | 'position' | '__typename'> & {
       pipelineProgresses: Array<
         Pick<
           PipelineProgress,
@@ -31,7 +31,7 @@ export const mockedPipelinesData: Array<MockedPipeline> = [
         id: 'fe256b39-3ec3-4fe3-8998-b76aa0bfb600',
         name: 'New',
         color: 'red',
-        index: 0,
+        position: 0,
         pipelineProgresses: [
           {
             id: 'fe256b39-3ec3-4fe7-8998-b76aa0bfb600',
@@ -54,7 +54,7 @@ export const mockedPipelinesData: Array<MockedPipeline> = [
         id: 'fe256b39-3ec3-4fe4-8998-b76aa0bfb600',
         name: 'Screening',
         color: 'purple',
-        index: 1,
+        position: 1,
         pipelineProgresses: [],
         __typename: 'PipelineStage',
       },
@@ -62,7 +62,7 @@ export const mockedPipelinesData: Array<MockedPipeline> = [
         id: 'fe256b39-3ec3-4fe5-8998-b76aa0bfb600',
         name: 'Meeting',
         color: 'sky',
-        index: 2,
+        position: 2,
         pipelineProgresses: [],
         __typename: 'PipelineStage',
       },
@@ -70,7 +70,7 @@ export const mockedPipelinesData: Array<MockedPipeline> = [
         id: 'fe256b39-3ec3-4fe6-8998-b76aa0bfb600',
         name: 'Proposal',
         color: 'turquoise',
-        index: 3,
+        position: 3,
         pipelineProgresses: [],
         __typename: 'PipelineStage',
       },
@@ -78,7 +78,7 @@ export const mockedPipelinesData: Array<MockedPipeline> = [
         id: 'fe256b39-3ec3-4fe7-8998-b76aa0bfb600',
         name: 'Customer',
         color: 'yellow',
-        index: 4,
+        position: 4,
         pipelineProgresses: [],
         __typename: 'PipelineStage',
       },