From 6a224241ec8179ab8db99ee6ed79a3620338a208 Mon Sep 17 00:00:00 2001 From: Marty <91310557+real-marty@users.noreply.github.com> Date: Mon, 16 Jun 2025 16:04:21 +0200 Subject: [PATCH] Fix inconsistent volume path in docker-compose.yml (#12479) *Title:* Align volume mount path for `server-local-data` in `docker-compose.yml` **Description:** This pull request resolves a configuration inconsistency in the `docker-compose.yml` file related to the `server-local-data` volume used by the `server` and `worker` services. ### Background The `server` and `worker` services are both configured to use a shared volume named `server-local-data`. However, the volume mount paths differ: * The `server` service uses a hardcoded mount path: ```yaml - server-local-data:/app/packages/twenty-server/.local-storage ``` * The `worker` service uses a path that supports an environment variable override: ```yaml - server-local-data:/app/packages/twenty-server/${STORAGE_LOCAL_PATH:-.local-storage} ``` This discrepancy can result in the two services referencing different filesystem locations, especially when `STORAGE_LOCAL_PATH` is set. This may lead to runtime errors or unexpected behavior when accessing local storage. ### Proposed Change This PR standardizes the volume mount path in the `worker` service to use the same environment variable-based path as the `server` service: ```yaml - server-local-data:/app/packages/twenty-server/.local-storage ``` ### Rationale * Ensures consistent and predictable volume mount behavior across services. * Prevents potential data inconsistencies or access issues arising from differing mount points. ### Impact * No breaking changes expected if `STORAGE_LOCAL_PATH` is not defined. * Services will now operate on the same volume path, whether or not the environment variable is set. --- packages/twenty-docker/docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/twenty-docker/docker-compose.yml b/packages/twenty-docker/docker-compose.yml index 313b02f06..617ce3c67 100644 --- a/packages/twenty-docker/docker-compose.yml +++ b/packages/twenty-docker/docker-compose.yml @@ -56,7 +56,7 @@ services: worker: image: twentycrm/twenty:${TAG:-latest} volumes: - - server-local-data:/app/packages/twenty-server/${STORAGE_LOCAL_PATH:-.local-storage} + - server-local-data:/app/packages/twenty-server/.local-storage command: ["yarn", "worker:prod"] environment: PG_DATABASE_URL: postgres://${PG_DATABASE_USER:-postgres}:${PG_DATABASE_PASSWORD:-postgres}@${PG_DATABASE_HOST:-db}:${PG_DATABASE_PORT:-5432}/default