From 6a40ec604c1227f1848737404bd42582c5878564 Mon Sep 17 00:00:00 2001
From: Thomas Trompette <thomas.trompette@sfr.fr>
Date: Thu, 15 May 2025 13:24:57 +0200
Subject: [PATCH] Validate existing fields on creation (#12057)

Fixes https://github.com/twentyhq/twenty/issues/12040

When fields are deleted but still used in workflows we do not update
create record action settings.
It breaks all following workflow execution and the user cannot update
the settings anymore.

This PR fixes the bug by filtering on existing fields.

Next step will be to clean settings on field deletion. Adding it to fast
follows.

Also lowering throttle limit because some infinite loops are not
catched.
---
 .../engine/core-modules/twenty-config/config-variables.ts | 2 +-
 .../record-crud/create-record.workflow-action.ts          | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
index 6a2437d95..8ae97de52 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
@@ -987,7 +987,7 @@ export class ConfigVariables {
     type: ConfigVariableType.NUMBER,
   })
   @CastToPositiveNumber()
-  WORKFLOW_EXEC_THROTTLE_LIMIT = 500;
+  WORKFLOW_EXEC_THROTTLE_LIMIT = 100;
 
   @ConfigVariablesMetadata({
     group: ConfigVariablesGroup.RateLimiting,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/create-record.workflow-action.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/create-record.workflow-action.ts
index d14bab433..1f18a2bc5 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/create-record.workflow-action.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/create-record.workflow-action.ts
@@ -105,9 +105,15 @@ export class CreateRecordWorkflowAction implements WorkflowExecutor {
         workspaceId,
       );
 
+    const validObjectRecord = Object.fromEntries(
+      Object.entries(workflowActionInput.objectRecord).filter(
+        ([key]) => objectMetadataItemWithFieldsMaps.fieldsByName[key],
+      ),
+    );
+
     const transformedObjectRecord =
       await this.recordInputTransformerService.process({
-        recordInput: workflowActionInput.objectRecord,
+        recordInput: validObjectRecord,
         objectMetadataMapItem: objectMetadataItemWithFieldsMaps,
       });