admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: value changes every render (#2115)

Browse Source 
* fix: value changes every render

* Fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Rustam M
2023-10-21 14:49:50 +05:00
committed by GitHub
parent 159d2978d0
commit 6d8effabbf
1 changed files with 30 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
front/src/modules/activities/editable-fields/components/ActivityAssigneeEditableField.tsx
View File

@ -1,3 +1,5 @@
import React, { useMemo } from 'react';
import { FieldContext } from '@/ui/data/field/contexts/FieldContext'; import { FieldContext } from '@/ui/data/field/contexts/FieldContext';
import { FieldDefinition } from '@/ui/data/field/types/FieldDefinition'; import { FieldDefinition } from '@/ui/data/field/types/FieldDefinition';
import { FieldRelationMetadata } from '@/ui/data/field/types/FieldMetadata'; import { FieldRelationMetadata } from '@/ui/data/field/types/FieldMetadata';
@ -16,9 +18,8 @@ type ActivityAssigneeEditableFieldProps = {
export const ActivityAssigneeEditableField = ({ export const ActivityAssigneeEditableField = ({
activity, activity,
}: ActivityAssigneeEditableFieldProps) => { }: ActivityAssigneeEditableFieldProps) => {
return ( const value = useMemo(
<FieldContext.Provider () => ({
value={{
entityId: activity.id, entityId: activity.id,
recoilScopeId: 'assignee', recoilScopeId: 'assignee',
fieldDefinition: { fieldDefinition: {
@ -40,8 +41,12 @@ export const ActivityAssigneeEditableField = ({
} satisfies FieldDefinition<FieldRelationMetadata>, } satisfies FieldDefinition<FieldRelationMetadata>,
useUpdateEntityMutation: useUpdateActivityMutation, useUpdateEntityMutation: useUpdateActivityMutation,
hotkeyScope: InlineCellHotkeyScope.InlineCell, hotkeyScope: InlineCellHotkeyScope.InlineCell,
}} }),
> [activity.id],
);
return (
<FieldContext.Provider value={value}>
<InlineCell /> <InlineCell />
</FieldContext.Provider> </FieldContext.Provider>
); );