Fix From Many relation for deleted notes crashing (#11117)

In this PR, I'm: 
- fixing the root cause (we should not try to render a RecordChip if the
record is not defined in RelationFromMany Display)
- fixing related typing issues
- we won't be able to catch the issue from TS perspective as
ObjectRecord is a Record of string, any
This commit is contained in:
Charles Bochet
2025-03-24 13:29:44 +01:00
committed by GitHub
parent 3ec72a2bca
commit 6e7d2db58f
5 changed files with 30 additions and 18 deletions

View File

@ -22,6 +22,7 @@ export const useRecordChipData = ({
const identifierChipGenerator =
identifierChipGeneratorPerObject[objectNameSingular];
if (isDefined(identifierChipGenerator)) {
return {
recordChipData: identifierChipGenerator(record),

View File

@ -48,13 +48,17 @@ export const RelationFromManyFieldDisplay = () => {
return (
<ExpandableList isChipCountDisplayed={isFocused}>
{fieldValue.filter(isDefined).map((record) => (
<RecordChip
key={record.id}
objectNameSingular={objectNameSingular}
record={record[relationFieldName]}
/>
))}
{fieldValue
.map((record) =>
isDefined(record) && isDefined(record[relationFieldName]) ? (
<RecordChip
key={record.id}
objectNameSingular={objectNameSingular}
record={record[relationFieldName]}
/>
) : undefined,
)
.filter(isDefined)}
</ExpandableList>
);
} else if (isRelationFromActivityTargets) {