admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[permissions] Add conditional permission gate on billing's checkoutSession (#10387)

Browse Source 
Following a conversation with @etiennejouan and @martmull, we are adding
a permission gate on billing resolver's checkoutSession, which should
only be accessible to entitled users or at workspace creation (when
there are no roles yet), when the subscription is incomplete
This commit is contained in:
Marie
2025-02-21 15:01:36 +01:00
committed by GitHub
parent 0571eb2cf6
commit 6fb81e757b
6 changed files with 121 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts
View File

@ -27,13 +27,6 @@ export class OnboardingService {
private readonly userVarsService: UserVarsService<OnboardingKeyValueTypeMap>,
) {}
private async isSubscriptionIncompleteOnboardingStatus(workspace: Workspace) {
const hasAnySubscription =
await this.billingService.hasWorkspaceAnySubscription(workspace.id);
return !hasAnySubscription;
}
private isWorkspaceActivationPending(workspace: Workspace) {
return (
workspace.activationStatus === WorkspaceActivationStatus.PENDING_CREATION
@ -41,7 +34,11 @@ export class OnboardingService {
}
async getOnboardingStatus(user: User, workspace: Workspace) {
if (await this.isSubscriptionIncompleteOnboardingStatus(workspace)) {
if (
await this.billingService.isSubscriptionIncompleteOnboardingStatus(
workspace.id,
)
) {
return OnboardingStatus.PLAN_REQUIRED;
}