Use search instead of findMany in relation pickers (#7798)

First step of #https://github.com/twentyhq/twenty/issues/3298.
Here we update the search endpoint to allow for a filter argument, which
we currently use in the relation pickers to restrict or exclude ids from
search.
In a future PR we will try to simplify the search logic in the FE

packages/twenty-front/src/modules/object-record/hooks/useSearchRecords.ts

@@ -13,10 +13,11 @@ import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
 import { useQuery, WatchQueryFetchPolicy } from '@apollo/client';
 import { useMemo } from 'react';
 import { useRecoilValue } from 'recoil';
+import { isDefined } from '~/utils/isDefined';
 import { logError } from '~/utils/logError';
 
 export type UseSearchRecordsParams = ObjectMetadataItemIdentifier &
-  RecordGqlOperationVariables & {
+  Pick<RecordGqlOperationVariables, 'filter' | 'limit'> & {
     onError?: (error?: Error) => void;
     skip?: boolean;
     recordGqlFields?: RecordGqlOperationGqlRecordFields;
@@ -29,6 +30,7 @@ export const useSearchRecords = <T extends ObjectRecord = ObjectRecord>({
   searchInput,
   limit,
   skip,
+  filter,
   recordGqlFields,
   fetchPolicy,
 }: UseSearchRecordsParams) => {
@@ -45,10 +47,14 @@ export const useSearchRecords = <T extends ObjectRecord = ObjectRecord>({
   const { data, loading, error, previousData } =
     useQuery<RecordGqlOperationSearchResult>(searchRecordsQuery, {
       skip:
-        skip || !objectMetadataItem || !currentWorkspaceMember || !searchInput,
+        skip ||
+        !objectMetadataItem ||
+        !currentWorkspaceMember ||
+        !isDefined(searchInput),
       variables: {
         search: searchInput,
         limit: limit,
+        filter: filter,
       },
       fetchPolicy: fetchPolicy,
       onError: (error) => {

packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/RelationFromManyFieldInput.tsx

@@ -1,6 +1,5 @@
 import { useContext } from 'react';
 
-import { ObjectMetadataItemsRelationPickerEffect } from '@/object-metadata/components/ObjectMetadataItemsRelationPickerEffect';
 import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { FieldContext } from '@/object-record/record-field/contexts/FieldContext';
 import { RelationFromManyFieldInputMultiRecordsEffect } from '@/object-record/record-field/meta-types/input/components/RelationFromManyFieldInputMultiRecordsEffect';
@@ -54,7 +53,6 @@ export const RelationFromManyFieldInput = ({
   return (
     <>
       <RelationPickerScope relationPickerScopeId={relationPickerScopeId}>
-        <ObjectMetadataItemsRelationPickerEffect />
         <RelationFromManyFieldInputMultiRecordsEffect />
         <MultiRecordSelect
           onSubmit={handleSubmit}

packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx

@@ -4,7 +4,6 @@ import { useCallback, useContext } from 'react';
 import { useRecoilValue } from 'recoil';
 import { IconForbid, IconPencil, IconPlus } from 'twenty-ui';
 
-import { ObjectMetadataItemsRelationPickerEffect } from '@/object-metadata/components/ObjectMetadataItemsRelationPickerEffect';
 import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
 import { FieldContext } from '@/object-record/record-field/contexts/FieldContext';
@@ -209,7 +208,6 @@ export const RecordDetailRelationSection = ({
                       />
                     ) : (
                       <>
-                        <ObjectMetadataItemsRelationPickerEffect />
                         <RelationFromManyFieldInputMultiRecordsEffect />
                         <MultiRecordSelect
                           onCreate={createNewRecordAndOpenRightDrawer}

packages/twenty-front/src/modules/object-record/relation-picker/components/SingleEntitySelectMenuItemsWithSearch.tsx

@@ -1,4 +1,3 @@
-import { ObjectMetadataItemsRelationPickerEffect } from '@/object-metadata/components/ObjectMetadataItemsRelationPickerEffect';
 import {
   SingleEntitySelectMenuItems,
   SingleEntitySelectMenuItemsProps,
@@ -65,9 +64,6 @@ export const SingleEntitySelectMenuItemsWithSearch = ({
 
   return (
     <>
-      <ObjectMetadataItemsRelationPickerEffect
-        relationPickerScopeId={relationPickerScopeId}
-      />
       <DropdownMenuSearchInput onChange={handleSearchFilterChange} autoFocus />
       <DropdownMenuSeparator />
       <SingleEntitySelectMenuItems

packages/twenty-front/src/modules/object-record/relation-picker/hooks/useRelationPickerEntitiesOptions.ts

@@ -18,24 +18,15 @@ export const useRelationPickerEntitiesOptions = ({
     RelationPickerScopeInternalContext,
   );
 
-  const { searchQueryState, relationPickerSearchFilterState } =
-    useRelationPickerScopedStates({
-      relationPickerScopedId: scopeId,
-    });
+  const { relationPickerSearchFilterState } = useRelationPickerScopedStates({
+    relationPickerScopedId: scopeId,
+  });
   const relationPickerSearchFilter = useRecoilValue(
     relationPickerSearchFilterState,
   );
 
-  const searchQuery = useRecoilValue(searchQueryState);
   const entities = useFilteredSearchEntityQuery({
-    filters: [
-      {
-        fieldNames:
-          searchQuery?.computeFilterFields?.(relationObjectNameSingular) ?? [],
-        filter: relationPickerSearchFilter,
-      },
-    ],
-    orderByField: 'createdAt',
+    searchFilter: relationPickerSearchFilter,
     selectedIds: selectedRelationRecordIds,
     excludeRecordIds: excludedRelationRecordIds,
     objectNameSingular: relationObjectNameSingular,

packages/twenty-front/src/modules/object-record/utils/generateSearchRecordsQuery.ts

@@ -15,12 +15,14 @@ export const generateSearchRecordsQuery = ({
   computeReferences,
 }: {
   objectMetadataItem: ObjectMetadataItem;
-  objectMetadataItems: ObjectMetadataItem[]; // TODO - what is this used for?
+  objectMetadataItems: ObjectMetadataItem[];
   recordGqlFields?: RecordGqlOperationGqlRecordFields;
   computeReferences?: boolean;
 }) => gql`
-    query Search${capitalize(objectMetadataItem.namePlural)}($search: String, $limit: Int) {
-  ${getSearchRecordsQueryResponseField(objectMetadataItem.namePlural)}(searchInput: $search, limit: $limit){
+    query Search${capitalize(objectMetadataItem.namePlural)}($search: String, $limit: Int, $filter: ${capitalize(
+      objectMetadataItem.nameSingular,
+    )}FilterInput) {
+  ${getSearchRecordsQueryResponseField(objectMetadataItem.namePlural)}(searchInput: $search, limit: $limit, filter: $filter){
     edges {
       node ${mapObjectMetadataToGraphQLQuery({
         objectMetadataItems,