admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix order by (#2646)

Browse Source 
* Order by createdAt desc if no sort provided

* Fix '0' currency amounts

* Code review returns
This commit is contained in:
martmull
2023-11-22 16:19:04 +01:00
committed by GitHub
parent 0af4be0d24
commit 713eada9ef
4 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
front/src/utils/convert-currency-amount.ts
View File

@ -1,3 +1,5 @@
import { isUndefined } from '@sniptt/guards';
export const convertCurrencyToCurrencyMicros = (
currencyAmount: number | undefined,
) => {
@ -18,13 +20,12 @@ export const convertCurrencyToCurrencyMicros = (
export const convertCurrencyMicrosToCurrency = (
currencyAmountMicros: number | undefined,
) => {
if (!currencyAmountMicros) {
if (isUndefined(currencyAmountMicros)) {
return undefined;
}
const currencyAmountMicrosAsNumber = +currencyAmountMicros;
if (isNaN(currencyAmountMicrosAsNumber)) {
throw new Error(`Cannot convert ${currencyAmountMicros} to currency`);
}
const currencyAmount = currencyAmountMicrosAsNumber / 1000000;
return currencyAmount;
return currencyAmountMicrosAsNumber / 1000000;
};