admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor/remove react table (#642)

Browse Source 
* Refactored tables without tan stack
* Fixed checkbox behavior with multiple handlers on click
* Fixed hotkeys scope
* Fix debounce in editable cells
* Lowered coverage

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Lucas Bordeau
2023-07-13 19:08:13 +02:00
committed by GitHub
parent e7d48d5373
commit 734e18e01a
88 changed files with 1789 additions and 671 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
front/src/pages/people/__stories__/People.inputs.stories.tsx
View File

@ -32,18 +32,12 @@ export const InteractWithManyRows: Story = {
let firstRowEmailCell = await canvas.findByText(mockedPeopleData[0].email);
let secondRowEmailCell = await canvas.findByText(mockedPeopleData[1].email);
expect(
canvas.queryByTestId('editable-cell-edit-mode-container'),
).toBeNull();
await userEvent.click(firstRowEmailCell);
await sleep(100);
firstRowEmailCell = await canvas.findByText(mockedPeopleData[0].email);
await userEvent.click(firstRowEmailCell);
await sleep(100);
firstRowEmailCell = await canvas.findByText(mockedPeopleData[0].email);
await userEvent.click(firstRowEmailCell);
@ -51,7 +45,9 @@ export const InteractWithManyRows: Story = {
canvas.queryByTestId('editable-cell-edit-mode-container'),
).toBeInTheDocument();
secondRowEmailCell = await canvas.findByText(mockedPeopleData[1].email);
const secondRowEmailCell = await canvas.findByText(
mockedPeopleData[1].email,
);
await userEvent.click(secondRowEmailCell);
await sleep(25);

6
front/src/pages/people/__stories__/People.sortBy.stories.tsx
View File

@ -31,12 +31,6 @@ export const Email: Story = {
expect(await canvas.getByTestId('remove-icon-email')).toBeInTheDocument();
expect(await canvas.findByText('Alexandre Prot')).toBeInTheDocument();
expect(
(await canvas.findAllByRole('checkbox')).map((item) => {
return item.getAttribute('id');
})[1],
).toStrictEqual('checkbox-selected-7dfbc3f7-6e5e-4128-957e-8d86808cdf6b');
},
parameters: {
msw: graphqlMocks,