From 74cf00a36d264294c77b6c9a0fbdf6d9fff89f61 Mon Sep 17 00:00:00 2001
From: Lucas Bordeau <bordeau.lucas@gmail.com>
Date: Mon, 23 Dec 2024 15:57:09 +0100
Subject: [PATCH] Fixed dragging with empty orphan favorites (#9205)

Created a resizable container tied to dragging state to create suitable
droppable zone when there's no orphan favorites.

Co-authored-by: Weiko <corentin@twenty.com>
---
 .../favorites/components/CurrentWorkspaceMemberFavorites.tsx   | 3 ---
 .../components/CurrentWorkspaceMemberOrphanFavorites.tsx       | 3 +--
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx b/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
index f4a6cea37..47508ad31 100644
--- a/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
+++ b/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
@@ -158,9 +158,6 @@ export const CurrentWorkspaceMemberFavorites = ({
                 ref={provided.innerRef}
                 // eslint-disable-next-line react/jsx-props-no-spreading
                 {...provided.droppableProps}
-                style={{
-                  marginBottom: 15,
-                }}
                 // TODO: (Drag Drop Bug) Adding bottom margin to ensure drag-to-last-position works. Need to find better solution that doesn't affect spacing.
                 // Issue: Without margin, dragging to last position triggers next folder drop area
               >
diff --git a/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsx b/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsx
index 2db37d492..bdb42cf81 100644
--- a/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsx
+++ b/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsx
@@ -13,7 +13,6 @@ import { useLocation } from 'react-router-dom';
 import { IconHeartOff } from 'twenty-ui';
 
 const StyledEmptyContainer = styled.div`
-  height: ${({ theme }) => theme.spacing(2.5)};
   width: 100%;
 `;
 
@@ -67,7 +66,7 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => {
           />
         ))
       ) : (
-        <StyledEmptyContainer />
+        <StyledEmptyContainer style={{ height: isDragging ? '24px' : '1px' }} />
       )}
     </FavoritesDroppable>
   );