From 764a3ebfde8ba7261861812f44be3e5c5d0c6e1c Mon Sep 17 00:00:00 2001
From: bosiraphael <71827178+bosiraphael@users.noreply.github.com>
Date: Mon, 15 Apr 2024 15:45:38 +0200
Subject: [PATCH] 4501 improve filters for emails imports (#4966)

- Reduce gmailSearchFilterNonPersonalEmails to the essential
- Filter out promotions, social media and forums emails
---
 .../modules/messaging/utils/gmail-search-filter.util.ts   | 6 +++---
 .../src/modules/messaging/utils/is-person-email.util.ts   | 8 --------
 2 files changed, 3 insertions(+), 11 deletions(-)
 delete mode 100644 packages/twenty-server/src/modules/messaging/utils/is-person-email.util.ts

diff --git a/packages/twenty-server/src/modules/messaging/utils/gmail-search-filter.util.ts b/packages/twenty-server/src/modules/messaging/utils/gmail-search-filter.util.ts
index cbfe5d522..38b12ca33 100644
--- a/packages/twenty-server/src/modules/messaging/utils/gmail-search-filter.util.ts
+++ b/packages/twenty-server/src/modules/messaging/utils/gmail-search-filter.util.ts
@@ -1,14 +1,14 @@
 export const gmailSearchFilterNonPersonalEmails =
-  'noreply|no-reply|do_not_reply|no.reply|accounts@|info@|admin@|contact@|hello@|support@|sales@|feedback@|service@|help@|mailer-daemon|notifications|digest|auto|apps|assign|comments|customer-success|enterprise|esign|express|forum|gc@|learn|mailer|marketing|messages|news|notification|payments|receipts|recrutement|security|service|support|team';
+  '*noreply@|*no-reply@|*do_not_reply@|*no.reply@|*info@|*contact@|*hello@|*support@|*feedback@|*service@|*help@';
 
 export const gmailSearchFilterExcludeEmails = (emails: string[]): string => {
   if (emails.length === 0) {
-    return `from:-(${gmailSearchFilterNonPersonalEmails}`;
+    return `from:-(${gmailSearchFilterNonPersonalEmails} -category:promotions -category:social -category:forums`;
   }
 
   return `(in:inbox from:-(${gmailSearchFilterNonPersonalEmails}|${emails.join(
     '|',
   )})|(in:sent to:-(${gmailSearchFilterNonPersonalEmails}|${emails.join(
     '|',
-  )}))`;
+  )})) -category:promotions -category:social -category:forums`;
 };
diff --git a/packages/twenty-server/src/modules/messaging/utils/is-person-email.util.ts b/packages/twenty-server/src/modules/messaging/utils/is-person-email.util.ts
deleted file mode 100644
index 387a94e50..000000000
--- a/packages/twenty-server/src/modules/messaging/utils/is-person-email.util.ts
+++ /dev/null
@@ -1,8 +0,0 @@
-export const isPersonEmail = (email: string | undefined): boolean => {
-  if (!email) return false;
-
-  const nonPersonalPattern =
-    /noreply|no-reply|do_not_reply|no\.reply|^(accounts@|info@|admin@|contact@|hello@|support@|sales@|feedback@|service@|help@|mailer-daemon|notifications?|digest|auto|apps|assign|comments|customer-success|enterprise|esign|express|forum|gc@|learn|mailer|marketing|messages|news|notification|payments|receipts|recrutement|security|service|support|team)/;
-
-  return !nonPersonalPattern.test(email);
-};