From 7752be8f9a22854bc1a5527c7a257349319747b3 Mon Sep 17 00:00:00 2001 From: martmull Date: Tue, 28 Nov 2023 10:02:21 +0100 Subject: [PATCH] Remove mandatory parameters (#2743) --- packages/twenty-zapier/src/creates/create_company.ts | 6 +++--- packages/twenty-zapier/src/creates/create_person.ts | 2 +- .../src/test/creates/create_company.test.ts | 12 ++---------- .../src/test/creates/create_person.test.ts | 8 ++------ 4 files changed, 8 insertions(+), 20 deletions(-) diff --git a/packages/twenty-zapier/src/creates/create_company.ts b/packages/twenty-zapier/src/creates/create_company.ts index e3b7754d3..bf10508f2 100644 --- a/packages/twenty-zapier/src/creates/create_company.ts +++ b/packages/twenty-zapier/src/creates/create_company.ts @@ -26,7 +26,7 @@ export default { key: 'name', label: 'Company Name', type: 'string', - required: true, + required: false, list: false, altersDynamicFields: false, }, @@ -34,7 +34,7 @@ export default { key: 'address', label: 'Address', type: 'string', - required: true, + required: false, list: false, altersDynamicFields: false, }, @@ -42,7 +42,7 @@ export default { key: 'domainName', label: 'Url', type: 'string', - required: true, + required: false, list: false, altersDynamicFields: false, }, diff --git a/packages/twenty-zapier/src/creates/create_person.ts b/packages/twenty-zapier/src/creates/create_person.ts index 63174ebf9..0e90a371d 100644 --- a/packages/twenty-zapier/src/creates/create_person.ts +++ b/packages/twenty-zapier/src/creates/create_person.ts @@ -42,7 +42,7 @@ export default { key: 'email', label: 'Email', type: 'string', - required: true, + required: false, list: false, altersDynamicFields: false, }, diff --git a/packages/twenty-zapier/src/test/creates/create_company.test.ts b/packages/twenty-zapier/src/test/creates/create_company.test.ts index 81799a5d6..8992a12e8 100644 --- a/packages/twenty-zapier/src/test/creates/create_company.test.ts +++ b/packages/twenty-zapier/src/test/creates/create_company.test.ts @@ -36,16 +36,8 @@ describe('creates.create_company', () => { 100000000000, ); }); - test('should run with not required missing params', async () => { - const bundle = getBundle({ - name: 'Company Name', - address: 'Company Address', - domainName: 'Company Domain Name', - linkedinLink: {url: '/linkedin_url', label: "Test linkedinUrl"}, - xLink: {url: '/x_url', label: "Test xUrl"}, - idealCustomerProfile: true, - employees: 25, - }); + test('should run with not required params', async () => { + const bundle = getBundle({}); const result = await appTester( App.creates.create_company.operation.perform, bundle, diff --git a/packages/twenty-zapier/src/test/creates/create_person.test.ts b/packages/twenty-zapier/src/test/creates/create_person.test.ts index a50c30d3e..1ede216b9 100644 --- a/packages/twenty-zapier/src/test/creates/create_person.test.ts +++ b/packages/twenty-zapier/src/test/creates/create_person.test.ts @@ -31,12 +31,8 @@ describe('creates.create_person', () => { expect(checkDbResult.data.person.phone).toEqual('+33610203040'); }); - test('should run with not required missing params', async () => { - const bundle = getBundle({ - name: {firstName: 'John', lastName: 'Doe'}, - email: 'johndoe@gmail.com', - city: 'Paris', - }); + test('should run with not required params', async () => { + const bundle = getBundle({}); const results = await appTester( App.creates.create_person.operation.perform, bundle,