admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[9382][FRONT]: Compute highlighted object view using raw name plural (#9394)

Browse Source 
# Introduction
Please find related ticket here #9382
To fix the issue the solution seems to be to stop searching for last
viewed `objectMetadata` using their slugged version `namePlural`

## Upcoming cleanup
After discussing with @charlesBochet it seems like a bad practice to
slug the `objectMetadata`, in this way in a following PR we will suggest
a cleanup of the remaining method that does within the
`useFilteredObjectMetadataItems.ts`

## Conclusion
As always any suggestions are welcomed !
Please let me know

closes #9382

---------

Co-authored-by: Paul Rastoin <paulrastoin@Pauls-MacBook-Pro.local>
This commit is contained in:
Paul Rastoin
2025-01-07 15:20:54 +01:00
committed by GitHub
parent 04f648f7f3
commit 7b70f7d93b
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-front/src/modules/navigation/hooks/useLastVisitedView.ts
View File

@ -29,7 +29,7 @@ export const useLastVisitedView = () => {
setLastVisitedViewPerObjectMetadataItem, setLastVisitedViewPerObjectMetadataItem,
] = useRecoilState(lastVisitedViewPerObjectMetadataItemState); ] = useRecoilState(lastVisitedViewPerObjectMetadataItemState);
const { findActiveObjectMetadataItemBySlug } = const { findActiveObjectMetadataItemByNamePlural } =
useFilteredObjectMetadataItems(); useFilteredObjectMetadataItems();
const setFallbackForLastVisitedView = (objectMetadataItemId: string) => { const setFallbackForLastVisitedView = (objectMetadataItemId: string) => {
@ -49,7 +49,7 @@ export const useLastVisitedView = () => {
viewId: string; viewId: string;
}) => { }) => {
const fallbackObjectMetadataItem = const fallbackObjectMetadataItem =
findActiveObjectMetadataItemBySlug(objectNamePlural); findActiveObjectMetadataItemByNamePlural(objectNamePlural);
if (isDefined(fallbackObjectMetadataItem)) { if (isDefined(fallbackObjectMetadataItem)) {
/* when both are equal meaning there was change in view else /* when both are equal meaning there was change in view else
@ -72,7 +72,7 @@ export const useLastVisitedView = () => {
objectNamePlural: string, objectNamePlural: string,
) => { ) => {
const objectMetadataItemId: string | undefined = const objectMetadataItemId: string | undefined =
findActiveObjectMetadataItemBySlug(objectNamePlural)?.id; findActiveObjectMetadataItemByNamePlural(objectNamePlural)?.id;
return objectMetadataItemId return objectMetadataItemId
? lastVisitedViewPerObjectMetadataItem?.[objectMetadataItemId] ? lastVisitedViewPerObjectMetadataItem?.[objectMetadataItemId]
: undefined; : undefined;

7
packages/twenty-front/src/modules/object-metadata/hooks/useFilteredObjectMetadataItems.ts
View File

@ -38,6 +38,12 @@ export const useFilteredObjectMetadataItems = () => {
getObjectSlug(activeObjectMetadataItem) === slug, getObjectSlug(activeObjectMetadataItem) === slug,
); );
const findActiveObjectMetadataItemByNamePlural = (namePlural: string) =>
activeObjectMetadataItems.find(
(activeObjectMetadataItem) =>
activeObjectMetadataItem.namePlural === namePlural,
);
const findObjectMetadataItemById = (id: string) => const findObjectMetadataItemById = (id: string) =>
objectMetadataItems.find( objectMetadataItems.find(
(objectMetadataItem) => objectMetadataItem.id === id, (objectMetadataItem) => objectMetadataItem.id === id,
@ -53,6 +59,7 @@ export const useFilteredObjectMetadataItems = () => {
findActiveObjectMetadataItemBySlug, findActiveObjectMetadataItemBySlug,
findObjectMetadataItemById, findObjectMetadataItemById,
findObjectMetadataItemByNamePlural, findObjectMetadataItemByNamePlural,
findActiveObjectMetadataItemByNamePlural,
inactiveObjectMetadataItems, inactiveObjectMetadataItems,
objectMetadataItems, objectMetadataItems,
findObjectMetadataItemBySlug, findObjectMetadataItemBySlug,