Revert "Convert metadata tables to camelCase" (#2419)

Revert "Convert metadata tables to camelCase (#2400)"

This reverts commit 1cf08c797f.
This commit is contained in:
Charles Bochet
2023-11-10 11:48:44 +01:00
committed by GitHub
parent 1cf08c797f
commit 7b9175a4a4
238 changed files with 2253 additions and 1852 deletions

View File

@ -9,7 +9,7 @@ export const useFieldInitialValue = () => {
const fieldInitialValue = useRecoilValue(
entityFieldInitialValueFamilyState({
fieldMetadataId: fieldDefinition.fieldMetadataId,
fieldId: fieldDefinition.fieldId,
entityId,
}),
);

View File

@ -10,7 +10,7 @@ export const useIsFieldEmpty = () => {
const isFieldEmpty = useRecoilValue(
isEntityFieldEmptyFamilySelector({
fieldDefinition: {
fieldMetadataId: fieldDefinition.fieldMetadataId,
fieldId: fieldDefinition.fieldId,
label: fieldDefinition.label,
type: fieldDefinition.type,
metadata: fieldDefinition.metadata,

View File

@ -27,7 +27,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'date',
fieldId: 'date',
label: 'Date',
type: 'DATE',
metadata: {

View File

@ -32,7 +32,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'double-text',
fieldId: 'double-text',
label: 'Double-Text',
type: 'DOUBLE_TEXT',
metadata: {

View File

@ -26,7 +26,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'email',
fieldId: 'email',
label: 'Email',
type: 'EMAIL',
metadata: {

View File

@ -25,7 +25,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'money',
fieldId: 'money',
label: 'Money',
type: 'MONEY_AMOUNT',
metadata: {

View File

@ -25,7 +25,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'number',
fieldId: 'number',
label: 'Number',
type: 'NUMBER',
metadata: {

View File

@ -26,7 +26,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'phone',
fieldId: 'phone',
label: 'Phone',
type: 'PHONE',
metadata: {

View File

@ -25,7 +25,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'text',
fieldId: 'text',
label: 'Text',
type: 'TEXT',
metadata: {

View File

@ -26,7 +26,7 @@ const meta: Meta = {
value={{
entityId: '',
fieldDefinition: {
fieldMetadataId: 'URL',
fieldId: 'URL',
label: 'URL',
type: 'URL',
metadata: {

View File

@ -34,7 +34,7 @@ const BooleanFieldInputWithContext = ({
return (
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'boolean',
fieldId: 'boolean',
label: 'Boolean',
type: 'BOOLEAN',
metadata: {

View File

@ -44,7 +44,7 @@ const ChipFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'chip',
fieldId: 'chip',
label: 'Chip',
type: 'CHIP',
metadata: {

View File

@ -44,7 +44,7 @@ const DateFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'date',
fieldId: 'date',
label: 'Date',
type: 'DATE',
metadata: {

View File

@ -57,7 +57,7 @@ const DoubleTextChipFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'double-text-chip',
fieldId: 'double-text-chip',
label: 'Double-Text-Chip',
type: 'DOUBLE_TEXT_CHIP',
metadata: {

View File

@ -55,7 +55,7 @@ const DoubleTextFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'double-text',
fieldId: 'double-text',
label: 'Double-Text',
type: 'DOUBLE_TEXT',
metadata: {

View File

@ -43,7 +43,7 @@ const EmailFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'email',
fieldId: 'email',
label: 'Email',
type: 'EMAIL',
metadata: {

View File

@ -43,7 +43,7 @@ const MoneyFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'moneyAmount',
fieldId: 'moneyAmount',
label: 'MoneyAmout',
type: 'MONEY_AMOUNT',
metadata: {

View File

@ -43,7 +43,7 @@ const NumberFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'number',
fieldId: 'number',
label: 'Number',
type: 'NUMBER',
metadata: {

View File

@ -43,7 +43,7 @@ const PhoneFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'phone',
fieldId: 'phone',
label: 'Phone',
type: 'PHONE',
metadata: {

View File

@ -41,7 +41,7 @@ const ProbabilityFieldInputWithContext = ({
return (
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'probability',
fieldId: 'probability',
label: 'Probability',
type: 'PROBABILITY',
metadata: {

View File

@ -46,7 +46,7 @@ const RelationFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'relation',
fieldId: 'relation',
label: 'Relation',
type: 'RELATION',
metadata: {

View File

@ -43,7 +43,7 @@ const TextFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'text',
fieldId: 'text',
label: 'Text',
type: 'TEXT',
metadata: {

View File

@ -43,7 +43,7 @@ const URLFieldInputWithContext = ({
<div>
<FieldContextProvider
fieldDefinition={{
fieldMetadataId: 'url',
fieldId: 'url',
label: 'URL',
type: 'URL',
metadata: {

View File

@ -4,7 +4,7 @@ import { FieldInitialValue } from '../types/FieldInitialValue';
export const entityFieldInitialValueFamilyState = atomFamily<
FieldInitialValue | undefined,
{ entityId: string; fieldMetadataId: string }
{ entityId: string; fieldId: string }
>({
key: 'entityFieldInitialValueFamilyState',
default: undefined,

View File

@ -33,7 +33,7 @@ export const isEntityFieldEmptyFamilySelector = selectorFamily({
}: {
fieldDefinition: Pick<
FieldDefinition<FieldMetadata>,
'type' | 'metadata' | 'fieldMetadataId' | 'label'
'type' | 'metadata' | 'fieldId' | 'label'
>;
entityId: string;
}) => {

View File

@ -5,7 +5,7 @@ import { FieldMetadata } from './FieldMetadata';
import { FieldType } from './FieldType';
export type FieldDefinition<T extends FieldMetadata> = {
fieldMetadataId: string;
fieldId: string;
label: string;
Icon?: IconComponent;
type: FieldType;

View File

@ -14,7 +14,7 @@ export const ObjectFilterDropdownDateSearchInput = () => {
if (!filterDefinitionUsedInDropdown || !selectedOperandInDropdown) return;
selectFilter?.({
fieldMetadataId: filterDefinitionUsedInDropdown.fieldMetadataId,
fieldId: filterDefinitionUsedInDropdown.fieldId,
value: date.toISOString(),
operand: selectedOperandInDropdown,
displayValue: date.toLocaleDateString(),

View File

@ -42,7 +42,7 @@ export const ObjectFilterDropdownEntitySearchSelect = ({
selectFilter?.({
displayValue: selectedEntity.name,
fieldMetadataId: filterDefinitionUsedInDropdown.fieldMetadataId,
fieldId: filterDefinitionUsedInDropdown.fieldId,
operand: selectedOperandInDropdown,
value: selectedEntity.id,
displayAvatarUrl: selectedEntity.avatarUrl,
@ -72,7 +72,7 @@ export const ObjectFilterDropdownEntitySearchSelect = ({
selectFilter?.({
displayValue: filterDefinitionUsedInDropdown.selectAllLabel,
fieldMetadataId: filterDefinitionUsedInDropdown.fieldMetadataId,
fieldId: filterDefinitionUsedInDropdown.fieldId,
operand: ViewFilterOperand.IsNotNull,
value: '',
definition: filterDefinitionUsedInDropdown,

View File

@ -20,7 +20,7 @@ export const ObjectFilterDropdownNumberSearchInput = () => {
placeholder={filterDefinitionUsedInDropdown.label}
onChange={(event: ChangeEvent<HTMLInputElement>) => {
selectFilter?.({
fieldMetadataId: filterDefinitionUsedInDropdown.fieldMetadataId,
fieldId: filterDefinitionUsedInDropdown.fieldId,
value: event.target.value,
operand: selectedOperandInDropdown,
displayValue: event.target.value,

View File

@ -26,7 +26,7 @@ export const ObjectFilterDropdownOperandSelect = () => {
if (filterDefinitionUsedInDropdown && selectedFilter) {
selectFilter?.({
fieldMetadataId: selectedFilter.fieldMetadataId,
fieldId: selectedFilter.fieldId,
displayValue: selectedFilter.displayValue,
operand: newOperand,
value: selectedFilter.value,

View File

@ -26,7 +26,7 @@ export const ObjectFilterDropdownTextSearchInput = () => {
setObjectFilterDropdownSearchInput(event.target.value);
selectFilter?.({
fieldMetadataId: filterDefinitionUsedInDropdown.fieldMetadataId,
fieldId: filterDefinitionUsedInDropdown.fieldId,
value: event.target.value,
operand: selectedOperandInDropdown,
displayValue: event.target.value,

View File

@ -3,7 +3,7 @@ import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { FilterDefinition } from './FilterDefinition';
export type Filter = {
fieldMetadataId: string;
fieldId: string;
value: string;
displayValue: string;
displayAvatarUrl?: string;

View File

@ -3,7 +3,7 @@ import { IconComponent } from '@/ui/display/icon/types/IconComponent';
import { FilterType } from './FilterType';
export type FilterDefinition = {
fieldMetadataId: string;
fieldId: string;
label: string;
Icon: IconComponent;
type: FilterType;

View File

@ -1,5 +1,5 @@
import { FilterDefinition } from './FilterDefinition';
export type FilterDefinitionByEntity<T> = FilterDefinition & {
fieldMetadataId: keyof T;
fieldId: keyof T;
};

View File

@ -18,7 +18,7 @@ export const turnFilterIntoWhereClause = (
switch (filter.operand) {
case ViewFilterOperand.IsNotNull:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
not: null,
},
};
@ -28,14 +28,14 @@ export const turnFilterIntoWhereClause = (
switch (filter.operand) {
case ViewFilterOperand.Contains:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
contains: filter.value,
mode: QueryMode.Insensitive,
},
};
case ViewFilterOperand.DoesNotContain:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
not: {
contains: filter.value,
mode: QueryMode.Insensitive,
@ -51,13 +51,13 @@ export const turnFilterIntoWhereClause = (
switch (filter.operand) {
case ViewFilterOperand.GreaterThan:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
gte: parseFloat(filter.value),
},
};
case ViewFilterOperand.LessThan:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
lte: parseFloat(filter.value),
},
};
@ -70,13 +70,13 @@ export const turnFilterIntoWhereClause = (
switch (filter.operand) {
case ViewFilterOperand.GreaterThan:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
gte: filter.value,
},
};
case ViewFilterOperand.LessThan:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
lte: filter.value,
},
};
@ -89,13 +89,13 @@ export const turnFilterIntoWhereClause = (
switch (filter.operand) {
case ViewFilterOperand.Is:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
equals: filter.value,
},
};
case ViewFilterOperand.IsNot:
return {
[filter.fieldMetadataId]: {
[filter.fieldId]: {
not: { equals: filter.value },
},
};

View File

@ -17,11 +17,11 @@ export const turnFiltersIntoWhereClauseV2 = (
filters.forEach((filter) => {
const correspondingField = fields.find(
(field) => field.id === filter.fieldMetadataId,
(field) => field.id === filter.fieldId,
);
if (!correspondingField) {
throw new Error(
`Could not find field ${filter.fieldMetadataId} in metadata object`,
`Could not find field ${filter.fieldId} in metadata object`,
);
}

View File

@ -50,7 +50,7 @@ export const ObjectSortDropdownButton = ({
const handleAddSort = (selectedSortDefinition: SortDefinition) => {
toggleDropdown();
onSortSelect?.({
fieldMetadataId: selectedSortDefinition.fieldMetadataId,
fieldId: selectedSortDefinition.fieldId,
direction: selectedSortDirection,
definition: selectedSortDefinition,
});

View File

@ -2,7 +2,7 @@ import { SortDefinition } from './SortDefinition';
import { SortDirection } from './SortDirection';
export type Sort = {
fieldMetadataId: string;
fieldId: string;
direction: SortDirection;
definition: SortDefinition;
};

View File

@ -3,7 +3,7 @@ import { IconComponent } from '@/ui/display/icon/types/IconComponent';
import { SortDirection } from './SortDirection';
export type SortDefinition = {
fieldMetadataId: string;
fieldId: string;
label: string;
Icon?: IconComponent;
getOrderByTemplate?: (direction: SortDirection) => any[];

View File

@ -10,7 +10,7 @@ export const reduceSortsToOrderBy = (sorts: Sort[]): any[] =>
if (sort.definition.getOrderByTemplate) {
return sort.definition.getOrderByTemplate(direction);
} else {
return [{ [sort.definition.fieldMetadataId]: direction }];
return [{ [sort.definition.fieldId]: direction }];
}
})
.flat();

View File

@ -9,11 +9,11 @@ export const turnSortsIntoOrderByV2 = (
const sortsObject: Record<string, 'AscNullsFirst' | 'DescNullsLast'> = {};
sorts.forEach((sort) => {
const correspondingField = fields.find(
(field) => field.id === sort.fieldMetadataId,
(field) => field.id === sort.fieldId,
);
if (!correspondingField) {
throw new Error(
`Could not find field ${sort.fieldMetadataId} in metadata object`,
`Could not find field ${sort.fieldId} in metadata object`,
);
}
const direction =

View File

@ -21,7 +21,7 @@ export const ColumnHeadWithDropdown = ({
primaryColumnKey,
}: ColumnHeadWithDropdownProps) => {
return (
<DropdownScope dropdownScopeId={column.fieldMetadataId + '-header'}>
<DropdownScope dropdownScopeId={column.fieldId + '-header'}>
<Dropdown
clickableComponent={<ColumnHead column={column} />}
dropdownComponents={
@ -34,7 +34,7 @@ export const ColumnHeadWithDropdown = ({
}
dropdownOffset={{ x: -1 }}
dropdownPlacement="bottom-start"
dropdownHotkeyScope={{ scope: column.fieldMetadataId + '-header' }}
dropdownHotkeyScope={{ scope: column.fieldId + '-header' }}
/>
</DropdownScope>
);

View File

@ -46,7 +46,7 @@ export const RecordTableColumnDropdownMenu = ({
handleColumnVisibilityChange(column);
};
return column.fieldMetadataId === primaryColumnKey ? (
return column.fieldId === primaryColumnKey ? (
<></>
) : (
<DropdownMenuItemsContainer>

View File

@ -156,7 +156,7 @@ export const RecordTableHeader = () => {
if (nextWidth !== tableColumnsByKey[resizedFieldKey].size) {
const nextColumns = tableColumns.map((column) =>
column.fieldMetadataId === resizedFieldKey
column.fieldId === resizedFieldKey
? { ...column, size: nextWidth }
: column,
);
@ -194,13 +194,11 @@ export const RecordTableHeader = () => {
</th>
{visibleTableColumns.map((column) => (
<StyledColumnHeaderCell
key={column.fieldMetadataId}
isResizing={resizedFieldKey === column.fieldMetadataId}
key={column.fieldId}
isResizing={resizedFieldKey === column.fieldId}
columnWidth={Math.max(
tableColumnsByKey[column.fieldMetadataId].size +
(resizedFieldKey === column.fieldMetadataId
? resizeFieldOffset
: 0),
tableColumnsByKey[column.fieldId].size +
(resizedFieldKey === column.fieldId ? resizeFieldOffset : 0),
COLUMN_MIN_WIDTH,
)}
>
@ -211,21 +209,20 @@ export const RecordTableHeader = () => {
isLastColumn={
column.position === visibleTableColumns.length - 1
}
primaryColumnKey={primaryColumn?.fieldMetadataId || ''}
primaryColumnKey={primaryColumn?.fieldId || ''}
/>
</StyledColumnHeadContainer>
<StyledResizeHandler
className="cursor-col-resize"
role="separator"
onPointerDown={() => {
setResizedFieldKey(column.fieldMetadataId);
setResizedFieldKey(column.fieldId);
}}
/>
</StyledColumnHeaderCell>
))}
<StyledPlusIconHeaderCell>
{hiddenTableColumns.length > 0 && (
{hiddenTableColumns.length > 0 && (
<StyledPlusIconHeaderCell>
<DropdownScope
dropdownScopeId={HIDDEN_TABLE_COLUMN_DROPDOWN_SCOPE_ID}
>
@ -242,8 +239,8 @@ export const RecordTableHeader = () => {
}}
/>
</DropdownScope>
)}
</StyledPlusIconHeaderCell>
</StyledPlusIconHeaderCell>
)}
</tr>
</StyledTableHead>
);

View File

@ -32,7 +32,7 @@ export const RecordTableHeaderPlusButtonContent = () => {
<DropdownMenuItemsContainer>
{hiddenTableColumns.map((column) => (
<MenuItem
key={column.fieldMetadataId}
key={column.fieldId}
iconButtons={[
{
Icon: IconPlus,

View File

@ -42,7 +42,7 @@ export const RecordTableRow = forwardRef<
.sort((columnA, columnB) => columnA.position - columnB.position)
.map((column, columnIndex) => {
return (
<ColumnContext.Provider value={column} key={column.fieldMetadataId}>
<ColumnContext.Provider value={column} key={column.fieldId}>
<RecordTableCell cellIndex={columnIndex} />
</ColumnContext.Provider>
);

View File

@ -47,14 +47,13 @@ export const useTableColumns = () => {
viewField: Omit<ColumnDefinition<FieldMetadata>, 'size' | 'position'>,
) => {
const isNewColumn = !tableColumns.some(
(tableColumns) =>
tableColumns.fieldMetadataId === viewField.fieldMetadataId,
(tableColumns) => tableColumns.fieldId === viewField.fieldId,
);
if (isNewColumn) {
const newColumn = availableTableColumns.find(
(availableTableColumn) =>
availableTableColumn.fieldMetadataId === viewField.fieldMetadataId,
availableTableColumn.fieldId === viewField.fieldId,
);
if (!newColumn) return;
@ -66,7 +65,7 @@ export const useTableColumns = () => {
await handleColumnsChange(nextColumns);
} else {
const nextColumns = tableColumns.map((previousColumn) =>
previousColumn.fieldMetadataId === viewField.fieldMetadataId
previousColumn.fieldId === viewField.fieldId
? { ...previousColumn, isVisible: !viewField.isVisible }
: previousColumn,
);
@ -83,8 +82,7 @@ export const useTableColumns = () => {
column: ColumnDefinition<FieldMetadata>,
) => {
const currentColumnArrayIndex = visibleTableColumns.findIndex(
(visibleColumn) =>
visibleColumn.fieldMetadataId === column.fieldMetadataId,
(visibleColumn) => visibleColumn.fieldId === column.fieldId,
);
const columns = handleColumnMove(

View File

@ -42,7 +42,7 @@ export const useTableCell = () => {
const [, setFieldInitialValue] = useRecoilState(
entityFieldInitialValueFamilyState({
entityId,
fieldMetadataId: fieldDefinition.fieldMetadataId,
fieldId: fieldDefinition.fieldId,
}),
);

View File

@ -9,10 +9,10 @@ export const hiddenTableColumnsScopedSelector = selectorFamily({
(scopeId: string) =>
({ get }) => {
const columns = get(tableColumnsScopedState({ scopeId }));
const columnKeys = columns.map(({ fieldMetadataId }) => fieldMetadataId);
const columnKeys = columns.map(({ fieldId }) => fieldId);
const otherAvailableColumns = get(
availableTableColumnsScopedState({ scopeId }),
).filter(({ fieldMetadataId }) => !columnKeys.includes(fieldMetadataId));
).filter(({ fieldId }) => !columnKeys.includes(fieldId));
return [
...columns.filter((column) => !column.isVisible),

View File

@ -12,8 +12,5 @@ export const savedTableColumnsByKeyFamilySelector = selectorFamily({
({ get }) =>
get(savedTableColumnsFamilyState(viewId)).reduce<
Record<string, ColumnDefinition<FieldMetadata>>
>(
(result, column) => ({ ...result, [column.fieldMetadataId]: column }),
{},
),
>((result, column) => ({ ...result, [column.fieldId]: column }), {}),
});

View File

@ -12,8 +12,5 @@ export const tableColumnsByKeyScopedSelector = selectorFamily({
({ get }) =>
get(tableColumnsScopedState({ scopeId })).reduce<
Record<string, ColumnDefinition<FieldMetadata>>
>(
(result, column) => ({ ...result, [column.fieldMetadataId]: column }),
{},
),
>((result, column) => ({ ...result, [column.fieldId]: column }), {}),
});

View File

@ -11,13 +11,12 @@ export const visibleTableColumnsScopedSelector = selectorFamily({
const columns = get(tableColumnsScopedState({ scopeId }));
const availableColumnKeys = get(
availableTableColumnsScopedState({ scopeId }),
).map(({ fieldMetadataId }) => fieldMetadataId);
).map(({ fieldId }) => fieldId);
return [...columns]
.filter(
(column) =>
column.isVisible &&
availableColumnKeys.includes(column.fieldMetadataId),
column.isVisible && availableColumnKeys.includes(column.fieldId),
)
.sort((a, b) => a.position - b.position);
},