Add integration tests for /metadata + fix relation deletion (#8706)

In this PR

1. Add integration tests for /metadata (master issue:
https://github.com/twentyhq/twenty/issues/8719)
2. Fix relation deletion: index on "from" object was not deleted,
impeding creation of a new relation between the same two objects A and B
after relation between A and B was deleted

packages/twenty-server/src/engine/metadata-modules/index-metadata/index-metadata.service.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 
-import { isDefined } from 'class-validator';
+import isEmpty from 'lodash.isempty';
 import { Repository } from 'typeorm';
 
 import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
@@ -19,6 +19,7 @@ import {
 } from 'src/engine/metadata-modules/workspace-migration/workspace-migration.entity';
 import { WorkspaceMigrationService } from 'src/engine/metadata-modules/workspace-migration/workspace-migration.service';
 import { computeObjectTargetTable } from 'src/engine/utils/compute-object-target-table.util';
+import { isDefined } from 'src/utils/is-defined';
 
 @Injectable()
 export class IndexMetadataService {
@@ -43,6 +44,10 @@ export class IndexMetadataService {
       (fieldMetadata) => fieldMetadata.name as string,
     );
 
+    if (isEmpty(columnNames)) {
+      throw new Error('Column names must not be empty');
+    }
+
     const indexName = `IDX_${generateDeterministicIndexName([tableName, ...columnNames])}`;
 
     let result: IndexMetadataEntity;
@@ -98,6 +103,44 @@ export class IndexMetadataService {
     );
   }
 
+  async deleteIndexMetadata(
+    workspaceId: string,
+    objectMetadata: ObjectMetadataEntity,
+    fieldMetadataToIndex: Partial<FieldMetadataEntity>[],
+  ) {
+    const tableName = computeObjectTargetTable(objectMetadata);
+
+    const columnNames: string[] = fieldMetadataToIndex.map(
+      (fieldMetadata) => fieldMetadata.name as string,
+    );
+
+    if (isEmpty(columnNames)) {
+      throw new Error('Column names must not be empty');
+    }
+
+    const indexName = `IDX_${generateDeterministicIndexName([tableName, ...columnNames])}`;
+
+    const indexMetadata = await this.indexMetadataRepository.findOne({
+      where: {
+        name: indexName,
+        objectMetadataId: objectMetadata.id,
+        workspaceId,
+      },
+    });
+
+    if (!indexMetadata) {
+      throw new Error(`Index metadata with name ${indexName} not found`);
+    }
+
+    try {
+      await this.indexMetadataRepository.delete(indexMetadata.id);
+    } catch (error) {
+      throw new Error(
+        `Failed to delete index metadata with name ${indexName} (error: ${error.message})`,
+      );
+    }
+  }
+
   async createIndexCreationMigration(
     workspaceId: string,
     objectMetadata: ObjectMetadataEntity,