[fix] Increment cache version after object/field/relation update (#5316)

Fixes #5276.

Updates were not triggering a cache version incrementation because they
do not trigger migrations while that is where the caching version logic
was.
We have decided to move the cache incrementation logic to the services.

packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/update-object.input.ts

@@ -1,14 +1,20 @@
 import { Field, InputType } from '@nestjs/graphql';
 
 import { BeforeUpdateOne } from '@ptc-org/nestjs-query-graphql';
-import { IsBoolean, IsOptional, IsString, IsUUID } from 'class-validator';
+import {
+  IsBoolean,
+  IsNotEmpty,
+  IsOptional,
+  IsString,
+  IsUUID,
+} from 'class-validator';
 
+import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
 import { IsValidMetadataName } from 'src/engine/decorators/metadata/is-valid-metadata-name.decorator';
 import { BeforeUpdateOneObject } from 'src/engine/metadata-modules/object-metadata/hooks/before-update-one-object.hook';
 
 @InputType()
-@BeforeUpdateOne(BeforeUpdateOneObject)
-export class UpdateObjectInput {
+export class UpdateObjectPayload {
   @IsString()
   @IsOptional()
   @Field({ nullable: true })
@@ -56,3 +62,17 @@ export class UpdateObjectInput {
   @Field({ nullable: true })
   imageIdentifierFieldMetadataId?: string;
 }
+
+@InputType()
+@BeforeUpdateOne(BeforeUpdateOneObject)
+export class UpdateOneObjectInput {
+  @Field(() => UpdateObjectPayload)
+  update: UpdateObjectPayload;
+
+  @IsNotEmpty()
+  @Field(() => UUIDScalarType, {
+    description: 'The id of the object to update',
+  })
+  @IsUUID()
+  id!: string;
+}

packages/twenty-server/src/engine/metadata-modules/object-metadata/hooks/before-update-one-object.hook.ts

@@ -12,12 +12,12 @@ import {
 import { Equal, In, Repository } from 'typeorm';
 
 import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
-import { UpdateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
+import { UpdateObjectPayload } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
 import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
 
 @Injectable()
-export class BeforeUpdateOneObject<T extends UpdateObjectInput>
+export class BeforeUpdateOneObject<T extends UpdateObjectPayload>
   implements BeforeUpdateOneHook<T, any>
 {
   constructor(
@@ -108,7 +108,7 @@ export class BeforeUpdateOneObject<T extends UpdateObjectInput>
 
   // This is temporary until we properly use the MigrationRunner to update column names
   private checkIfFieldIsEditable(
-    update: UpdateObjectInput,
+    update: UpdateObjectPayload,
     objectMetadata: ObjectMetadataEntity,
   ) {
     if (

packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.module.ts

@@ -18,12 +18,13 @@ import { RelationMetadataEntity } from 'src/engine/metadata-modules/relation-met
 import { ObjectMetadataResolver } from 'src/engine/metadata-modules/object-metadata/object-metadata.resolver';
 import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-flag.module';
 import { FeatureFlagEntity } from 'src/engine/core-modules/feature-flag/feature-flag.entity';
+import { WorkspaceCacheVersionModule } from 'src/engine/metadata-modules/workspace-cache-version/workspace-cache-version.module';
 
 import { ObjectMetadataService } from './object-metadata.service';
 import { ObjectMetadataEntity } from './object-metadata.entity';
 
 import { CreateObjectInput } from './dtos/create-object.input';
-import { UpdateObjectInput } from './dtos/update-object.input';
+import { UpdateObjectPayload } from './dtos/update-object.input';
 import { ObjectMetadataDTO } from './dtos/object-metadata.dto';
 
 @Module({
@@ -39,6 +40,7 @@ import { ObjectMetadataDTO } from './dtos/object-metadata.dto';
         DataSourceModule,
         WorkspaceMigrationModule,
         WorkspaceMigrationRunnerModule,
+        WorkspaceCacheVersionModule,
         FeatureFlagModule,
       ],
       services: [ObjectMetadataService],
@@ -47,7 +49,7 @@ import { ObjectMetadataDTO } from './dtos/object-metadata.dto';
           EntityClass: ObjectMetadataEntity,
           DTOClass: ObjectMetadataDTO,
           CreateDTOClass: CreateObjectInput,
-          UpdateDTOClass: UpdateObjectInput,
+          UpdateDTOClass: UpdateObjectPayload,
           ServiceClass: ObjectMetadataService,
           pagingStrategy: PagingStrategies.CURSOR,
           read: {
@@ -56,9 +58,7 @@ import { ObjectMetadataDTO } from './dtos/object-metadata.dto';
           create: {
             many: { disabled: true },
           },
-          update: {
-            many: { disabled: true },
-          },
+          update: { disabled: true },
           delete: { disabled: true },
           guards: [JwtAuthGuard],
         },

packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.resolver.ts

@@ -7,6 +7,7 @@ import { JwtAuthGuard } from 'src/engine/guards/jwt.auth.guard';
 import { ObjectMetadataDTO } from 'src/engine/metadata-modules/object-metadata/dtos/object-metadata.dto';
 import { DeleteOneObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/delete-object.input';
 import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
+import { UpdateOneObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
 
 @UseGuards(JwtAuthGuard)
 @Resolver(() => ObjectMetadataDTO)
@@ -20,4 +21,12 @@ export class ObjectMetadataResolver {
   ) {
     return this.objectMetadataService.deleteOneObject(input, workspaceId);
   }
+
+  @Mutation(() => ObjectMetadataDTO)
+  updateOneObject(
+    @Args('input') input: UpdateOneObjectInput,
+    @AuthWorkspace() { id: workspaceId }: Workspace,
+  ) {
+    return this.objectMetadataService.updateOneObject(input, workspaceId);
+  }
 }

packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts

@@ -60,6 +60,8 @@ import { computeColumnName } from 'src/engine/metadata-modules/field-metadata/ut
 import { DataSourceEntity } from 'src/engine/metadata-modules/data-source/data-source.entity';
 import { validateObjectMetadataInput } from 'src/engine/metadata-modules/object-metadata/utils/validate-object-metadata-input.util';
 import { mapUdtNameToFieldType } from 'src/engine/metadata-modules/remote-server/remote-table/utils/udt-name-mapper.util';
+import { WorkspaceCacheVersionService } from 'src/engine/metadata-modules/workspace-cache-version/workspace-cache-version.service';
+import { UpdateOneObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
 
 import { ObjectMetadataEntity } from './object-metadata.entity';
 
@@ -81,6 +83,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
     private readonly typeORMService: TypeORMService,
     private readonly workspaceMigrationService: WorkspaceMigrationService,
     private readonly workspaceMigrationRunnerService: WorkspaceMigrationRunnerService,
+    private readonly workspaceCacheVersionService: WorkspaceCacheVersionService,
   ) {
     super(objectMetadataRepository);
   }
@@ -225,6 +228,8 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       workspaceId,
     );
 
+    await this.workspaceCacheVersionService.incrementVersion(workspaceId);
+
     return objectMetadata;
   }
 
@@ -399,9 +404,24 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       );
     });
 
+    await this.workspaceCacheVersionService.incrementVersion(
+      objectMetadataInput.workspaceId,
+    );
+
     return createdObjectMetadata;
   }
 
+  public async updateOneObject(
+    input: UpdateOneObjectInput,
+    workspaceId: string,
+  ): Promise<ObjectMetadataEntity> {
+    const updatedObject = await super.updateOne(input.id, input.update);
+
+    await this.workspaceCacheVersionService.incrementVersion(workspaceId);
+
+    return updatedObject;
+  }
+
   public async findOneWithinWorkspace(
     workspaceId: string,
     options: FindOneOptions<ObjectMetadataEntity>,
@@ -475,6 +495,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
 
   public async deleteObjectsMetadata(workspaceId: string) {
     await this.objectMetadataRepository.delete({ workspaceId });
+    await this.workspaceCacheVersionService.incrementVersion(workspaceId);
   }
 
   private async createObjectRelationsMetadataAndMigrations(

packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/validate-object-metadata-input.util.ts

@@ -2,11 +2,11 @@ import { BadRequestException } from '@nestjs/common';
 
 import { InvalidStringException } from 'src/engine/metadata-modules/errors/InvalidStringException';
 import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
-import { UpdateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
+import { UpdateObjectPayload } from 'src/engine/metadata-modules/object-metadata/dtos/update-object.input';
 import { validateMetadataName } from 'src/engine/metadata-modules/utils/validate-metadata-name.utils';
 
 export const validateObjectMetadataInput = <
-  T extends UpdateObjectInput | CreateObjectInput,
+  T extends UpdateObjectPayload | CreateObjectInput,
 >(
   objectMetadataInput: T,
 ): void => {